Re: [Patch] Fix tree-optimization/49963

2011-08-18 Thread Richard Guenther
On Thu, 18 Aug 2011, Paolo Carlini wrote: > On 08/18/2011 10:30 AM, Richard Guenther wrote: > > Ok. > Great. Thus I'm going ahead and committing the patch to fix the regression. > > It looks like we might want to elimiate abs_hwi alltogether in favor of > > absu_hwi? > Indeed, you are totally rig

Re: [Patch] Fix tree-optimization/49963

2011-08-18 Thread Paolo Carlini
On 08/18/2011 10:30 AM, Richard Guenther wrote: Ok. Great. Thus I'm going ahead and committing the patch to fix the regression. It looks like we might want to elimiate abs_hwi alltogether in favor of absu_hwi? Indeed, you are totally right. But I'd rather work on that as a followup patch (may

Re: [Patch] Fix tree-optimization/49963

2011-08-18 Thread Richard Guenther
On Wed, 17 Aug 2011, Paolo Carlini wrote: > Hi, > > I prepared the below basing on an hint provided by Joseph on the audit trail: > essentially, I'm replacing all (but two) uses of abs_hwi outside hwint.c by > absu_hwi, a variant which returns an unsigned HOST_WIDE_INT. All the > replacements mak

Re: [Patch] Fix tree-optimization/49963

2011-08-17 Thread Georg-Johann Lay
Paolo Carlini wrote: I sanity checked the patch on x86_64-linux and OP reported that on AVR the patch fixes the regression. Not really "on" AVR; AVR are just tiny 8-bit microcontrollers ;-) I obseved the problem when compiling for AVR on a x86-linux-gnu host where 0x8000 is negative. J