Re: [Patch, fortran, RFC] Add warning for missing location information

2016-12-08 Thread Mikael Morin
Le 08/12/2016 à 22:50, Thomas Koenig a écrit : Am 08.12.2016 um 21:01 schrieb Mikael Morin: Le 08/12/2016 à 20:26, Thomas Koenig a écrit : Hi Andre, Thomas, your part of the patch looks ok to me, too. I haven't tracked the discussion on whether it is ok to add your part of the patch. Therefor

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-12-08 Thread Thomas Koenig
Am 08.12.2016 um 21:01 schrieb Mikael Morin: Le 08/12/2016 à 20:26, Thomas Koenig a écrit : Hi Andre, Thomas, your part of the patch looks ok to me, too. I haven't tracked the discussion on whether it is ok to add your part of the patch. Therefore I don't have committed your patch. My opinion

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-12-08 Thread Mikael Morin
Le 08/12/2016 à 20:26, Thomas Koenig a écrit : Hi Andre, Thomas, your part of the patch looks ok to me, too. I haven't tracked the discussion on whether it is ok to add your part of the patch. Therefore I don't have committed your patch. My opinion is, that it does do no harm. So it should be a

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-12-08 Thread Thomas Koenig
Hi Andre, Thomas, your part of the patch looks ok to me, too. I haven't tracked the discussion on whether it is ok to add your part of the patch. Therefore I don't have committed your patch. My opinion is, that it does do no harm. So it should be applied. Based on the feedback so far, I will t

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-12-06 Thread Andre Vehreschild
Hi Thomas, hi all, my part of the patch was okayed by Thomas in the PR at comment #12: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78226#c12 Committed as r243300. Thomas, your part of the patch looks ok to me, too. I haven't tracked the discussion on whether it is ok to add your part of the pa

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-11-22 Thread Janus Weil
Hi Thomas, >> the attached patch runs through gfortran's AST to check for missing >> location information. one small comment: Is it necessary to introduce the extra CHECK_LOCUS macro? Couldn't you just use CHECKING_P alone? In your patch CHECK_LOCUS is basically just replicating CHECKING_P. And:

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-11-14 Thread Thomas Koenig
the attached patch runs through gfortran's AST to check for missing location information. ... this time with attachment. 2016-11-14 Thomas Koenig PR fortran/78226 * error.c (gfc_warning_internal): New function. * frontend-passes.c (CHECK_LOCUS): New macro.