Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-29 Thread Ian Lance Taylor
On Tue, Jan 22, 2019 at 1:43 PM Tom de Vries wrote: > > What is an acceptable way to proceed here? I could add a > libbacktrace_nodwarf.la, and have the test-case add a -DFOR_TESTING or > some such when compiling dwarf.c, and add the necessary handling in > dwarf.c conditional on FOR_TESTING. WDYT

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-22 Thread Tom de Vries
On 19-01-19 01:54, Ian Lance Taylor wrote: > On Fri, Jan 18, 2019 at 4:45 PM Tom de Vries wrote: >> >> On 18-01-19 15:23, Ian Lance Taylor wrote: >>> On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: now that the rest of the patch series has been committed, here's an updated vers

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-18 Thread Ian Lance Taylor via gcc-patches
On Fri, Jan 18, 2019 at 4:45 PM Tom de Vries wrote: > > On 18-01-19 15:23, Ian Lance Taylor wrote: > > On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: > >> > >> now that the rest of the patch series has been committed, here's an > >> updated version of this patch that applies to trunk. > > >

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-18 Thread Tom de Vries
On 18-01-19 15:23, Ian Lance Taylor wrote: > On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: >> >> now that the rest of the patch series has been committed, here's an >> updated version of this patch that applies to trunk. > > I would much rather put dwarf_data into internal.h than to #includ

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-18 Thread Ian Lance Taylor via gcc-patches
On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: > > now that the rest of the patch series has been committed, here's an > updated version of this patch that applies to trunk. I would much rather put dwarf_data into internal.h than to #include "dwarf.c" from a different file. Using #include w

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-17 Thread Tom de Vries
Hi, now that the rest of the patch series has been committed, here's an updated version of this patch that applies to trunk. Thanks, - Tom [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case Add test-case that verifies that libbacktrace can find the same debug information with and without dwz