On Fri, Jan 18, 2019 at 4:45 PM Tom de Vries <tdevr...@suse.de> wrote: > > On 18-01-19 15:23, Ian Lance Taylor wrote: > > On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries <tdevr...@suse.de> wrote: > >> > >> now that the rest of the patch series has been committed, here's an > >> updated version of this patch that applies to trunk. > > > > I would much rather put dwarf_data into internal.h than to #include > > "dwarf.c" from a different file. Using #include with a .c file is > > just a bad path to walk down. > > This version avoids the include of dwarf.c. > > Does that look better?
> +printdwarftest_SOURCES = > +printdwarftest_LDADD = libbacktrace.la printdwarftest.lo testlib.lo Seems like you could write printdwarftest_SOURCES = printdwarftest.c testlib.c printdwarftest_LDADD = libbacktrace.la > -static int > +int > dwarf_lookup_pc (struct backtrace_state *state, struct dwarf_data *ddata, Ah, I didn't consider this. We can't do this. It will break code like libsanitizer/libbacktrace/backtrace-rename.h. Is there a way that we could run a similar test looking at the output of readelf --debug? Ian
