Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Jeff Law
On 05/10/14 13:58, Richard Sandiford wrote: The rtx u2 field currently uses a desc/tag pair for GTY. This seems unnecessary though, since the field is specifically supposed to be 32 bits wide on 64-bit hosts and so cannot hold a pointer. Tested on x86_64-linux-gnu. OK to install? Thanks, Rich

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Mike Stump
On May 12, 2014, at 3:53 AM, Richard Sandiford wrote: > Yeah, but the reason I'm removing the desc/tag pair isn't so much to get > rid of that (the compiler should do it for us) but because marking it > anything other than "skip" gives the impression that we want to allow > GC pointers in the uni

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Richard Sandiford
Michael Matz writes: > Hi, > > On Sat, 10 May 2014, Mike Stump wrote: > >> > The rtx u2 field currently uses a desc/tag pair for GTY. This seems >> > unnecessary though, >> >> > OK to install? >> >> Ick. I don’t favor skip. The change feels like a premature >> optimization that doesn’t net a

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Michael Matz
Hi, On Sat, 10 May 2014, Mike Stump wrote: > > The rtx u2 field currently uses a desc/tag pair for GTY. This seems > > unnecessary though, > > > OK to install? > > Ick. I don’t favor skip. The change feels like a premature > optimization that doesn’t net any code gen benefit. I’ll defer to

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-10 Thread Mike Stump
On May 10, 2014, at 12:58 PM, Richard Sandiford wrote: > The rtx u2 field currently uses a desc/tag pair for GTY. This seems > unnecessary though, > OK to install? Ick. I don’t favor skip. The change feels like a premature optimization that doesn’t net any code gen benefit. I’ll defer to a