Re: [PATCH 1/6] RTL & dwarf2out changes

2014-07-28 Thread Cary Coutant
>> In the case of loc_checksum(), we're tied to MD5 by the DWARF >> standard. Otherwise, we could just rewrite it to use inchash >> throughout. > > I'm not sure I understand the motivation. If gcc hashes in > gcc specific stuff (and this hash, even before my changes is) > then the output can never

Re: [PATCH 1/6] RTL & dwarf2out changes

2014-07-28 Thread Andi Kleen
On Mon, Jul 28, 2014 at 11:48:58AM -0700, Cary Coutant wrote: > > + /* ??? MD5 of another hash doesn't make a lot of sense... */ > > + hash = hstate.end(); > >CHECKSUM (hash); > > [citation needed] I don't see why you think that. Maybe it'd be nicer > if we could use hash_loc_operands() to f

Re: [PATCH 1/6] RTL & dwarf2out changes

2014-07-28 Thread Cary Coutant
> + /* ??? MD5 of another hash doesn't make a lot of sense... */ > + hash = hstate.end(); >CHECKSUM (hash); [citation needed] I don't see why you think that. Maybe it'd be nicer if we could use hash_loc_operands() to feed its input directly into the MD5 checksum, but I think in this case it'