> + /* ??? MD5 of another hash doesn't make a lot of sense... */ > + hash = hstate.end(); > CHECKSUM (hash);
[citation needed] I don't see why you think that. Maybe it'd be nicer if we could use hash_loc_operands() to feed its input directly into the MD5 checksum, but I think in this case it's perfectly fine to use the hash instead, in order to avoid reimplementing a rather substantial function that already exists. Maybe we could make hash_loc_operands() a template that can be used as part of either inchash or MD5? In the case of loc_checksum(), we're tied to MD5 by the DWARF standard. Otherwise, we could just rewrite it to use inchash throughout. -cary
