Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-08-19 Thread Andrea Corallo
Segher Boessenkool writes: > [ Please don't post new patch series as replies to old ] > > On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: >> This first patch implements the addition of a new RTX instruction class >> FILLER_INSN, which has been white listed to allow placement of NO

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2020 at 11:13:40AM +0200, Andrea Corallo wrote: > Segher Boessenkool writes: > > So I wonder if this cannot be done with some kind of NOTE, instead? > > I was having a look into reworking this using an insn note as (IIUC) > suggested. The idea is appealing but looking into insn-n

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-08-19 Thread Segher Boessenkool
[ Please don't post new patch series as replies to old ] On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: > This first patch implements the addition of a new RTX instruction class > FILLER_INSN, which has been white listed to allow placement of NOPs > outside of a basic block. This

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-08-19 Thread Richard Sandiford
Andrea Corallo writes: > Segher Boessenkool writes: > >> Hi Andrea, >> >> On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: >>> This first patch implements the addition of a new RTX instruction class >>> FILLER_INSN, which has been white listed to allow placement of NOPs >>> outside

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-08-19 Thread Andrea Corallo
Segher Boessenkool writes: > Hi Andrea, > > On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: >> This first patch implements the addition of a new RTX instruction class >> FILLER_INSN, which has been white listed to allow placement of NOPs >> outside of a basic block. This is to al

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-28 Thread Andrea Corallo
Segher Boessenkool writes: > Hi Andrea, > > On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: >> This first patch implements the addition of a new RTX instruction class >> FILLER_INSN, which has been white listed to allow placement of NOPs >> outside of a basic block. This is to al

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-26 Thread Eric Botcazou
> As you see, I really do not like to have another RTX class, without very > well defined semantics even. Not without first being shown no > alternatives are acceptable, anyway :-) Seconded. -- Eric Botcazou

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-24 Thread Segher Boessenkool
Hi Andrea, On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: > This first patch implements the addition of a new RTX instruction class > FILLER_INSN, which has been white listed to allow placement of NOPs > outside of a basic block. This is to allow padding after unconditional > bra

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-22 Thread Joseph Myers
New insn types should be documented in rtl.texi (I think in the "Insns" section). -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-22 Thread Andrea Corallo
Richard Biener writes: > I wonder if such effect of instructions on the pipeline can be modeled > in the DFA and thus whether the scheduler could issue (always ready) > NOPs? I might be wrong but the DFA model should be reasoning in terms of executed instructions given an execution path, on the

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-22 Thread Richard Earnshaw (lists)
On 22/07/2020 13:24, Richard Biener via Gcc-patches wrote: > On Wed, Jul 22, 2020 at 12:03 PM Andrea Corallo > wrote: >> >> Hi all, >> >> I'd like to submit the following two patches implementing a new AArch64 >> specific back-end pass that helps optimize branch-dense code, which can >> be a bott

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-22 Thread Richard Biener via Gcc-patches
On Wed, Jul 22, 2020 at 12:03 PM Andrea Corallo wrote: > > Hi all, > > I'd like to submit the following two patches implementing a new AArch64 > specific back-end pass that helps optimize branch-dense code, which can > be a bottleneck for performance on some Arm cores. This is achieved by > paddi