Re: [PATCH] x86: Optimize VFIXUPIMM* patterns with multiple-alternative constraints

2018-11-09 Thread Terry Guo
On Fri, Nov 9, 2018 at 6:05 PM Uros Bizjak wrote: > > On Fri, Nov 9, 2018 at 10:54 AM Wei Xiao wrote: > > > > Hi Uros > > > > Thanks for the remarks! > > I improve the patch as attached to address the issues you mentioned: > > 1. No changes to substs any more. > > 2. Adopt established approach (e

Re: [PATCH] x86: Optimize VFIXUPIMM* patterns with multiple-alternative constraints

2018-11-09 Thread Uros Bizjak
On Fri, Nov 9, 2018 at 10:54 AM Wei Xiao wrote: > > Hi Uros > > Thanks for the remarks! > I improve the patch as attached to address the issues you mentioned: > 1. No changes to substs any more. > 2. Adopt established approach (e.g "rcp14") to > handle zero masks. > > I'd like to explain our motiv

Re: [PATCH] x86: Optimize VFIXUPIMM* patterns with multiple-alternative constraints

2018-11-09 Thread Wei Xiao
Hi Uros Thanks for the remarks! I improve the patch as attached to address the issues you mentioned: 1. No changes to substs any more. 2. Adopt established approach (e.g "rcp14") to handle zero masks. I'd like to explain our motivation of combining vfixupimm patterns: there will be a lot of new x

Re: [PATCH] x86: Optimize VFIXUPIMM* patterns with multiple-alternative constraints

2018-11-06 Thread Uros Bizjak
On Tue, Nov 6, 2018 at 11:16 AM Wei Xiao wrote: > > Hi maintainers, > > The attached patch intends to optimize VFIXUPIMM* patterns with > multiple-alternative constraints and > 4 patterns are combined into 2 patterns. Tested with bootstrap and > regression tests on x86_64. No regressions. > > Is i