On Tue, Nov 6, 2018 at 11:16 AM Wei Xiao <wei.william.x...@gmail.com> wrote: > > Hi maintainers, > > The attached patch intends to optimize VFIXUPIMM* patterns with > multiple-alternative constraints and > 4 patterns are combined into 2 patterns. Tested with bootstrap and > regression tests on x86_64. No regressions. > > Is it OK for trunk?
I'm not convinced that this particular optimization is a good idea. Looking at the patch, you have to add a whole bunch of substs just to merge two pattern sets. Also, the approach diverges from established approach of handling zero masks. The later raises maintenance costs for no compelling reason. I'd say to leave these patterns the way they are. Uros.
