Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-20 Thread Chen Gang
On 08/21/2014 02:06 AM, Joseph S. Myers wrote: > On Sun, 17 Aug 2014, Chen Gang wrote: > >> 2014-08-17 Chen Gang >> >> * c/c-aux-info.c (gen_type): Resize 'buff' from 10 to 23 bytes. > > This patch is OK, subject to testing, though the ChangeLog entry needs to > reflect the change to usi

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-20 Thread Joseph S. Myers
On Sun, 17 Aug 2014, Chen Gang wrote: > 2014-08-17 Chen Gang > > * c/c-aux-info.c (gen_type): Resize 'buff' from 10 to 23 bytes. This patch is OK, subject to testing, though the ChangeLog entry needs to reflect the change to using HOST_WIDE_INT without truncation to int. -- Joseph S.

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-19 Thread Chen Gang
Excuse me, I did not finish in time. At present, I shall be mainly focus on testsuite. Before I finish it, I can do nothing (I should do nothing) for this patch. Originally: - I get a PC (not buy), it is low quality which cause reboot after run several hours with full cpu used, I wasted much

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-17 Thread Chen Gang
And sorry, I did not finish "make check" at the time point. I wasted my time resources (of my free time) on constructing PC environments and my x86_64 laptop environments. - x86_64 laptop under ubuntu: try to update 'libc6' package to install 'autogen'. At last, I succeed: overwrite libc6 pac

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Chen Gang
On 8/12/14 7:38, Mike Stump wrote: > On Aug 11, 2014, at 2:27 PM, Chen Gang wrote: >> Welcome additional disccusions or completions, and if no any additional >> reply within 1 week, I shall send patch v2 for it (still use sprintf). > > So, my take is it is easier for a maintainer to re-review i

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 2:27 PM, Chen Gang wrote: > Welcome additional disccusions or completions, and if no any additional > reply within 1 week, I shall send patch v2 for it (still use sprintf). So, my take is it is easier for a maintainer to re-review if you do it without additional delay. I’d r

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Chen Gang
On 08/12/2014 04:25 AM, Joseph S. Myers wrote: > On Sun, 10 Aug 2014, Chen Gang wrote: > >> For "[%d]" in sprintf(), theoretically, the maximize size is 14 -- for >> 0x8000, it is sizeof("[-2147483648]"). Normally, it may not cause >> real world bug, but if another issues occur, it may lead th

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Joseph S. Myers
On Sun, 10 Aug 2014, Chen Gang wrote: > For "[%d]" in sprintf(), theoretically, the maximize size is 14 -- for > 0x8000, it is sizeof("[-2147483648]"). Normally, it may not cause > real world bug, but if another issues occur, it may lead things worse. Negative values certainly don't make sens