Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]

2024-02-09 Thread Jason Merrill
On 2/2/24 10:45, Alex Coplan wrote: On 02/02/2024 09:34, Marek Polacek wrote: On Fri, Feb 02, 2024 at 10:27:23AM +, Alex Coplan wrote: Bootstrapped/regtested on x86_64-apple-darwin, OK for trunk? Thanks, Alex -- >8 -- When __has_feature was introduced for GCC 14, I included the feature c

Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]

2024-02-02 Thread Marek Polacek
On Fri, Feb 02, 2024 at 05:32:31PM +0100, Jakub Jelinek wrote: > On Fri, Feb 02, 2024 at 11:27:09AM -0500, Marek Polacek wrote: > > > With -pedantic-errors we would have __has_extension behaving like > > > __has_feature, and I wanted to check in the test that this doesn't get > > > reported as a fe

Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]

2024-02-02 Thread Jakub Jelinek
On Fri, Feb 02, 2024 at 11:27:09AM -0500, Marek Polacek wrote: > > With -pedantic-errors we would have __has_extension behaving like > > __has_feature, and I wanted to check in the test that this doesn't get > > reported as a feature or extension. > > Oh I see. A comment to that effect might be

Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]

2024-02-02 Thread Marek Polacek
On Fri, Feb 02, 2024 at 03:45:48PM +, Alex Coplan wrote: > On 02/02/2024 09:34, Marek Polacek wrote: > > On Fri, Feb 02, 2024 at 10:27:23AM +, Alex Coplan wrote: > > > Bootstrapped/regtested on x86_64-apple-darwin, OK for trunk? > > > > > > Thanks, > > > Alex > > > > > > -- >8 -- > > > >

Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]

2024-02-02 Thread Alex Coplan
On 02/02/2024 09:34, Marek Polacek wrote: > On Fri, Feb 02, 2024 at 10:27:23AM +, Alex Coplan wrote: > > Bootstrapped/regtested on x86_64-apple-darwin, OK for trunk? > > > > Thanks, > > Alex > > > > -- >8 -- > > > > When __has_feature was introduced for GCC 14, I included the feature > > cxx

Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]

2024-02-02 Thread Marek Polacek
On Fri, Feb 02, 2024 at 10:27:23AM +, Alex Coplan wrote: > Bootstrapped/regtested on x86_64-apple-darwin, OK for trunk? > > Thanks, > Alex > > -- >8 -- > > When __has_feature was introduced for GCC 14, I included the feature > cxx_constexpr_string_builtins, since of the relevant string built