Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Tobias Grosser
On 07/02/2015 09:09 PM, Sebastian Pop wrote: On Thu, Jul 2, 2015 at 2:03 PM, Ramana Radhakrishnan wrote: How about a testcase or 2 or mentioning if it is covered by existing testcases ? The patch fixes a test in testsuite/gcc.dg/graphite/ when removing the use of limit_scops(). Maybe the comm

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Sebastian Pop
On Thu, Jul 2, 2015 at 2:03 PM, Ramana Radhakrishnan wrote: > How about a testcase or 2 or mentioning if it is covered by existing > testcases ? The patch fixes a test in testsuite/gcc.dg/graphite/ when removing the use of limit_scops(). Maybe the commit message could contain the name of the test

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Tobias Grosser
On 07/02/2015 09:03 PM, Sebastian Pop wrote: On Thu, Jul 2, 2015 at 1:44 PM, Tobias Grosser wrote: If you git log grep for this commit, you would see that this patch reverts this "typo" introduced in a very large patch. Sure. The corresponding change was: - gimple_stmt_iterator psi =

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Sebastian Pop
On Thu, Jul 2, 2015 at 1:44 PM, Tobias Grosser wrote: >> If you git log grep for this commit, you would see that this patch >> reverts this "typo" introduced in a very large patch. > > > Sure. The corresponding change was: > > - gimple_stmt_iterator psi = gsi_for_stmt (use_stmt); > + g

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Ramana Radhakrishnan
On Thu, Jul 2, 2015 at 7:34 PM, Sebastian Pop wrote: > On Thu, Jul 2, 2015 at 1:17 PM, Tobias Grosser wrote: >> On 07/02/2015 06:52 PM, Aditya Kumar wrote: >>> >>> gcc/ChangeLog: >>> >>> 2015-07-02 Aditya Kumar >>> Sebastian Pop >>> >>> * graphite-sese-to-poly.c (rewrite

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Tobias Grosser
On 07/02/2015 08:34 PM, Sebastian Pop wrote: On Thu, Jul 2, 2015 at 1:17 PM, Tobias Grosser wrote: On 07/02/2015 06:52 PM, Aditya Kumar wrote: gcc/ChangeLog: 2015-07-02 Aditya Kumar Sebastian Pop * graphite-sese-to-poly.c (rewrite_cross_bb_scalar_deps):

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Sebastian Pop
On Thu, Jul 2, 2015 at 1:17 PM, Tobias Grosser wrote: > On 07/02/2015 06:52 PM, Aditya Kumar wrote: >> >> gcc/ChangeLog: >> >> 2015-07-02 Aditya Kumar >> Sebastian Pop >> >> * graphite-sese-to-poly.c (rewrite_cross_bb_scalar_deps): >> Point iterator to use_stmt. >

Re: [PATCH] Restore previous change for gimple_phi_iterator

2015-07-02 Thread Tobias Grosser
On 07/02/2015 06:52 PM, Aditya Kumar wrote: gcc/ChangeLog: 2015-07-02 Aditya Kumar Sebastian Pop * graphite-sese-to-poly.c (rewrite_cross_bb_scalar_deps): Point iterator to use_stmt. Hi Aditya, this patch does not explain what was wrong and why this change