Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

2019-08-05 Thread Kito Cheng
Hi Jim. Andreas: Thanks your review :) Committed with English improvements and ChangeLog update as r274137 On Tue, Aug 6, 2019 at 5:48 AM Jim Wilson wrote: > > On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng wrote: > > gcc/ChangeLog > > * gcc/config/riscv/multilib-generator: Handle extension

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

2019-08-05 Thread Jim Wilson
On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng wrote: > gcc/ChangeLog > * gcc/config/riscv/multilib-generator: Handle extensions > combination correctly. A ChangeLog entry should generally describe what a patch changes, not what it does. So this should mention a new variable canonical

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

2019-08-05 Thread Andreas Schwab
On Aug 05 2019, Kito Cheng wrote: > + # TODO: Support implied extensions, e.g. D implied F in latest spce. spec > + # TODO: Support extesnion version. extension > + # Filter out any non exist index. non-existent Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint