On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng <kito.ch...@sifive.com> wrote:
> gcc/ChangeLog
> * gcc/config/riscv/multilib-generator: Handle extensions
> combination correctly.
A ChangeLog entry should generally describe what a patch changes, not
what it does. So this should mention a new variable canonical_order,
a new function arch_canonicalize, and the call to pass alts through
it.
> + raise Exception("Unexpect arch: `%d`" % arch[:5])
Unexpect -> Unexpected
> + long_ext_prefixs = ['z', 's', 'h', 'x']
prefixs -> prefixes
> + # Concat rest multi-char extensions.
rest multi-char -> rest of the multi-char
This looks good to me with the minor English improvements Andreas and
I suggested.
Jim
