Re: [PATCH] Import liboffloadmic from upstream

2015-09-08 Thread Jakub Jelinek
On Tue, Sep 08, 2015 at 04:40:22PM +0300, Ilya Verbin wrote: > Looks like this is the only incompatible change. Given that the library is > used > only by libgomp plugin, this isn't a big problem. I will add a comment into > plugin prohibiting the use of the return value. In fact, if something

Re: [PATCH] Import liboffloadmic from upstream

2015-09-08 Thread Ilya Verbin
On Mon, Aug 31, 2015 at 20:07:49 +0200, Jakub Jelinek wrote: > On Mon, Aug 31, 2015 at 08:56:58PM +0300, Ilya Verbin wrote: > > On Mon, Aug 31, 2015 at 16:49:53 +0200, Jakub Jelinek wrote: > > > 1) Is the library backwards ABI compatible? Can you run e.g. > > >libabigail abidiff in between the

Re: [PATCH] Import liboffloadmic from upstream

2015-09-02 Thread Dodji Seketeli
Ilya Verbin writes: > On Tue, Sep 01, 2015 at 09:58:22 +0200, Dodji Seketeli wrote: >> Woops. can you send me the exact two libraries so that I can see what's >> going wrong? You can quickly file an issue to >> https://sourceware.org/bugzilla/enter_bug.cgi?product=libabigail or just >> send me

Re: [PATCH] Import liboffloadmic from upstream

2015-09-01 Thread Ilya Verbin
On Tue, Sep 01, 2015 at 09:58:22 +0200, Dodji Seketeli wrote: > Woops. can you send me the exact two libraries so that I can see what's > going wrong? You can quickly file an issue to > https://sourceware.org/bugzilla/enter_bug.cgi?product=libabigail or just > send me the two binaries by email. I

Re: [PATCH] Import liboffloadmic from upstream

2015-09-01 Thread Dodji Seketeli
Ilya Verbin writes: (...) > abidiff: ../../src/abg-comparison.cc:10731: virtual void > abigail::comparison::fn_parm_diff::report(std::ostream&, const string&) > const: Assertion `get_type_diff() && get_type_diff()->to_be_reported()' > failed. > Aborted (core dumped) Woops. can you send me t

Re: [PATCH] Import liboffloadmic from upstream

2015-08-31 Thread Jakub Jelinek
On Mon, Aug 31, 2015 at 08:56:58PM +0300, Ilya Verbin wrote: > abidiff: ../../src/abg-comparison.cc:10731: virtual void > abigail::comparison::fn_parm_diff::report(std::ostream&, const string&) > const: Assertion `get_type_diff() && get_type_diff()->to_be_reported()' > failed. > Aborted (core du

Re: [PATCH] Import liboffloadmic from upstream

2015-08-31 Thread Jakub Jelinek
On Mon, Aug 31, 2015 at 08:56:58PM +0300, Ilya Verbin wrote: > On Mon, Aug 31, 2015 at 16:49:53 +0200, Jakub Jelinek wrote: > > 1) Is the library backwards ABI compatible? Can you run e.g. > >libabigail abidiff in between the unpatched and patched version? > > It should be in theory, and I've

Re: [PATCH] Import liboffloadmic from upstream

2015-08-31 Thread Ilya Verbin
On Mon, Aug 31, 2015 at 16:49:53 +0200, Jakub Jelinek wrote: > 1) Is the library backwards ABI compatible? Can you run e.g. >libabigail abidiff in between the unpatched and patched version? It should be in theory, and I've successfully tested an old binary with old libgomp plugin and with new

Re: [PATCH] Import liboffloadmic from upstream

2015-08-31 Thread Jakub Jelinek
On Mon, Aug 31, 2015 at 04:23:49PM +0300, Ilya Verbin wrote: > Hi! > > This patch contains an update for liboffloadmic, imported from > , version 20150803. > > Two major new features are: > 1. Unloading of loaded images from target device. > 2. Callback support for