On Tue, Sep 08, 2015 at 04:40:22PM +0300, Ilya Verbin wrote:
> Looks like this is the only incompatible change. Given that the library is
> used
> only by libgomp plugin, this isn't a big problem. I will add a comment into
> plugin prohibiting the use of the return value. In fact, if something goes
> wrong in __offload_register_image, it calls exit ().
Ack.
> > > > 2) the *.map changes look wrong, when adding symbols to a symbol
> > > > versioned
> > > > shared library, new symbols shouldn't be added to existing symbol
> > > > version, but to a new symbol version (so e.g. MYO_1.0.1 (or MYO_1.1)
> > > > and COI_1.0.1 (or COI_1.1))
> > >
> > > I agree, but this is what I can't change - these files are copied from
> > > real COI/
> > > MYO libraries, therefore the emulator (fake COI/MYO libs) must have the
> > > same
> > > versions as the real libs.
> >
> > If that change is already cast into stone, there is nothing we can do, but
> > can you talk to the library maintainers that they add new symbols to
> > different symbol version next time at least?
>
> Yes, I have told them.
>
> So, is it OK for trunk?
Ok.
Jakub
