On 08/10/2013 12:40 PM, Andi Kleen wrote:
> On Fri, Nov 09, 2012 at 07:08:07AM -0800, Richard Henderson wrote:
>> On 2012-11-09 07:03, Andi Kleen wrote:
>>> PR55139
>>> * c-common.c (get_atomic_generic_size): Mask with
>>> MEMMODEL_MASK
>>
>> Ok.
>
> I would like to backport this p
On Fri, Nov 09, 2012 at 07:08:07AM -0800, Richard Henderson wrote:
> On 2012-11-09 07:03, Andi Kleen wrote:
> > PR55139
> > * c-common.c (get_atomic_generic_size): Mask with
> > MEMMODEL_MASK
>
> Ok.
I would like to backport this patch to 4.8. Ok?
-Andi
--
a...@linux.intel.com
Richard Henderson writes:
> On 2012-11-09 07:18, Jakub Jelinek wrote:
>> I think it actually should be removed, given that e.g.
>> int i, j;
>> void
>> foo (void)
>> {
>> __atomic_store (&i, &j, 12);
>> }
>> warns twice for the same thing, when it should only warn once.
>> Richard?
>
> Makes se
On 2012-11-09 07:18, Jakub Jelinek wrote:
> I think it actually should be removed, given that e.g.
> int i, j;
> void
> foo (void)
> {
> __atomic_store (&i, &j, 12);
> }
> warns twice for the same thing, when it should only warn once.
> Richard?
Makes sense.
r~
Hi!
Just nits.
On Fri, Nov 09, 2012 at 04:03:47PM +0100, Andi Kleen wrote:
> From: Andi Kleen
>
> get_atomic_generic_size would error out for
> __atomic_store(...,__ATOMIC_HLE_RELEASE)
>
> Just mask it out. All the memory orders are checked completely
> in builtins.c anyways.
>
> I'm not sure
On 2012-11-09 07:03, Andi Kleen wrote:
> PR55139
> * c-common.c (get_atomic_generic_size): Mask with
> MEMMODEL_MASK
Ok.
r~
