Re: [PATCH] Fix memory leaks in sbitmap.c selftests

2018-01-23 Thread Richard Biener
On Mon, Jan 22, 2018 at 8:51 PM, David Malcolm wrote: > "make selftest-valgrind" shows a few leaks in sbitmap.c's selftests; > this patch fixes them. > > Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. > OK for trunk? Ok. > gcc/ChangeLog: > * sbitmap.c (selftest::test_set_range

Re: [PATCH] Fix memory leaks in libstdc++ ABI tests

2017-07-10 Thread Jonathan Wakely
On 10/07/17 14:32 -0400, David Edelsohn wrote: The memory leak cleanup has introduced a testsuite failure on AIX: /nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/abi/pr42230.cc: In function 'int main()': /nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/abi/pr42230.cc:15: error: 'free' is not a

Re: [PATCH] Fix memory leaks in libstdc++ ABI tests

2017-07-10 Thread David Edelsohn
The memory leak cleanup has introduced a testsuite failure on AIX: /nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/abi/pr42230.cc: In function 'int main()': /nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/abi/pr42230.cc:15: error: 'free' is not a member of 'std' compiler exited with status 1

Re: [PATCH] Fix memory leaks in IPA CP (PR ipa/79337).

2017-02-02 Thread Jeff Law
On 02/02/2017 09:37 AM, Martin Liška wrote: On 02/02/2017 05:13 PM, Martin Jambor wrote: Hi, On Thu, Feb 02, 2017 at 01:53:35PM +0100, Martin Liska wrote: Hello. As mentioned in the PR, there is memory leak that is caused by fact, that ipa_node_params_t does release memory just in ipa_node_p

Re: [PATCH] Fix memory leaks in gimple-ssa-sprintf.c (PR tree-optimization/79339).

2017-02-02 Thread Jeff Law
On 02/02/2017 07:30 AM, Martin Liška wrote: Hi. As mentioned in the PR, mpfr_clear should be called in order to release memory. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin 0001-Fix-memory-leaks-in-gimple-ssa-sprintf.c-PR-tree-opt.pa

Re: [PATCH] Fix memory leaks in IPA CP (PR ipa/79337).

2017-02-02 Thread Martin Liška
On 02/02/2017 05:13 PM, Martin Jambor wrote: > Hi, > > On Thu, Feb 02, 2017 at 01:53:35PM +0100, Martin Liska wrote: >> Hello. >> >> As mentioned in the PR, there is memory leak that is caused by fact, that >> ipa_node_params_t >> does release memory just in ipa_node_params_t::remove. That's wron

Re: [PATCH] Fix memory leaks in IPA CP (PR ipa/79337).

2017-02-02 Thread Martin Jambor
Hi, On Thu, Feb 02, 2017 at 01:53:35PM +0100, Martin Liska wrote: > Hello. > > As mentioned in the PR, there is memory leak that is caused by fact, that > ipa_node_params_t > does release memory just in ipa_node_params_t::remove. That's wrong because > the callback is called > just when cgraph_

Re: [PATCH] Fix memory leaks in tree-vect-data-refs.c

2015-12-09 Thread Richard Biener
On Wed, Dec 9, 2015 at 12:14 PM, Martin Liška wrote: > Hi. > > This is simple follow-up of the previous patch that fixes last remaining > leak in vectorizer. > > Patch can regbootstrap on x64_64-linux-gnu. > > Ready for trunk? Ok. Richard. > Martin

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-26 Thread Bernd Schmidt
On 11/26/2015 09:53 PM, Martin Liška wrote: Is the patch still candidate to be merged in current stage3, or should I leave it to the next stage1? What about the first patch or the patch, where I just applied replacement of whitespaces? As I said previously, the one to just replace whitespace is

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-26 Thread Martin Liška
On 11/20/2015 12:15 PM, Martin Liška wrote: On 11/20/2015 03:14 AM, Bernd Schmidt wrote: BTW, I'm with whoever said absolutely no way to the idea of making automatic changes like this as part of a commit hook. I think the whitespace change can go in if it hasn't already, but I think the other

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-20 Thread Martin Liška
On 11/20/2015 03:14 AM, Bernd Schmidt wrote: > BTW, I'm with whoever said absolutely no way to the idea of making automatic > changes like this as part of a commit hook. > > I think the whitespace change can go in if it hasn't already, but I think the > other one still has enough problems that I

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Bernd Schmidt
BTW, I'm with whoever said absolutely no way to the idea of making automatic changes like this as part of a commit hook. I think the whitespace change can go in if it hasn't already, but I think the other one still has enough problems that I'll say - leave it for the next stage 1. @@ -178,8

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Jeff Law
On 11/19/2015 06:58 AM, Bernd Schmidt wrote: On 11/19/2015 11:16 AM, Martin Liška wrote: You are right, however as the original coding style was really broken, it was much easier to use the tool and clean-up fall-out. Waiting for thoughts related to v2. Better, but still some oddities. I hope

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Martin Liška
On 11/19/2015 02:58 PM, Bernd Schmidt wrote: > On 11/19/2015 11:16 AM, Martin Liška wrote: >> You are right, however as the original coding style was really broken, >> it was much easier >> to use the tool and clean-up fall-out. >> >> Waiting for thoughts related to v2. > > Better, but still some

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Bernd Schmidt
On 11/19/2015 11:16 AM, Martin Liška wrote: You are right, however as the original coding style was really broken, it was much easier to use the tool and clean-up fall-out. Waiting for thoughts related to v2. Better, but still some oddities. I hope you won't get mad at me if I suggest doing t

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Martin Liška
On 11/19/2015 01:50 AM, Joseph Myers wrote: I don't think all the reformattings here are things we want to do globally for most source files. E.g. @@ -75,18 +74,17 @@ get_mask_first_set_bit (unsigned mask) static bool has_undefined_value_p (tree t) { - return (ssa_undefined_value_p (t)

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Bernd Schmidt
On 11/19/2015 01:50 AM, Joseph Myers wrote: I don't think all the reformattings here are things we want to do globally for most source files. While I do appreciate the sentiment behind the patch, I agree with all of Joseph's points. Especially the clearly incorrect changes should be reverted

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Joseph Myers
I don't think all the reformattings here are things we want to do globally for most source files. E.g. > @@ -75,18 +74,17 @@ get_mask_first_set_bit (unsigned mask) > static bool > has_undefined_value_p (tree t) > { > - return (ssa_undefined_value_p (t) > - || (possibly_undefined_nam

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Jeff Law
On 11/18/2015 07:23 AM, Martin Liška wrote: On 11/13/2015 08:19 PM, Jeff Law wrote: On 11/13/2015 09:58 AM, Martin Liška wrote: On 11/13/2015 05:32 PM, Jeff Law wrote: On 11/13/2015 05:50 AM, Martin Liška wrote: Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Martin Liška
On 11/13/2015 08:19 PM, Jeff Law wrote: > On 11/13/2015 09:58 AM, Martin Liška wrote: >> On 11/13/2015 05:32 PM, Jeff Law wrote: >>> On 11/13/2015 05:50 AM, Martin Liška wrote: Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks, Martin

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Jeff Law
On 11/13/2015 09:58 AM, Martin Liška wrote: On 11/13/2015 05:32 PM, Jeff Law wrote: On 11/13/2015 05:50 AM, Martin Liška wrote: Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks, Martin 0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch From 54851503251dee7a8

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Martin Liška
On 11/13/2015 05:32 PM, Jeff Law wrote: > On 11/13/2015 05:50 AM, Martin Liška wrote: >> Hello. >> >> Patch survives regbootstrap on x86_64-linux-gnu. >> Ready for trunk? >> >> Thanks, >> Martin >> >> >> 0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch >> >> >> From 54851503251dee7a8bd074485db2627

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Jeff Law
On 11/13/2015 05:50 AM, Martin Liška wrote: Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks, Martin 0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 13 Nov 2015 12

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Martin Liška
Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks, Martin >From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 13 Nov 2015 12:23:22 +0100 Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c gcc/ChangeLog: 2015-11-13 M

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 2:26 PM, Martin Liška wrote: > On 11/09/2015 01:11 PM, Richard Biener wrote: >> On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: >>> Hi. >>> >>> This is follow-up of changes that Richi started on Friday. >>> >>> Patch can bootstrap on x86_64-linux-pc and regression test

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Martin Liška
On 11/09/2015 01:11 PM, Richard Biener wrote: > On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: >> Hi. >> >> This is follow-up of changes that Richi started on Friday. >> >> Patch can bootstrap on x86_64-linux-pc and regression tests are running. >> >> Ready for trunk? > > * tree-ssa

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Trevor Saunders
On Mon, Nov 09, 2015 at 01:11:48PM +0100, Richard Biener wrote: > On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: > > Hi. > > > > This is follow-up of changes that Richi started on Friday. > > > > Patch can bootstrap on x86_64-linux-pc and regression tests are running. > > > > Ready for trunk

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: > Hi. > > This is follow-up of changes that Richi started on Friday. > > Patch can bootstrap on x86_64-linux-pc and regression tests are running. > > Ready for trunk? * tree-ssa-dom.c (free_edge_info): Make the function extern. ...

Re: [PATCH] Fix memory leaks

2015-11-06 Thread Richard Biener
On Fri, 6 Nov 2015, Richard Biener wrote: > > A few, spotted with valgrind. One is even mine ;) > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. And this is what I committed (one extra leak in postreload-gcse). Richard. 2015-11-06 Richard Biener * tree-ssa-sccvn.c (

Re: [PATCH] Fix memory leaks in ldist_gen (PR middle-end/56461)

2013-03-04 Thread Richard Biener
On Fri, 1 Mar 2013, Jakub Jelinek wrote: > Hi! > > When merging partitions together, we remove them from partitions vector, > thus don't free them at all. Fixed thusly, bootstrapped/regtested on > x86_64-linux and i686-linux, ok for trunk? Ok. Thanks, Richard. > 2013-03-01 Jakub Jelinek >

Re: [PATCH] Fix memory leaks in incpath.c

2013-02-26 Thread Joseph S. Myers
On Tue, 26 Feb 2013, Jakub Jelinek wrote: > Hi! > > Another file with memory leaks. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2013-02-26 Jakub Jelinek > > * incpath.c (add_standard_paths): Use reconcat instead of concat > where appropriate and

Re: [PATCH] Fix memory leaks in options handling

2013-02-26 Thread Joseph S. Myers
On Tue, 26 Feb 2013, Jakub Jelinek wrote: > The following patch attempts to fix that by allocating strings which we want > to keep allocated forever, and from time to time lose all the pointers > pointing to them, in an obstack. That could in theory make the allocations > tiny bit faster, but mor