On 11/18/2015 07:23 AM, Martin Liška wrote:
On 11/13/2015 08:19 PM, Jeff Law wrote:
On 11/13/2015 09:58 AM, Martin Liška wrote:
On 11/13/2015 05:32 PM, Jeff Law wrote:
On 11/13/2015 05:50 AM, Martin Liška wrote:
Hello.
Patch survives regbootstrap on x86_64-linux-gnu.
Ready for trunk?
Thanks,
Martin
0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch
From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001
From: marxin<mli...@suse.cz>
Date: Fri, 13 Nov 2015 12:23:22 +0100
Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c
gcc/ChangeLog:
2015-11-13 Martin Liska<mli...@suse.cz>
* tree-ssa-uninit.c (convert_control_dep_chain_into_preds):
Fix GNU coding style.
(find_def_preds): Use auto_vec.
(destroy_predicate_vecs): Change signature of the function.
(prune_uninit_phi_opnds_in_unrealizable_paths): Use the
new signature.
(simplify_preds_4): Use destroy_predicate_vecs instread of
just releasing preds vector.
(normalize_preds): Likewise.
(is_use_properly_guarded): Use new signature of
destroy_predicate_vecs.
(find_uninit_use): Likewise.
OK.
FWIW, there's all kinds of spaces vs tabs issues in this file. I'm curious why
you chose to fix convert_control_dep_chain_into_preds, but didn't change any
others.
Hi Jeff.
Thanks for confirmation, you are right, it's full of coding style issues. I can
change these if it would be desired?
It's probably a good thing to do. Given it'd strictly be formatting, I'd even
consider it post-stage1.
jeff
Hello.
I'm sending the re-formatted source file.
The source file was formatted by clang-format ([1]) and some hunk were manually
re-formatted.
No change in behavior.
Patch can regbootstrap on x86_64-linux-gnu.
Ready for trunk?
OK.
jeff
