Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-06 Thread Li Jia He
On 2019/5/6 7:19 PM, Christophe Lyon wrote: On Sun, 5 May 2019 at 08:31, Li Jia He wrote: Hi, GCC revision 267634 implemented two_value_replacement function. However, a typo occurred during the parameter check, which caused us to miss some optimizations. The intent of the code might be to

Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-06 Thread Li Jia He
On 2019/5/6 8:27 PM, Jakub Jelinek wrote: On Mon, May 06, 2019 at 08:22:41PM +0800, Li Jia He wrote: Dunno why this changed, if you want it in phiopt1, you need "phiopt1" in scan-tree-dump-not as well, if you want optimized dump, you need -fdump-tree-optimized instead. When I test the code a

Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-06 Thread Jakub Jelinek
On Mon, May 06, 2019 at 08:22:41PM +0800, Li Jia He wrote: > > Dunno why this changed, if you want it in phiopt1, you need "phiopt1" > > in scan-tree-dump-not as well, if you want optimized dump, you need > > -fdump-tree-optimized instead. > When I test the code again for submiting the code, I foun

Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-06 Thread Li Jia He
On 2019/5/6 7:35 PM, Jakub Jelinek wrote: On Mon, May 06, 2019 at 01:19:15PM +0200, Christophe Lyon wrote: The regression testing for the patch was done on GCC mainline on powerpc64le-unknown-linux-gnu (Power 9 LE) with no regressions. Is it OK for trunk and backport to gcc 9 ? Whil

Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-06 Thread Jakub Jelinek
On Mon, May 06, 2019 at 01:19:15PM +0200, Christophe Lyon wrote: > > The regression testing for the patch was done on GCC mainline on > > > > powerpc64le-unknown-linux-gnu (Power 9 LE) > > > > with no regressions. Is it OK for trunk and backport to gcc 9 ? While the posted patch had: > > +/*

Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-06 Thread Christophe Lyon
On Sun, 5 May 2019 at 08:31, Li Jia He wrote: > > Hi, > > GCC revision 267634 implemented two_value_replacement function. > However, a typo occurred during the parameter check, which caused > us to miss some optimizations. > > The intent of the code might be to check that the input parameters > ar

Re: [PATCH] Fix a typo in two_value_replacement function

2019-05-05 Thread Jakub Jelinek
On Sun, May 05, 2019 at 01:31:12AM -0500, Li Jia He wrote: > GCC revision 267634 implemented two_value_replacement function. > However, a typo occurred during the parameter check, which caused > us to miss some optimizations. Thanks for catching this. > The regression testing for the patch was do