Re: [PATCH] Fix PR56434

2013-03-22 Thread Richard Biener
On Fri, 22 Mar 2013, Ian Lance Taylor wrote: > On Fri, Mar 22, 2013 at 3:27 AM, Richard Biener wrote: > > > > I think the wrong-code fix is orthogonal to code improvements > > which will also trigger on the GIMPLE level (and where they > > will have a bigger impact). > > I agree. I think the pa

Re: [PATCH] Fix PR56434

2013-03-22 Thread Ian Lance Taylor
On Fri, Mar 22, 2013 at 3:27 AM, Richard Biener wrote: > > I think the wrong-code fix is orthogonal to code improvements > which will also trigger on the GIMPLE level (and where they > will have a bigger impact). I agree. I think the patch to calls is fine unless Jakub objects. > We can for ex

Re: [PATCH] Fix PR56434

2013-03-22 Thread Richard Biener
On Fri, 22 Mar 2013, Jakub Jelinek wrote: > On Fri, Mar 22, 2013 at 11:06:53AM +0100, Richard Biener wrote: > > This fixes PR56434 - the use of BIGGEST_ALIGNMENT to annotate > > the pointer returned by malloc is wrong - BIGGEST_ALIGNMENT > > has nothing to do with the alignment guaranteed by the A

Re: [PATCH] Fix PR56434

2013-03-22 Thread Jakub Jelinek
On Fri, Mar 22, 2013 at 11:06:53AM +0100, Richard Biener wrote: > This fixes PR56434 - the use of BIGGEST_ALIGNMENT to annotate > the pointer returned by malloc is wrong - BIGGEST_ALIGNMENT > has nothing to do with the alignment guaranteed by the ABI > for allocated memory. For example on x86_64 i