Re: [PATCH][buildrobot] libcpp/lex.c: Use enum properly

2013-10-25 Thread Tom Tromey
> "Andrew" == Andrew Pinski writes: >> enum raw_str_phase phase = RAW_STR_PREFIX; Andrew> This is a good work around but please add a comment of why this is Andrew> needed (to work around a bug in XLC++). I agree. It's ok with this update. thanks, Tom

Re: [PATCH][buildrobot] libcpp/lex.c: Use enum properly

2013-10-24 Thread Mike Stump
On Oct 24, 2013, at 6:25 PM, Andrew Pinski wrote: >> enum raw_str_phase phase = RAW_STR_PREFIX; > > This is a good work around but please add a comment of why this is > needed (to work around a bug in XLC++). Oh, curious, I was assuming that file was compiled by the C compiler… not as obvious

Re: [PATCH][buildrobot] libcpp/lex.c: Use enum properly

2013-10-24 Thread Andrew Pinski
On Thu, Oct 24, 2013 at 6:22 PM, Mike Stump wrote: > On Oct 24, 2013, at 2:05 AM, Jan-Benedict Glaw wrote: >> - enum raw_str_phase { RAW_STR_PREFIX, RAW_STR, RAW_STR_SUFFIX }; >> - raw_str_phase phase = RAW_STR_PREFIX; >> + enum raw_str_phase { RAW_STR_PREFIX, RAW_STR, RAW_STR_SUFFIX } phase =

Re: [PATCH][buildrobot] libcpp/lex.c: Use enum properly

2013-10-24 Thread Mike Stump
On Oct 24, 2013, at 2:05 AM, Jan-Benedict Glaw wrote: > - enum raw_str_phase { RAW_STR_PREFIX, RAW_STR, RAW_STR_SUFFIX }; > - raw_str_phase phase = RAW_STR_PREFIX; > + enum raw_str_phase { RAW_STR_PREFIX, RAW_STR, RAW_STR_SUFFIX } phase = > RAW_STR_PREFIX; Since no one else chimed in… seems