Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

2018-08-07 Thread Qing Zhao
Hi, Christophe, I have attached a patch in PR86519, could you please download it and test it, and let me know the result. thanks. Qing > On Jul 30, 2018, at 8:45 AM, Christophe Lyon > wrote: > > On Wed, 25 Jul 2018 at 19:08, Qing Zhao > wrote: >> >> Hi, >> >>

Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

2018-08-06 Thread Qing Zhao
thanks for reporting this issue. I will take a look. Qing > On Jul 30, 2018, at 8:45 AM, Christophe Lyon > wrote: > > On Wed, 25 Jul 2018 at 19:08, Qing Zhao > wrote: >> >> Hi, >> >> As Wilco suggested, the new added strcmp/strncmp inlining should be only >> en

Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

2018-07-30 Thread Christophe Lyon
On Wed, 25 Jul 2018 at 19:08, Qing Zhao wrote: > > Hi, > > As Wilco suggested, the new added strcmp/strncmp inlining should be only > enabled with O2 and above. > > this is the simple patch for this change. > > tested on both X86 and aarch64. > > Okay for thunk? > > Qing > > gcc/ChangeLog: > > +2

Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

2018-07-26 Thread Qing Zhao
> On Jul 26, 2018, at 3:26 AM, Richard Biener wrote: > > On Wed, 25 Jul 2018, Qing Zhao wrote: > >> Hi, >> >> As Wilco suggested, the new added strcmp/strncmp inlining should be only >> enabled with O2 and above. >> >> this is the simple patch for this change. >> >> tested on both X86 and

Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

2018-07-26 Thread Richard Biener
On Wed, 25 Jul 2018, Qing Zhao wrote: > Hi, > > As Wilco suggested, the new added strcmp/strncmp inlining should be only > enabled with O2 and above. > > this is the simple patch for this change. > > tested on both X86 and aarch64. > > Okay for thunk? You should simply use if (optimize_in