On Wed, 25 Jul 2018, Qing Zhao wrote:
> Hi,
>
> As Wilco suggested, the new added strcmp/strncmp inlining should be only
> enabled with O2 and above.
>
> this is the simple patch for this change.
>
> tested on both X86 and aarch64.
>
> Okay for thunk?
You should simply use
if (optimize_insn_for_size_p ())
return NULL_RTX;
to be properly profile-aware. OK with that change.
Richard.
> Qing
>
> gcc/ChangeLog:
>
> +2018-07-25 Qing Zhao <[email protected]>
> +
> + * builtins.c (inline_expand_builtin_string_cmp): Disable inlining
> + when optimization level is lower than 2 or optimize for size.
> +
>
> gcc/testsuite/ChangeLog:
>
> +2018-07-25 Qing Zhao <[email protected]>
> +
> + * gcc.dg/strcmpopt_5.c: Change to O2 to enable the transformation.
> + * gcc.dg/strcmpopt_6.c: Likewise.
> +
>
>
--
Richard Biener <[email protected]>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB
21284 (AG Nuernberg)
