Re: [PATCH] Fix -Wunused-var-35.C (was Re: [PATCH][C++] Improve compile-time by ordering expensive checks last)

OK. On Thu, Apr 25, 2019 at 7:27 AM Jakub Jelinek wrote: > > On Thu, Apr 25, 2019 at 01:09:00PM +0200, Rainer Orth wrote: > > > cp/ > > > * call.c (null_ptr_cst_p): Order checks according to expensiveness. > > > (conversion_null_warnings): Likewise. > > > * typeck.c (same_type_ign

Re: [PATCH] Fix -Wunused-var-35.C (was Re: [PATCH][C++] Improve compile-time by ordering expensive checks last)

On Thu, 25 Apr 2019, Jakub Jelinek wrote: > On Thu, Apr 25, 2019 at 01:39:02PM +0200, Richard Biener wrote: > > > Regtested on x86_64-linux and i686-linux, ok for trunk? > > > > The patch would be obvious but I wonder how the above can change > > anything... (but I can reproduce with even only

Re: [PATCH] Fix -Wunused-var-35.C (was Re: [PATCH][C++] Improve compile-time by ordering expensive checks last)

On Thu, Apr 25, 2019 at 01:39:02PM +0200, Richard Biener wrote: > > Regtested on x86_64-linux and i686-linux, ok for trunk? > > The patch would be obvious but I wonder how the above can change > anything... (but I can reproduce with even only that change) Haven't stepped through it in a debugge

Re: [PATCH] Fix -Wunused-var-35.C (was Re: [PATCH][C++] Improve compile-time by ordering expensive checks last)

On Thu, 25 Apr 2019, Jakub Jelinek wrote: > On Thu, Apr 25, 2019 at 01:09:00PM +0200, Rainer Orth wrote: > > > cp/ > > > * call.c (null_ptr_cst_p): Order checks according to expensiveness. > > > (conversion_null_warnings): Likewise. > > > * typeck.c (same_type_ignoring_top_level_qualifiers

[PATCH] Fix -Wunused-var-35.C (was Re: [PATCH][C++] Improve compile-time by ordering expensive checks last)

On Thu, Apr 25, 2019 at 01:09:00PM +0200, Rainer Orth wrote: > > cp/ > > * call.c (null_ptr_cst_p): Order checks according to expensiveness. > > (conversion_null_warnings): Likewise. > > * typeck.c (same_type_ignoring_top_level_qualifiers_p): Return > > early if type1 == type2.

Re: [PATCH][C++] Improve compile-time by ordering expensive checks last

Hi Richard, > On Tue, 16 Apr 2019, Richard Biener wrote: > >> >> Two cases from a -fsynax-only tramp3d callgrind profile. > > Amended by two others. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > 2019-04-17 Richard Biener > > cp/ > * cal

Re: [PATCH][C++] Improve compile-time by ordering expensive checks last

OK. On Wed, Apr 17, 2019 at 6:44 AM Richard Biener wrote: > > On Tue, 16 Apr 2019, Richard Biener wrote: > > > > > Two cases from a -fsynax-only tramp3d callgrind profile. > > Amended by two others. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > 2019-0

Re: [PATCH][C++] Improve compile-time by ordering expensive checks last

On Tue, 16 Apr 2019, Richard Biener wrote: > > Two cases from a -fsynax-only tramp3d callgrind profile. Amended by two others. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK? Thanks, Richard. 2019-04-17 Richard Biener cp/ * call.c (null_ptr_cst_p): Order checks a