Re: [PATCH][AARCH64]PR60034

2014-03-25 Thread Marcus Shawcroft
On 25 March 2014 04:55, Kugan wrote: > gcc/ > > 2014-03-25 Kugan Vivekanandarajah > > PR target/60034 > * aarch64/aarch64.c (aarch64_classify_address): Fix alignment for > section anchor. > > gcc/testsuite/ > > 2014-03-25 Kugan Vivekanandarajah > > PR target/

Re: [PATCH][AARCH64]PR60034

2014-03-24 Thread Kugan
>> If I understand gcc/rtl.h correctly, SYMBOL_REF_ANCHOR_P (sym) is >> required for anchor SYMBOL_REFS. SYMBOL_REF_BLOCK (sym) != NULL is >> probably redundant. This can probably become an gcc_assert >> (SYMBOL_REF_BLOCK (sym)) instead. > > I agree with your interpretation of the code and commen

Re: [PATCH][AARCH64]PR60034

2014-03-12 Thread Marcus Shawcroft
>> + else if (SYMBOL_REF_HAS_BLOCK_INFO_P (sym) >> >> This test makes sense. >> >> + && SYMBOL_REF_ANCHOR_P (sym) >> >> Do we need this test or is the patch being conservative? I would >> have thought that it is sufficient to drop this test and just take the >> block alignment... >> >

Re: [PATCH][AARCH64]PR60034

2014-03-12 Thread Kugan
On 12/03/14 20:07, Marcus Shawcroft wrote: > Hi Kugan > > > On 3 March 2014 21:56, Kugan wrote: > >> gcc/ >> >> 2014-03-03 Kugan Vivekanandarajah >> >> PR target/60034 >> * aarch64/aarch64.c (aarch64_classify_address): Fix alignment for >> section anchor. >> >> >> >

Re: [PATCH][AARCH64]PR60034

2014-03-12 Thread Marcus Shawcroft
Hi Kugan On 3 March 2014 21:56, Kugan wrote: > gcc/ > > 2014-03-03 Kugan Vivekanandarajah > > PR target/60034 > * aarch64/aarch64.c (aarch64_classify_address): Fix alignment for > section anchor. > > > > gcc/testsuite/ > > 2014-03-03 Kugan Vivekanandarajah > >

Re: [PATCH][AARCH64]PR60034

2014-03-11 Thread Kugan
Ping ? > > > gcc/ > > 2014-03-03 Kugan Vivekanandarajah > > PR target/60034 > * aarch64/aarch64.c (aarch64_classify_address): Fix alignment for > section anchor. > > > > gcc/testsuite/ > > 2014-03-03 Kugan Vivekanandarajah > > PR target/60034 > * gcc.t

Re: [PATCH][AARCH64]PR60034

2014-03-03 Thread Kugan
On 27/02/14 22:32, Marcus Shawcroft wrote: > On 21 February 2014 04:24, Kugan wrote: > >> Compiling inline asm results in ICE (PR60034). Alignment calculation in >> aarch64_classify_address for (symbol_ref:DI ("*.LANCHOR4") [flags >> 0x182])) seems wrong here. > > Hi Kugan, > > + else if (

Re: [PATCH][AARCH64]PR60034

2014-02-27 Thread Marcus Shawcroft
On 21 February 2014 04:24, Kugan wrote: > Compiling inline asm results in ICE (PR60034). Alignment calculation in > aarch64_classify_address for (symbol_ref:DI ("*.LANCHOR4") [flags > 0x182])) seems wrong here. Hi Kugan, + else if (SYMBOL_REF_FLAGS (sym)) + align = GET_MODE_ALIGNMENT (GET_