Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-03-03 Thread Tobias Grosser
On 03/03/2014 12:39 PM, Richard Biener wrote: On Fri, Feb 28, 2014 at 8:37 PM, Mircea Namolaru wrote: Hi, Thanks. Here is the updated patch. Boostrapped / tested on x86_64-unknown-linux-gnu and applied. Thanks Richard! Tobias

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-03-03 Thread Richard Biener
On Fri, Feb 28, 2014 at 8:37 PM, Mircea Namolaru wrote: > Hi, > > Thanks. Here is the updated patch. Boostrapped / tested on x86_64-unknown-linux-gnu and applied. Thanks, Richard. > 2014-02-26 Tobias Grosser > Mircea Namolaru > > PR tree-optimization/58028 > * graphit

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-28 Thread Mircea Namolaru
Hi, Thanks. Here is the updated patch. 2014-02-26 Tobias Grosser Mircea Namolaru PR tree-optimization/58028 * graphite-clast-to-gimple.c (set_cloog_options): Don't remove scalar dimensions. Index: gcc/graphite-clast-to-gimple.c =

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-27 Thread Rainer Orth
Hi Mircea, two last nits: > 2014-02-26 Tobias Grosser > Mircea Namolaru > > Fix for bug 58028 Please write this as PR tree-optimization/58028 instead. This way, the commit triggers an update to the bugzilla bug. > * graphite-clast-to-gimple.c (set_c

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-27 Thread Mircea Namolaru
bias Burnus" > Cc: "Tobias Grosser" , "Mircea Namolaru" > , gcc-patches@gcc.gnu.org > Envoyé: Jeudi 27 Février 2014 11:14:30 > Objet: Re: [PATCH,GRAPHITE] Fix for P1 bug 58028 > > Tobias Burnus writes: > > > On 02/26/2014 10:09 PM, Mircea Nam

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-27 Thread Rainer Orth
Tobias Burnus writes: > On 02/26/2014 10:09 PM, Mircea Namolaru wrote: >> + /* Do not remove scalar dimensions. Cloog be default removes scalar >> + dimensions very early from the input schedule. However, they are > > Small nit: Instead of 'be default' it should be 'by default' ... and two space

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-27 Thread Tobias Burnus
Hi Tobias and Mircea, On 02/26/2014 10:09 PM, Mircea Namolaru wrote: > + /* Do not remove scalar dimensions. Cloog be default removes scalar > + dimensions very early from the input schedule. However, they are Small nit: Instead of 'be default' it should be 'by default' Tobias

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-27 Thread Richard Biener
On Wed, Feb 26, 2014 at 10:13 PM, Tobias Grosser wrote: > On 02/26/2014 10:09 PM, Mircea Namolaru wrote: >> >> This patch fixes the libgomp problems: >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028 >> >> 2014-02-26 Tobias Grosser >> Mircea Namolaru >> >> Fix for bug 58028 >> * graphite-clas

Re: [PATCH,GRAPHITE] Fix for P1 bug 58028

2014-02-26 Thread Tobias Grosser
On 02/26/2014 10:09 PM, Mircea Namolaru wrote: This patch fixes the libgomp problems: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028 2014-02-26 Tobias Grosser Mircea Namolaru Fix for bug 58028 * graphite-clast-to-gimple.c (set_cloog_options): Don't remove scalar dimensions Index: gcc/grap

Re: [PATCH,GRAPHiTE] Fix for P1 bug 58028

2014-02-26 Thread Tobias Grosser
On 02/26/2014 03:30 PM, Mircea Namolaru wrote: This patch fixes the libgomp problems: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028 2014-02-26 Tobies Grosser Mircea Namolaru Hi Mircea, the patch is correct. Fix for bug 58028 * graphite-clast-to-gimple.c (set_cloog_options): Don't remo