On 02/26/2014 03:30 PM, Mircea Namolaru wrote:
This patch fixes the libgomp problems:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028

2014-02-26 Tobies Grosser <tob...@grosser.es>
Mircea Namolaru <mnamo...@inria.fr>

Hi Mircea,

the patch is correct.

Fix for bug 58028
* graphite-clast-to-gimple.c (set_cloog_options):
Don't remove scalar dimensions

Index: gcc/graphite-clast-to-gimple.c
===================================================================
--- gcc/graphite-clast-to-gimple.c (revision 207298)
+++ gcc/graphite-clast-to-gimple.c (working copy)
@@ -1522,6 +1522,10 @@
variables. */
options->save_domains = 1;

+ /* Don't remove scalars dimensions - original number of dimensions required
+ for loop->can_be_parallel check. */
+ options->noscalars = 1;

Maybe we can provide a little bit more information. What about the following:

Do not remove scalar dimensions. Cloog be default removes scalar dimensions very early from the input schedule. However, they are necessary to correctly derive from the saved domains (options->save_domains) the relationship between the generated loops and the schedule dimensions they are generated from.

As this patch fixes a regression it should be fine at this stage. However, let's wait for the explicit OK from a release manager.

Tobias

Btw.: Do you have commit access?


Reply via email to