Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:44 PM Luc Grosheintz wrote: > Implements the tests for layout_stride and for the features of the other > two layouts that depend on layout_stride. > > libstdc++-v3/ChangeLog: > > * testsuite/23_containers/mdspan/layouts/class_mandate_neg.cc: Add > tests f

Re: [PATCH] vect: Improve vectorization for small-trip-count loops using subvectors

2025-06-03 Thread Richard Biener
On Fri, May 9, 2025 at 4:05 PM Tamar Christina wrote: > > > -Original Message- > > From: Richard Biener > > Sent: Friday, May 9, 2025 2:44 PM > > To: Tamar Christina > > Cc: Richard Sandiford ; Pengfei Li > > ; gcc-patches@gcc.gnu.org; ktkac...@n

Re: [PATCH v5 3/8] libstdc++: Add tests for layout_left.

2025-06-03 Thread Tomasz Kaminski
On Tue, Jun 3, 2025 at 2:50 PM Luc Grosheintz wrote: > > > On 6/3/25 14:31, Tomasz Kaminski wrote: > > On Mon, Jun 2, 2025 at 9:07 AM Luc Grosheintz > > wrote: > > > >> > >> > >> On 5/30/25 18:42, Luc Grosheintz wrote: > >>> Implements a suite of tests for the currently implemented parts of > >>

Re: [PATCH] aarch64:sve: Use create_tmp_reg_or_ssa_name instead of create_tmp_var in the folder

2025-06-03 Thread Richard Biener
On Sun, Jun 1, 2025 at 6:57 PM Andrew Pinski wrote: > > On Sun, Jun 1, 2025 at 3:54 AM Richard Biener > wrote: > > > > On Sat, May 31, 2025 at 8:41 PM Andrew Pinski > > wrote: > > > > > > Currently gimple_folder::convert_and_fold calls create_tmp_var; that > > > means while in ssa form, > > >

Re: [PATCH v5 1/8] libstdc++: Improve naming, whitespace and silence warnings for extents.

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 13:08, Tomasz Kaminski wrote: > > > > On Fri, May 30, 2025 at 6:45 PM Luc Grosheintz > wrote: >> >> libstdc++-v3/ChangeLog: >> >> * include/std/mdspan(__mdspan::_ExtentsStorage): Change name >> of private member _M_dynamic_extens to _M_dyn_exts. >> *

Re: [PATCH v5 2/8] libstdc++: Implement layout_left from mdspan.

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 13:13, Tomasz Kaminski wrote: > > > > On Fri, May 30, 2025 at 6:47 PM Luc Grosheintz > wrote: >> >> Implements the parts of layout_left that don't depend on any of the >> other layouts. >> >> libstdc++-v3/ChangeLog: >> >> * include/std/mdspan (layout_left): New clas

Re: [PATCH v5 3/8] libstdc++: Add tests for layout_left.

2025-06-03 Thread Luc Grosheintz
On 6/3/25 14:31, Tomasz Kaminski wrote: On Mon, Jun 2, 2025 at 9:07 AM Luc Grosheintz wrote: On 5/30/25 18:42, Luc Grosheintz wrote: Implements a suite of tests for the currently implemented parts of layout_left. The individual tests are templated over the layout type, to allow reuse as

Re: [PATCH v5 6/8] libstdc++: Implement layout_stride from mdspan.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:47 PM Luc Grosheintz wrote: > Implements the remaining parts of layout_left and layout_right; and all > of layout_stride. > > The implementation of layout_stride::mapping::is_exhaustive applies > the following change to the standard: > > 4266. layout_stride::mapping sh

Re: [PATCH v5 5/8] libstdc++: Add tests for layout_right.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:50 PM Luc Grosheintz wrote: > Adds tests for layout_right and for the parts of layout_left that depend > on layout_right. > > libstdc++-v3/ChangeLog: > > * testsuite/23_containers/mdspan/layouts/class_mandate_neg.cc: Add > tests for layout_right. >

Re: [PATCH v5 4/8] libstdc++: Implement layout_right from mdspan.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:49 PM Luc Grosheintz wrote: > Implement the parts of layout_left that depend on layout_right; and the > parts of layout_right that don't depend on layout_stride. > > libstdc++-v3/ChangeLog: > > * include/std/mdspan (layout_right): New class. > * src/c++23

Re: [PATCH v5 3/8] libstdc++: Add tests for layout_left.

2025-06-03 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 9:07 AM Luc Grosheintz wrote: > > > On 5/30/25 18:42, Luc Grosheintz wrote: > > Implements a suite of tests for the currently implemented parts of > > layout_left. The individual tests are templated over the layout type, to > > allow reuse as more layouts are added. > > > >

Re: [PATCH] libstdc++: Use new __is_destructible built-in in

2025-06-03 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 10:56 PM Jonathan Wakely wrote: > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_destructible, is_destructible_v): > Define using new built-in. > (is_nothrow_destructible, is_nothrow_destructible_v): Likewise. > (is_trivially_destr

Re: [PATCH v5 3/8] libstdc++: Add tests for layout_left.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:52 PM Luc Grosheintz wrote: > Implements a suite of tests for the currently implemented parts of > layout_left. The individual tests are templated over the layout type, to > allow reuse as more layouts are added. > > libstdc++-v3/ChangeLog: > > * testsuite/23_con

Re: [PATCH v5 2/8] libstdc++: Implement layout_left from mdspan.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:47 PM Luc Grosheintz wrote: > Implements the parts of layout_left that don't depend on any of the > other layouts. > > libstdc++-v3/ChangeLog: > > * include/std/mdspan (layout_left): New class. > * src/c++23/std.cc.in: Add layout_left. > > Signed-off-by:

Re: [PATCH v5 1/8] libstdc++: Improve naming, whitespace and silence warnings for extents.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:45 PM Luc Grosheintz wrote: > libstdc++-v3/ChangeLog: > > * include/std/mdspan(__mdspan::_ExtentsStorage): Change name > of private member _M_dynamic_extens to _M_dyn_exts. > * include/std/mdspan(extents): Change name of private member > f

Re: [PATCH 02/14] aarch64: Add support for unpacked SVE FP conversions

2025-06-03 Thread Spencer Abson
Thanks, Alfie. I agree that having a table with just one entry looks a little odd, but the rest of the file follows this pattern. For example: ;; - ;; [FP] Absolute difference ;;

Re: [PATCH] libstdc++: Fix errors in atomic timed waiting functions

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 11:04, Tomasz Kaminski wrote: > > > > On Tue, Jun 3, 2025 at 12:02 PM Jonathan Wakely wrote: >> >> On Tue, 3 Jun 2025 at 09:38, Tomasz Kaminski wrote: >> > >> > >> > >> > On Mon, Jun 2, 2025 at 10:59 PM Jonathan Wakely wrote: >> >> >> >> These function templates are apparen

Re: [Patch] libgomp.texi (omp_interop_*): Add note about 5.2-to-6.0 incompatibility

2025-06-03 Thread Tobias Burnus
Hi Sandra, hello world, Sandra Loosemore wrote: On 6/2/25 12:15, Tobias Burnus wrote: The problem is that 'int'/'int*' became 'omp_interop_rc_t ret_code' and 'omp_interop_rc_t *ret_code'. ... I think the patch just confuses readers, as-is.  Plus it has a grammar bug.  How about instead of +

Re: [Fortran, Patch, PR120483, v2] Fix wrong type of saved allocatable strings.

2025-06-03 Thread Andre Vehreschild
Hi all, thanks for the explanations, Christophe. This is very much appreciated. And sorry, I can't follow all presentations, conferences and publications. There is meanwhile way too much for me to process out there. Anyway, the regression I produced in gomp should be fixed by the new version of p

Re: [PATCH v1 0/4] RISC-V: Combine vec_duplicate + vdiv.vv to vdiv.vx on GR2VR cost

2025-06-03 Thread Robin Dapp
This patch would like to introduce the combine of vec_dup + vdiv.vv into vdiv.vx on the cost value of GR2VR. The late-combine will take place if the cost of GR2VR is zero, or reject the combine if non-zero like 1, 15 in test. There will be two cases for the combine: The series is OK, thanks.

Re: [PATCH] libstdc++: Use new __is_destructible built-in in

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 10:54, Tomasz Kaminski wrote: > > > > On Mon, Jun 2, 2025 at 10:56 PM Jonathan Wakely wrote: >> >> libstdc++-v3/ChangeLog: >> >> * include/std/type_traits (is_destructible, is_destructible_v): >> Define using new built-in. >> (is_nothrow_destructible,

Re: [PATCH] libstdc++: Fix incorrect comments on atomic timed waits

2025-06-03 Thread Tomasz Kaminski
With the change to the title, this looks good to me. On Tue, Jun 3, 2025 at 12:02 PM Tomasz Kaminski wrote: > The tile says that you are doing only comment fixes, while there is code > change > in __spin_until_impl. Could you please adjust it: > Fix incorrect returns and comments on atomic timed

Re: [PATCH] libstdc++: Fix errors in atomic timed waiting functions

2025-06-03 Thread Tomasz Kaminski
On Tue, Jun 3, 2025 at 12:02 PM Jonathan Wakely wrote: > On Tue, 3 Jun 2025 at 09:38, Tomasz Kaminski wrote: > > > > > > > > On Mon, Jun 2, 2025 at 10:59 PM Jonathan Wakely > wrote: > >> > >> These function templates are apparently never used or instantiated, > >> because they don't compile. Thi

Re: [PATCH] libstdc++: Fix incorrect comments on atomic timed waits

2025-06-03 Thread Tomasz Kaminski
The tile says that you are doing only comment fixes, while there is code change in __spin_until_impl. Could you please adjust it: Fix incorrect returns and comments on atomic timed waits On Mon, Jun 2, 2025 at 7:24 PM Jonathan Wakely wrote: > The __detail::__wait_until function has a comment tha

Re: [PATCH] libstdc++: Fix errors in atomic timed waiting functions

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 11:01, Jonathan Wakely wrote: > > On Tue, 3 Jun 2025 at 09:38, Tomasz Kaminski wrote: > > > > > > > > On Mon, Jun 2, 2025 at 10:59 PM Jonathan Wakely wrote: > >> > >> These function templates are apparently never used or instantiated, > >> because they don't compile. This fi

Re: [PATCH] libstdc++: Fix errors in atomic timed waiting functions

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 09:38, Tomasz Kaminski wrote: > > > > On Mon, Jun 2, 2025 at 10:59 PM Jonathan Wakely wrote: >> >> These function templates are apparently never used or instantiated, >> because they don't compile. This fixes them, but they're still unused. >> I plan to make use of them in a

Re: [PATCH] libstdc++: Use explicit cast to unsigned in std::rotr and std::rotl

2025-06-03 Thread Jonathan Wakely
On Tue, 3 Jun 2025 at 09:23, Tomasz Kaminski wrote: > > > > > On Mon, Jun 2, 2025 at 7:28 PM Jonathan Wakely wrote: >> >> This suppresses some -Wsign-conversion warnings from Clang when >> compiling with -Wsystem-headers. >> >> libstdc++-v3/ChangeLog: >> >> * include/std/bit (__rotl, __ro

Re: [PATCH] RISC-V:Add the MIPS P8700 conditional move extension instruction support.

2025-06-03 Thread Umesh Kalappa
Hi @Jeff Law , @pal...@dabbelt.com and all , Please can you pass your comments on the below changes ,thank you ~U On Tue, May 27, 2025 at 4:36 PM Umesh Kalappa wrote: > The P8700 is a high-performance processor from MIPS by extending RISCV with > the MIPS custom instruction and the followin

Re: [PATCH] libstdc++: Replace some implicit conversions in std::vector

2025-06-03 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 7:33 PM Jonathan Wakely wrote: > This replaces two implicit conversions from ptrdiff_t to size_t with > explicit conversions that include unreachable hints for the ptrdiff_t > value not being negative. > > libstdc++-v3/ChangeLog: > > * include/bits/stl_vector.h (~_V

Re: [PATCH] libstdc++: Fix errors in atomic timed waiting functions

2025-06-03 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 10:59 PM Jonathan Wakely wrote: > These function templates are apparently never used or instantiated, > because they don't compile. This fixes them, but they're still unused. > I plan to make use of them in a later commit. > > libstdc++-v3/ChangeLog: > > * include/b

Re: [EXT] Re: [PATCH v3] rs6000: Adding missed ISA 3.0 atomic memory operation instructions.

2025-06-03 Thread Surya Kumari Jangala
On 02/06/25 12:30 pm, Surya Kumari Jangala wrote: > > On 30/05/25 1:37 am, Peter Bergner wrote: >> On 5/29/25 5:35 AM, Segher Boessenkool wrote: >>> +#define _AMO_LD_INCREMENT(NAME, TYPE, OPCODE, FC) \ +static __inline__ TYPE

Re: [PATCH] libstdc++: Use explicit cast to unsigned in std::rotr and std::rotl

2025-06-03 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 7:28 PM Jonathan Wakely wrote: > This suppresses some -Wsign-conversion warnings from Clang when > compiling with -Wsystem-headers. > > libstdc++-v3/ChangeLog: > > * include/std/bit (__rotl, __rotr): Use static_cast for > conversion from int to unsigned. > -

Re: [PATCH] libstdc++: Remove redundant macro checks in std.cc.in

2025-06-03 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 7:25 PM Jonathan Wakely wrote: > __cpp_lib_any and __cpp_lib_chrono are defined unconditionally in C++20 > and __cpp_lib_three_way_comparison and __cpp_lib_concepts depend on > front-end features which are definitely supported by GCC trunk. > > libstdc++-v3/ChangeLog: > >

Re: [Fortran, Patch, PR120483, v1] Fix wrong type of saved allocatable strings.

2025-06-03 Thread Christophe Lyon
Hi! On Mon, 2 Jun 2025 at 20:53, Andre Vehreschild wrote: > > Hi Thomas, > > thanks for the ok. Unfortunately does the patch regress in gomp (test case > gomp/pr104382 when I am not mistaken ; the one with the lone 'save' > statement). This was reported by the regression testing host at first

Re: [PATCH 1/2]middle-end: Apply loop->unroll directly in vectorizer

2025-06-03 Thread Richard Biener
> Am 02.06.2025 um 14:16 schrieb Tamar Christina : > >  >> >> -Original Message- >> From: Richard Biener >> Sent: Monday, May 26, 2025 2:56 PM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd >> Subject: RE: [PATCH 1/2]mi

Re: [PATCH v2 1/2] RISC-V: Add pattern for vector-scalar multiply-add/sub [PR119100]

2025-06-03 Thread Robin Dapp
This series is OK now, thanks. -- Regards Robin

Re: [PATCH] RISC-V: Support CPUs in -march.

2025-06-03 Thread Robin Dapp
1. riscv64-linux-gcc -march=rv64gc -march=foo-cpu -mtune=foo-cpu 2. riscv64-linux-gcc -march=rv64gc -march=foo-cpu 3. riscv64-linux-gcc -march=rv64gc -march=unset -mtune=unset -mcpu=foo-cpu Preference to me: - Prefer option 1. - Less prefer option 3. (acceptable but I don't like) - Strongly disli

Re: [PATCH 1/2]middle-end: Apply loop->unroll directly in vectorizer

2025-06-03 Thread Richard Biener
;> To: Tamar Christina >>> Cc: gcc-patches@gcc.gnu.org; nd >>> Subject: RE: [PATCH 1/2]middle-end: Apply loop->unroll directly in >>> vectorizer >>> >>>> On Mon, 19 May 2025, Tamar Christina wrote: >>> >>>>>> /

Re: [PATCH] phiprop: Add testcase for already fixed case [PR116824]

2025-06-02 Thread Richard Biener
> Am 03.06.2025 um 05:59 schrieb Andrew Pinski : > > This testcase was fixed by r16-906-g8da568c885dc90. Since > this is a C testcase, it would be useful to have a C testcase besides > a C++ one too. > > Tested for x86_64-linux-gnu. Ok Richard >PR tree-optimization/116824 > > gcc/tes

Re: [PATCH] switch-conversion: Mark CSWTCH as mergeable [PR120451]

2025-06-02 Thread Richard Biener
> Am 03.06.2025 um 04:51 schrieb Andrew Pinski : > > When we have a smallish CSWTCH, it could be placed in the rodata.cst16 > section so it can be merged with other constants across TUs. > > The fix is simple; just mark the decl as mergable (DECL_MERGEABLE). > DECL_MERGEABLE was added with r1

Re: [PATCH] RISC-V: Support CPUs in -march.

2025-06-02 Thread Kito Cheng
I am a little hesitant about whether to let -march implicitly set -mtune, because this is equivalent to making -march become another -mcpu with higher priority, and we cannot avoid discussing the priority of -march and -mtune again, and no matter what the priority is, it will introduce more complic

Re: [PATCH v2] RISC-V: Add svbare extension.

2025-06-02 Thread Jeff Law
On 6/2/25 7:34 PM, Kito Cheng wrote: LGTM, and will commit once CI happy, BTW, next time you could name the testcase into arch-.c e.g. arch-svbare.c, that could prevent potential filename conflict. :) Yea, I nearly made a similar suggestion. Not sure why we're using numeric suffixes here. T

Re: [PATCH] RISC-V: Add svbare extension.

2025-06-02 Thread Dongyan Chen
I add a ChangeLog and update testname in https://gcc.gnu.org/pipermail/gcc-patches/2025-June/685401.html Thanks Dongyan Chen 在 2025/6/3 3:34, Jeff Law 写道: On 5/29/25 7:27 AM, Dongyan Chen wrote: This patch support svbare extension, which is an extension in RVA23 profile. To enable GCC to

Re: [PATCH v2] RISC-V: Add svbare extension.

2025-06-02 Thread Dongyan Chen
Okay, thanks, I get that. Dongyan Chen 在 2025/6/3 9:34, Kito Cheng 写道: LGTM, and will commit once CI happy, BTW, next time you could name the testcase into arch-.c e.g. arch-svbare.c, that could prevent potential filename conflict. :)

Re: [PATCH] c++: Fix template class lookup [PR120495, PR115605].

2025-06-02 Thread Jason Merrill
On 6/2/25 6:28 PM, Iain Sandoe wrote: Tested on x86_64-darwin and powerpc64le so far, how does this look? thanks Iain --- 8< --- Using lookup_template_class () directly on the coroutine_handle identifier fails in the reported test because the using TYPE_DECL is found. This is because lookup i

Re: [PATCH v2] c++, coroutines: CWG2563 promise lifetime extension [PR115908].

2025-06-02 Thread Jason Merrill
On 6/2/25 5:27 PM, Iain Sandoe wrote: On 2 Jun 2025, at 21:17, Jason Merrill wrote: On 6/1/25 3:30 AM, Iain Sandoe wrote: Updated. I realised we no longer need to refer to initial_await_resume_called in the ramp at all, v2 removes the setting of the variable from there and puts it into the

Re: [PATCH v2] RISC-V: Add svbare extension.

2025-06-02 Thread Kito Cheng
LGTM, and will commit once CI happy, BTW, next time you could name the testcase into arch-.c e.g. arch-svbare.c, that could prevent potential filename conflict. :) On Tue, Jun 3, 2025 at 9:22 AM Dongyan Chen wrote: > > This patch support svbare extension, which is an extension in RVA23 profile. >

Re: [PATCH] Always add REG_CALL_DECL note for CALL

2025-06-02 Thread H.J. Lu
On Tue, Jun 3, 2025 at 6:06 AM H.J. Lu wrote: > > On Mon, Jun 2, 2025 at 4:45 PM Richard Sandiford > wrote: > > > > "H.J. Lu" writes: > > > On Mon, Jun 2, 2025 at 4:07 PM Richard Sandiford > > > wrote: > > >> > > >> "H.J. Lu" writes: > > >> > Since not all CALL instructions in RTL passes have

Re: [PATCH] gcc: middle-end opt for trigonometric pi-based functions builtins

2025-06-02 Thread Tobias Burnus
Joseph Myers wrote: On Sun, 1 Jun 2025, Yuao Ma wrote: For MPFR versions older than 4.2.0, we've included our own folding functions. I think the normal practice in GCC would be to avoid the optimizations when the MPFR support is absent, instead of working around the absence with possibly less a

Re: [PATCH v2] c++, coroutines: CWG2563 promise lifetime extension [PR115908].

2025-06-02 Thread Iain Sandoe
> On 2 Jun 2025, at 21:17, Jason Merrill wrote: > > On 6/1/25 3:30 AM, Iain Sandoe wrote: >> Updated. I realised we no longer need to refer to >> initial_await_resume_called in the ramp at all, v2 removes the setting >> of the variable from there and puts it into the start of the actor. >> Tes

Re: [PATCH v2 2/2] emit-rtl: Validate mode for paradoxical hardware subregs [PR119966]

2025-06-02 Thread Dimitar Dimitrov
On Thu, May 29, 2025 at 05:59:44PM +0100, Richard Sandiford wrote: > Sorry for the slow reply. > > Dimitar Dimitrov writes: > > On Fri, May 16, 2025 at 06:14:30PM +0100, Richard Sandiford wrote: > >> Dimitar Dimitrov writes: ... > >> It might still be worth trying to use simplify_subreg_regno an

Re: [PATCH] RISC-V: Support CPUs in -march.

2025-06-02 Thread Palmer Dabbelt
On Mon, 02 Jun 2025 12:35:45 PDT (-0700), Robin Dapp wrote: I don't quite follow this part. IIUC the rules before this patch were -march=ISA: Generate code that requires the given ISA, without changing the tuning model. -mcpu=CPU: Generate code for the given CPU, targeting all the

Re: [PATCH v2] c++, coroutines: CWG2563 promise lifetime extension [PR115908].

2025-06-02 Thread Jason Merrill
On 6/1/25 3:30 AM, Iain Sandoe wrote: Updated. I realised we no longer need to refer to initial_await_resume_called in the ramp at all, v2 removes the setting of the variable from there and puts it into the start of the actor. Tested on x86_64-darwin and powerp64le-linux. Confirmed that the sani

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread John Paul Adrian Glaubitz
On Mon, 2025-06-02 at 17:34 +0200, Andreas Schwab wrote: > On Jun 01 2025, John Paul Adrian Glaubitz wrote: > > > I was talking about the comments, not the code since NetBSD and Linux > > disagree on what the SVR4 ABI claims. > > In which way? Both NetBSD and Linux return structs differently, ye

Re: [Patch] libgomp.texi (omp_interop_*): Add note about 5.2-to-6.0 incompatibility

2025-06-02 Thread Sandra Loosemore
On 6/2/25 12:15, Tobias Burnus wrote: Not really new - but as the topic came up elsewhere (OpenMP issue 4455), I had a second thought about this and I think it make sense to add a note. GCC uses the OpenMP 6.0 version. The problem is that 'int'/'int*' became 'omp_interop_rc_t ret_code' and 'omp

Re: [PATCH] c: Enable -Wjump-misses-init in -Wextra and -Wc++-compat [PR87038]

2025-06-02 Thread Segher Boessenkool
Hi! On Mon, Jun 02, 2025 at 08:37:19PM +0200, Martin Uecker wrote: > Am Montag, dem 02.06.2025 um 13:19 -0500 schrieb Segher Boessenkool: > > On Mon, Jun 02, 2025 at 05:50:08PM +0200, Martin Uecker wrote: > > > According to the discussion in the bugzilla there seems to be > > > some consensus to a

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread John Paul Adrian Glaubitz
On Mon, 2025-06-02 at 21:41 +0200, Andreas Schwab wrote: > On Jun 02 2025, John Paul Adrian Glaubitz wrote: > > > To me both statements seem to contradict each other. > > How? They comment two different things. But it's DEFAULT_PCC_STRUCT_RETURN in both cases, no? Adrian -- .''`. John Paul

Re: [Fortran, Patch, PR120483, v1] Fix wrong type of saved allocatable strings.

2025-06-02 Thread Thomas Koenig
Hi Andre, attached patch fixes a missing substring ref on a saved allocatable string. The issue seems to be, that the variable is declared to be a character pointer and not a character array. When using the latter (why not), it works as expected and does not produce any regressions. Regtests o

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread Andreas Schwab
On Jun 02 2025, John Paul Adrian Glaubitz wrote: > To me both statements seem to contradict each other. How? They comment two different things. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely di

Re: [PATCH] RISC-V: Add Shlcofideleg extension.

2025-06-02 Thread Jeff Law
On 5/27/25 1:32 AM, Jiawei wrote: This patch add the RISC-V Shlcofideleg extension. It supports delegating LCOFI interrupts(the count-overflow interrupts) to VS-mode.[1] [1] https://riscv.github.io/riscv-isa-manual/snapshot/privileged gcc/ChangeLog: * config/riscv/riscv-ext.def: New

Re: [PATCH] RISC-V: Support CPUs in -march.

2025-06-02 Thread Robin Dapp
I don't quite follow this part. IIUC the rules before this patch were -march=ISA: Generate code that requires the given ISA, without changing the tuning model. -mcpu=CPU: Generate code for the given CPU, targeting all the extensions that CPU supports and using the best known tu

Re: [PATCH] c: Enable -Wjump-misses-init in -Wextra and -Wc++-compat [PR87038]

2025-06-02 Thread Joseph Myers
On Mon, 2 Jun 2025, Martin Uecker wrote: > Am Montag, dem 02.06.2025 um 18:45 + schrieb Joseph Myers: > > On Mon, 2 Jun 2025, Martin Uecker wrote: > > > > > According to the discussion in the bugzilla there seems to be > > > some consensus to activate the warning for -Wextra (I am also > > >

Re: [PATCH] RISC-V: Add svbare extension.

2025-06-02 Thread Jeff Law
On 5/29/25 7:27 AM, Dongyan Chen wrote: This patch support svbare extension, which is an extension in RVA23 profile. To enable GCC to recognize and process svbare extension correctly at compile time. Needs a ChangeLog entry and the testname needs to be updated now that arch-59 is taken. Wit

Re: [PATCH] RISC-V: Add smcntrpmf extension.

2025-06-02 Thread Jeff Law
On 5/29/25 5:44 AM, Dongyan Chen wrote: This patch support smcntrpmf extension[1]. To enable GCC to recognize and process smcntrpmf extension correctly at compile time. [1]https://github.com/riscvarchive/riscv-smcntrpmf gcc/ChangeLog: * config/riscv/riscv-ext.def: New extension def

Re: [PATCH] c: Enable -Wjump-misses-init in -Wextra and -Wc++-compat [PR87038]

2025-06-02 Thread Martin Uecker
Am Montag, dem 02.06.2025 um 18:45 + schrieb Joseph Myers: > On Mon, 2 Jun 2025, Martin Uecker wrote: > > > According to the discussion in the bugzilla there seems to be > > some consensus to activate the warning for -Wextra (I am also > > looking into implementing the suggested improvements t

Re: [PATCH] Move get_call_rtx_from to final.c

2025-06-02 Thread Jeff Law
On 6/1/25 1:12 AM, H.J. Lu wrote: Move get_call_rtx_from to final.c and call call_from_call_insn. PR other/120493 * final.cc (call_from_call_insn): Change the argument type to const rtx_call_insn *. (get_call_rtx_from): New. * rtl.h (is_a_helper ::test): New. (get_call_rtx_from): Moved to the

Re: [PATCH] RISC-V: Support CPUs in -march.

2025-06-02 Thread Palmer Dabbelt
On Sun, 01 Jun 2025 22:18:21 PDT (-0700), Robin Dapp wrote: This rule clearly applies to directly related options like -ffoo and -fno-foo, but it’s less obvious for unrelated pairs like -ffoo and -fbar especially when there is traditionally strong specifics. In many cases, the principle of "

Re: [Fortran, Patch, PR120483, v1] Fix wrong type of saved allocatable strings.

2025-06-02 Thread Andre Vehreschild
Hi Thomas, thanks for the ok. Unfortunately does the patch regress in gomp (test case gomp/pr104382 when I am not mistaken ; the one with the lone 'save' statement). This was reported by the regression testing host at first for arm, but also occurs on x86_64. Since when are proposed patches ch

Re: [PATCH] c: fix ICE with enum completed with packed attribute after forward decl [PR116892]

2025-06-02 Thread Joseph Myers
On Mon, 2 Jun 2025, Martin Uecker wrote: > I *believe* TYPE_PACKED should be propagated to existing main > variants. > > > Bootstrapped and regression tested for x86_64. > > Martin > > > c: fix ICE with enum completed with packed attribute after forward decl > [PR116892] > > Aft

Re: [PATCH] c: Enable -Wjump-misses-init in -Wextra and -Wc++-compat [PR87038]

2025-06-02 Thread Joseph Myers
On Mon, 2 Jun 2025, Martin Uecker wrote: > According to the discussion in the bugzilla there seems to be > some consensus to activate the warning for -Wextra (I am also > looking into implementing the suggested improvements that may > make it suitable fo r-Wall). When making this change, I also

Re: [PING * 3][PATCH v3] Add new warning Wmissing-designated-initializers [PR39589]

2025-06-02 Thread Joseph Myers
On Sun, 1 Jun 2025, Peter Frost wrote: > Ping https://gcc.gnu.org/pipermail/gcc-patches/2025-January/672568.html This needs various coding style fixes. Lines should be broken before binary operators such as && or || rather than after, and there should be a space before '(' in function and macr

Re: [PATCH] c: Enable -Wjump-misses-init in -Wextra and -Wc++-compat [PR87038]

2025-06-02 Thread Martin Uecker
Am Montag, dem 02.06.2025 um 13:19 -0500 schrieb Segher Boessenkool: > Hi! > > On Mon, Jun 02, 2025 at 05:50:08PM +0200, Martin Uecker wrote: > > According to the discussion in the bugzilla there seems to be > > some consensus to activate the warning for -Wextra (I am also > > looking into impleme

Re: [PATCH] c: Move checking assertions from recursion when forming composite types to avoid ICE.

2025-06-02 Thread Joseph Myers
On Sun, 1 Jun 2025, Martin Uecker wrote: > This patch now moves the checking assertion out of the recursion, > which seems better anyhow. I could not do the check unconditionally > for all types. because we sometimes call composite_type for with > mismatching qualifiers. Calling composite_type wi

Re: [PATCH] c: Enable -Wjump-misses-init in -Wextra and -Wc++-compat [PR87038]

2025-06-02 Thread Segher Boessenkool
Hi! On Mon, Jun 02, 2025 at 05:50:08PM +0200, Martin Uecker wrote: > According to the discussion in the bugzilla there seems to be > some consensus to activate the warning for -Wextra (I am also > looking into implementing the suggested improvements that may > make it suitable fo r-Wall). When m

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread John Paul Adrian Glaubitz
On Mon, 2025-06-02 at 19:44 +0200, Andreas Schwab wrote: > On Jun 02 2025, John Paul Adrian Glaubitz wrote: > > > Both NetBSD and Linux return structs differently, yet the comments in the > > source code claim their way is according to the m68k SVR4 specification. > > Where does it claim that? l

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread Andreas Schwab
On Jun 02 2025, John Paul Adrian Glaubitz wrote: > Both NetBSD and Linux return structs differently, yet the comments in the > source code claim their way is according to the m68k SVR4 specification. Where does it claim that? -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 E

Re: [PATCH] gcc: middle-end opt for trigonometric pi-based functions builtins

2025-06-02 Thread Joseph Myers
On Sun, 1 Jun 2025, Yuao Ma wrote: > For MPFR versions older than 4.2.0, we've included our own folding functions. I think the normal practice in GCC would be to avoid the optimizations when the MPFR support is absent, instead of working around the absence with possibly less accurate implementa

Re: [PATCH] c++,coroutines: Lookup coroutine_handle template [PR120495].

2025-06-02 Thread Iain Sandoe
> On 2 Jun 2025, at 17:10, Andrew Pinski wrote: > > On Mon, Jun 2, 2025 at 8:17 AM Jason Merrill wrote: >> >> On 6/2/25 5:13 AM, Iain Sandoe wrote: >>> Tested on x86_64-darwin, OK for trunk? >>> thanks >>> Iain >>> >>> --- 8< --- >>> >>> Using lookup_template_class () directly on the corou

Re: RISC-V frm mode switching and late_combine2

2025-06-02 Thread Vineet Gupta
Hi Richard, On 6/2/25 01:27, Richard Sandiford wrote: > Vineet Gupta writes: >> +CC gcc-patches >> >> On 5/30/25 14:04, Vineet Gupta wrote: >>> Hi Jeff, Richard >>> >>> As part of RISC-V FRM mode switching improvements, I'm running into a >>> behavior >>> in late_combine2 where it is eliminating

Re: [PATCH 02/14] aarch64: Add support for unpacked SVE FP conversions

2025-06-02 Thread Alfie Richards
On 02/06/2025 11:06, Spencer Abson wrote: This patch introduces expanders for FP<-FP conversions that levarage partial vector modes. We also extend the INT<-FP and FP<-INT conversions using the same approach. The ACLE enables vectorized conversions like the following: fcvt z0.h, p7/m, z1.s Mo

Re: [PATCH] Add newlib to gitignore

2025-06-02 Thread Arijit Kumar Das
. My work would mainly be in newlib, so I thought adding newlib to gitignore would be a good idea in case new test cases for GCC might need to be added. In that case, I would need to remove and re-add the newlib symlink for every GCC patch submitted. This is my understanding. Please correct me if

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread Andreas Schwab
On Jun 01 2025, John Paul Adrian Glaubitz wrote: > I was talking about the comments, not the code since NetBSD and Linux > disagree on what the SVR4 ABI claims. In which way? -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And n

Re: [PATCH] c++, coroutines: Lookup coroutine_handle template [PR120495].

2025-06-02 Thread Andrew Pinski
On Mon, Jun 2, 2025 at 8:17 AM Jason Merrill wrote: > > On 6/2/25 5:13 AM, Iain Sandoe wrote: > > Tested on x86_64-darwin, OK for trunk? > > thanks > > Iain > > > > --- 8< --- > > > > Using lookup_template_class () directly on the coroutine_handle identifier > > fails in the reported test because

Re: [PATCH] c++, coroutines: Some cleanups in build_actor_fn.

2025-06-02 Thread Jason Merrill
On 6/2/25 11:43 AM, Iain Sandoe wrote: On 2 Jun 2025, at 16:33, Iain Sandoe wrote: Hi Jason On 2 Jun 2025, at 16:20, Jason Merrill wrote: On 5/31/25 3:19 PM, Iain Sandoe wrote: Some small cleanups found while working on other changes, tested on x86_64-darwin, OK for trunk? thanks Iain -

Re: [PATCH] c++, coroutines: Some cleanups in build_actor_fn.

2025-06-02 Thread Iain Sandoe
> On 2 Jun 2025, at 16:33, Iain Sandoe wrote: > > Hi Jason > >> On 2 Jun 2025, at 16:20, Jason Merrill wrote: >> >> On 5/31/25 3:19 PM, Iain Sandoe wrote: >>> Some small cleanups found while working on other changes, tested >>> on x86_64-darwin, OK for trunk? >>> thanks >>> Iain >>> --- 8<

Re: [PATCH] c++, coroutines: Some cleanups in build_actor_fn.

2025-06-02 Thread Iain Sandoe
Hi Jason > On 2 Jun 2025, at 16:20, Jason Merrill wrote: > > On 5/31/25 3:19 PM, Iain Sandoe wrote: >> Some small cleanups found while working on other changes, tested >> on x86_64-darwin, OK for trunk? >> thanks >> Iain >> --- 8< --- >> We were incorrectly guarding all the frame cleanups on the

Re: [PATCH] config: Update obsolete macro in pkg.m4

2025-06-02 Thread Simon Marchi
On 5/30/25 5:38 PM, Pietro Monteiro wrote: > The autoconf macro PKG_CHECK_MODULES defined in config/pkg.m4 is used in > binutils/gdb, but not in GCC. That macro uses the obsolete AC_TRY_LINK[1]. > Update the code to use AC_LINK_IFELSE as documented by autoconf. > > Regenerating all autotool files

Re: [PATCH] c++, coroutines: Some cleanups in build_actor_fn.

2025-06-02 Thread Jason Merrill
On 5/31/25 3:19 PM, Iain Sandoe wrote: Some small cleanups found while working on other changes, tested on x86_64-darwin, OK for trunk? thanks Iain --- 8< --- We were incorrectly guarding all the frame cleanups on the basis of frame_needs_free (which is always set for the present code-gen since

Re: [PATCH] c++: Emit an error for attempted constexpr co_await [PR118903].

2025-06-02 Thread Jason Merrill
On 5/30/25 3:50 PM, Iain Sandoe wrote: Tested on x86_64-darwin (but does need the addition of the coroutine keywords to dump_expr), OK for trunk? Thanks, Iain OK. --- 8< --- We checked that the coroutine expressions were not suitable for constexpr, but did not emit and error when needed.

Re: [PATCH] c++: Add co_await, co_yield and co_return to dump_expr.

2025-06-02 Thread Jason Merrill
On 5/30/25 3:48 PM, Iain Sandoe wrote: Tested on x86_64-darwin, OK for trunk? thanks Iain OK. --- 8< --- These were omitted there as an oversight, most of the error handling for the coroutines code is specific rather than using generic %qE etc. gcc/cp/ChangeLog: * error.cc (dump_ex

Re: [PATCH] c++,coroutines: Lookup coroutine_handle template [PR120495].

2025-06-02 Thread Jason Merrill
On 6/2/25 5:13 AM, Iain Sandoe wrote: Tested on x86_64-darwin, OK for trunk? thanks Iain --- 8< --- Using lookup_template_class () directly on the coroutine_handle identifier fails in the reported test because the using TYPE_DECL is found. Hmm, this seems like a longstanding (since the implem

Re: [Patch] libgomp: Add OpenMP's omp_target_memset/omp_target_memset_async [PR120444]

2025-06-02 Thread Andrew Stubbs
On 02/06/2025 15:40, Tobias Burnus wrote: Hi Andrew, Andrew Stubbs wrote: The hsa_memory_copy API is known to be slow, so for smaller data sizes it's probably better to have one hsa_memory_copy replace the whole memset than use three API calls, even with setting up some host-side memory to co

Re: [PING] [PATCH] vect: Improve vectorization for small-trip-count loops using subvectors

2025-06-02 Thread Jeff Law
On 6/2/25 2:23 AM, Pengfei Li wrote: Hi all, I would like to bring attention back to this patch: https://inbox.sourceware.org/gcc-patches/20250508164950.5646-1-pengfei@arm.com/ The patch improves auto-vectorization for loops with known small trip counts by introducing a new target ho

Re: [PATCH] Add newlib to gitignore

2025-06-02 Thread Jeff Law
On 6/2/25 3:01 AM, Arijit Kumar Das wrote: Hi, When compiling GCC for targets like nvptx-none that require newlib, we need to put newlib-cygwin/newlib in the root directory of the source tree (either a copy or a symlink), which is then built by GCC when targeting offload devices like the a

RE: [PATCH 1/2]middle-end: Apply loop->unroll directly in vectorizer

2025-06-02 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Monday, May 26, 2025 2:56 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd > Subject: RE: [PATCH 1/2]middle-end: Apply loop->unroll directly in vectorizer > > On Mon, 19 May

Re: [PATCH] Also check function symbol for function declaration

2025-06-02 Thread H.J. Lu
On Mon, Jun 2, 2025 at 4:45 PM Richard Sandiford wrote: > > "H.J. Lu" writes: > > On Mon, Jun 2, 2025 at 4:07 PM Richard Sandiford > > wrote: > >> > >> "H.J. Lu" writes: > >> > Since not all CALL instructions in RTL passes have a REG_CALL_DECL note, > >> > update get_call_fndecl to also check f

Re: [PATCH] Also check function symbol for function declaration

2025-06-02 Thread Richard Sandiford
"H.J. Lu" writes: > On Mon, Jun 2, 2025 at 4:07 PM Richard Sandiford > wrote: >> >> "H.J. Lu" writes: >> > Since not all CALL instructions in RTL passes have a REG_CALL_DECL note, >> > update get_call_fndecl to also check function symbol for function >> > declaration so that it can be used on CA

Re: [PATCH v2] libstdc++: Pass small trivial types by value in polymorphic wrappers

2025-06-02 Thread Jonathan Wakely
On Thu, 29 May 2025 at 07:49, Tomasz Kamiński wrote: > > This patch adjust the passing of parameters for the move_only_function, > copyable_function and function_ref. For types that are declared as being > passed > by value in signature template argument, they are passed by value to the > invoke

Re: [PATCH] libstdc++: Fix formatting of 3-digits months, day, weekday and hour [PR120481]

2025-06-02 Thread Tomasz Kaminski
On Mon, Jun 2, 2025 at 1:21 PM Tomasz Kamiński wrote: > This patch fixes the handle multiple digits values for the month, day, > weekday > and hour, when used with the %m, %d, %e, %m, %u, %w, %H, and %D, %F > specifiers. > The values are now printed unmodified. This patch also fixes printing > n

Re: [PATCH] libstdc++: Implement C++26 std::polymorphic [PR119152]

2025-06-02 Thread Jonathan Wakely
On Tue, 27 May 2025 at 13:36, Tomasz Kamiński wrote: > > From: Jonathan Wakely > > This patch implements C++26 std::polymorphic as specified in P3019 with > amendment to move assignment from LWG 4251. > > The implementation always allocate stored object on the heap. The manager > function (_M_man

  1   2   3   4   5   6   7   8   9   10   >