Re: RFC: A few more fallthrus

2016-10-05 Thread Jason Merrill
One of these was a bug, though it doesn't affect regression testing. commit c49bb7df1d286456f2e5738c05ea56e6816a7475 Author: Jason Merrill Date: Wed Oct 5 11:32:33 2016 -0400 * parser.c (cp_parser_skip_to_end_of_statement): Add missing break. diff --git a/gcc/cp/call.c b/gcc/cp/call.c inde

Re: RFC: A few more fallthrus

2016-08-17 Thread Jeff Law
On 08/16/2016 10:59 AM, Marek Polacek wrote: On Thu, Aug 11, 2016 at 04:49:30PM +0200, Marek Polacek wrote: A few more cases where I'm unsure whether the fall through is intended. Jason, can you please look at the cp/ part? Given Jason is on PTO this week, can I just commit the patch as-is, mo

Re: RFC: A few more fallthrus

2016-08-16 Thread Marek Polacek
On Thu, Aug 11, 2016 at 04:49:30PM +0200, Marek Polacek wrote: > A few more cases where I'm unsure whether the fall through is intended. > Jason, can you please look at the cp/ part? Given Jason is on PTO this week, can I just commit the patch as-is, modulo the already-committed tree-complex.c par

Re: RFC: A few more fallthrus

2016-08-12 Thread Marek Polacek
On Fri, Aug 12, 2016 at 09:20:36AM +0200, Richard Biener wrote: > > --- gcc/gcc/tree-complex.c > > +++ gcc/gcc/tree-complex.c > > @@ -1336,6 +1336,8 @@ expand_complex_division (gimple_stmt_iterator *gsi, > > tree inner_type, > >rr = gimplify_build2 (gsi, code, inner_type, ai, bi); > >

Re: RFC: A few more fallthrus

2016-08-12 Thread Richard Biener
On Thu, 11 Aug 2016, Marek Polacek wrote: > A few more cases where I'm unsure whether the fall through is intended. > Jason, can you please look at the cp/ part? > Richi, would you mind looking at the tree-complex.c bit? > What 'bout the pch.c? > > Thanks, > > 2016-08-11 Marek Polacek > >

RFC: A few more fallthrus

2016-08-11 Thread Marek Polacek
A few more cases where I'm unsure whether the fall through is intended. Jason, can you please look at the cp/ part? Richi, would you mind looking at the tree-complex.c bit? What 'bout the pch.c? Thanks, 2016-08-11 Marek Polacek PR c/7652 gcc/ * tree-complex.c (expand_complex_d