Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 10:23 AM, H.J. Lu wrote: > On Mon, Sep 24, 2018 at 9:55 AM, Jan Hubicka wrote: >>> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: >>> >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >>> >> >> >> PING. >>> >> >> > >>> >> >> > Hi, Jan Uros, >>> >> >> > >>> >> >

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 9:55 AM, Jan Hubicka wrote: >> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: >> >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >> >> >> >> PING. >> >> >> > >> >> >> > Hi, Jan Uros, >> >> >> > >> >> >> > Can you review this patch? >> >> >> >> >> >> I don't kn

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Jan Hubicka
> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: > >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: > >> >> >> PING. > >> >> > > >> >> > Hi, Jan Uros, > >> >> > > >> >> > Can you review this patch? > >> >> > >> >> I don't know CET stuff, so I'm not able to review functionality of CET

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >> >> >> PING. >> >> > >> >> > Hi, Jan Uros, >> >> > >> >> > Can you review this patch? >> >> >> >> I don't know CET stuff, so I'm not able to review functionality of CET >> >> patches. >>

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Jan Hubicka
> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: > >> >> PING. > >> > > >> > Hi, Jan Uros, > >> > > >> > Can you review this patch? > >> > >> I don't know CET stuff, so I'm not able to review functionality of CET > >> patches. > > > > My (very partial) understanding is that ENDBR is used to

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >> >> PING. >> > >> > Hi, Jan Uros, >> > >> > Can you review this patch? >> >> I don't know CET stuff, so I'm not able to review functionality of CET >> patches. > > My (very partial) understanding is that ENDBR is used to mark places where one

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Jan Hubicka
> >> PING. > > > > Hi, Jan Uros, > > > > Can you review this patch? > > I don't know CET stuff, so I'm not able to review functionality of CET > patches. My (very partial) understanding is that ENDBR is used to mark places where one can jump/call. So we need to always arrange it first. Normally

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Uros Bizjak
On Mon, Sep 24, 2018 at 4:34 PM, H.J. Lu wrote: > On Mon, Apr 2, 2018 at 5:08 AM, H.J. Lu wrote: >> On Mon, Mar 26, 2018 at 4:09 AM, H.J. Lu wrote: >>> On Fri, Jan 26, 2018 at 6:23 AM, H.J. Lu wrote: On Sun, Jan 7, 2018 at 7:11 PM, H.J. Lu wrote: > On Tue, Oct 24, 2017 at 10:58 AM, H.

PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Apr 2, 2018 at 5:08 AM, H.J. Lu wrote: > On Mon, Mar 26, 2018 at 4:09 AM, H.J. Lu wrote: >> On Fri, Jan 26, 2018 at 6:23 AM, H.J. Lu wrote: >>> On Sun, Jan 7, 2018 at 7:11 PM, H.J. Lu wrote: On Tue, Oct 24, 2017 at 10:58 AM, H.J. Lu wrote: > On Tue, Oct 24, 2017 at 10:40 AM, A