PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-20 Thread H.J. Lu
Ping. On Fri, Mar 11, 2016 at 9:09 AM, H.J. Lu wrote: > We can't set flag_pie to the default when flag_pic == 0, which may be > set by -fno-pic or -fno-PIC, since the default value of flag_pie is > non-zero when GCC is configured with --enable-default-pie. We need > to initialize flag_pic to -1

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread Bernd Schmidt
On 03/17/2016 04:06 PM, H.J. Lu wrote: This is the patch I am going to check in. That still mentions darwin which I imagine might not be an exhaustive test. Bernd

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread Bernd Schmidt
On 03/17/2016 02:59 PM, H.J. Lu wrote: On Fri, Mar 11, 2016 at 9:09 AM, H.J. Lu wrote: We can't set flag_pie to the default when flag_pic == 0, which may be set by -fno-pic or -fno-PIC, since the default value of flag_pie is non-zero when GCC is configured with --enable-default-pie. We need to

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread Bernd Schmidt
On 03/17/2016 04:13 PM, H.J. Lu wrote: On Thu, Mar 17, 2016 at 8:09 AM, Bernd Schmidt wrote: On 03/17/2016 04:06 PM, H.J. Lu wrote: This is the patch I am going to check in. That still mentions darwin which I imagine might not be an exhaustive test. We can add an effective target, somethin

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread H.J. Lu
On Thu, Mar 17, 2016 at 7:18 AM, Bernd Schmidt wrote: > On 03/17/2016 02:59 PM, H.J. Lu wrote: >> >> On Fri, Mar 11, 2016 at 9:09 AM, H.J. Lu wrote: >>> >>> We can't set flag_pie to the default when flag_pic == 0, which may be >>> set by -fno-pic or -fno-PIC, since the default value of flag_pie i

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread Bernd Schmidt
On 03/17/2016 04:26 PM, H.J. Lu wrote: On Thu, Mar 17, 2016 at 8:23 AM, Bernd Schmidt wrote: On 03/17/2016 04:13 PM, H.J. Lu wrote: We can add an effective target, something like ignore_pic_pie, and use it instead of *-*-darwin*. That should have been done _before_ committing the patch in a

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread H.J. Lu
On Thu, Mar 17, 2016 at 8:09 AM, Bernd Schmidt wrote: > On 03/17/2016 04:06 PM, H.J. Lu wrote: >> >> This is the patch I am going to check in. > > > That still mentions darwin which I imagine might not be an exhaustive test. > We can add an effective target, something like ignore_pic_pie, and use

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread H.J. Lu
On Thu, Mar 17, 2016 at 7:55 AM, H.J. Lu wrote: > On Thu, Mar 17, 2016 at 7:18 AM, Bernd Schmidt wrote: >> On 03/17/2016 02:59 PM, H.J. Lu wrote: >>> >>> On Fri, Mar 11, 2016 at 9:09 AM, H.J. Lu wrote: We can't set flag_pie to the default when flag_pic == 0, which may be set by -f

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-19 Thread H.J. Lu
On Thu, Mar 17, 2016 at 8:23 AM, Bernd Schmidt wrote: > On 03/17/2016 04:13 PM, H.J. Lu wrote: >> >> On Thu, Mar 17, 2016 at 8:09 AM, Bernd Schmidt >> wrote: >>> >>> On 03/17/2016 04:06 PM, H.J. Lu wrote: This is the patch I am going to check in. >>> >>> That still mentions darwin

Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic

2016-03-18 Thread H.J. Lu
On Thu, Mar 17, 2016 at 8:55 AM, Bernd Schmidt wrote: > On 03/17/2016 04:26 PM, H.J. Lu wrote: >> >> On Thu, Mar 17, 2016 at 8:23 AM, Bernd Schmidt >> wrote: >>> >>> On 03/17/2016 04:13 PM, H.J. Lu wrote: We can add an effective target, something like ignore_pic_pie, and use it ins