[PATCH] Add missing SLP discovery for CFN[_MASK][_LEN]_SCATTER_STORE

2024-11-08 Thread Richard Biener
This was responsible for a bunch of SVE FAILs with --param vect-force-slp=1 Bootstrap and regtest running on x86_64-unknown-linux-gnu. * tree-vect-slp.cc (arg1_arg3_map): New. (arg1_arg3_arg4_map): Likewise. (vect_get_operand_map): Handle IFN_SCATTER_STORE, IFN_MAS

[PATCH] Add missing space after seen_error in gcc/cp/pt.cc

2024-06-04 Thread Simon Martin
I realized that I committed a change with a missing space after seen_error. This fixes it, as well as another occurrence in the same file. Apologies for the mistake - I'll commit this as obvious. gcc/cp/ChangeLog: * pt.cc (tsubst_expr): Add missing space after seen_error. (depend

[PATCH] Add missing check for const_pool in the escaped solutions

2024-05-17 Thread Richard Biener
The ptr-vs-ptr compare folding using points-to info was missing a check for const_pool being included in the escaped solution. The following fixes that, fixing the observed execute FAIL of experimental/functional/searchers.cc Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.

[PATCH] Add missing hf/bf patterns.

2024-03-17 Thread liuhongt
It fixes ICE of unrecognized logic operation insn which is generated by lroundmn2 expanders. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ready push to trunk. gcc/ChangeLog: PR target/114334 * config/i386/i386.md (mode): Add new number V8BF,V16BF,V32BF. (MOD

Re: [PATCH] Add missing declaration of get_restrict in C++ interface

2023-11-09 Thread David Malcolm
On Thu, 2023-11-09 at 21:51 +0100, Guillaume Gomez wrote: > I confirm it does. I realized it when finalizing our patch for > attributes support. Excellent; thanks for the fix. Dave

Re: [PATCH] Add missing declaration of get_restrict in C++ interface

2023-11-09 Thread Guillaume Gomez
I confirm it does. I realized it when finalizing our patch for attributes support. Le jeu. 9 nov. 2023 à 21:49, David Malcolm a écrit : > > On Thu, 2023-11-09 at 21:03 +0100, Guillaume Gomez wrote: > > Hi, > > > > This patch adds the `get_restrict` method declaration for > > the C++ interface as

Re: [PATCH] Add missing declaration of get_restrict in C++ interface

2023-11-09 Thread David Malcolm
On Thu, 2023-11-09 at 21:03 +0100, Guillaume Gomez wrote: > Hi, > > This patch adds the `get_restrict` method declaration for > the C++ interface as it was forgotten. > > Thanks in advance for the review. Looking at my jit.sum results, it looks like the .cc files are indeed FAILing on initial co

[PATCH] Add missing declaration of get_restrict in C++ interface

2023-11-09 Thread Guillaume Gomez
Hi, This patch adds the `get_restrict` method declaration for the C++ interface as it was forgotten. Thanks in advance for the review. From e819fd01cd3e79bfab28a77f4ce78f34156e7a83 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Thu, 9 Nov 2023 17:53:08 +0100 Subject: [PATCH] Add missing

Re: [PATCH] Add missing return in gori_compute::logical_combine

2023-09-25 Thread Andrew MacLeod
OK for trunk at least.   Thanks.  I presume it'll be fine for the other releases. Andrew On 9/25/23 11:51, Eric Botcazou wrote: Hi, the varying case currently falls through to the 1/true case. Tested on x86_64-suse-linux, OK for mainline, 13 and 12 branches? 2023-09-25 Eric Botcazou

[PATCH] Add missing return in gori_compute::logical_combine

2023-09-25 Thread Eric Botcazou
Hi, the varying case currently falls through to the 1/true case. Tested on x86_64-suse-linux, OK for mainline, 13 and 12 branches? 2023-09-25 Eric Botcazou * gimple-range-gori.cc (gori_compute::logical_combine): Add missing return statement in the varying case. 2023-09-25

[PATCH] add missing dg-require alias to gcc.dg/torture/pr100786.c

2022-03-28 Thread Richard Biener via Gcc-patches
Pushed. 2022-03-28 Richard Biener * gcc.dg/torture/pr100786.c: Add dg-require alias. --- gcc/testsuite/gcc.dg/torture/pr100786.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/gcc.dg/torture/pr100786.c b/gcc/testsuite/gcc.dg/torture/pr100786.c index 42f4e485593..

Re: [PATCH] add missing GTY support for hash-map (PR 100463)

2021-05-24 Thread Jason Merrill via Gcc-patches
On 5/24/21 12:46 PM, Martin Sebor wrote: Instantiating a hash_map on a number of integer types including, for example, int or unsigned int (such as location_t), or HOST_WIDE_INT, and using it with the garbage collector causes many cryptic compilation errors due to incomplete support for such type

[PATCH] add missing GTY support for hash-map (PR 100463)

2021-05-24 Thread Martin Sebor via Gcc-patches
Instantiating a hash_map on a number of integer types including, for example, int or unsigned int (such as location_t), or HOST_WIDE_INT, and using it with the garbage collector causes many cryptic compilation errors due to incomplete support for such types (the PR shows a few examples). I ran in

[PATCH] Add missing changes to Makefile.tpl

2021-02-28 Thread H.J. Lu via Gcc-patches
e.in but not Makefile.tpl. so regenerating > the file causes them to be removed. can you take a look please ? > I checked in this patch as an obvious change. Thanks. -- H.J. From 1dbde357be3ce2641595b10436822e699abe32a0 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Sun, 28 Feb 2

Re: [PATCH] Add missing varasm DECL_P check.

2020-12-10 Thread Richard Sandiford via Gcc-patches
Jim Wilson writes: > This fixes a riscv64-linux bootstrap failure. > > get_constant_section calls the select_section target hook, and select_section > calls get_named_section which calls get_section. So it is possible to have > a constant not a decl in both of these functions. They already call

Re: [PATCH] Add missing varasm DECL_P check.

2020-12-09 Thread Jim Wilson
On Wed, Dec 9, 2020 at 7:14 PM H.J. Lu wrote: > A testcase? > A testcase requires the RISC-V select_section target hook, so it isn't going to be very useful. I don't see any other linux targets that have this hook defined. Just a few embedded targets. The testcase is libgfortran/generated/pr

Re: [PATCH] Add missing varasm DECL_P check.

2020-12-09 Thread H.J. Lu via Gcc-patches
On Wed, Dec 9, 2020 at 7:10 PM Jim Wilson wrote: > > This fixes a riscv64-linux bootstrap failure. > > get_constant_section calls the select_section target hook, and select_section > calls get_named_section which calls get_section. So it is possible to have > a constant not a decl in both of thes

[PATCH] Add missing varasm DECL_P check.

2020-12-09 Thread Jim Wilson
This fixes a riscv64-linux bootstrap failure. get_constant_section calls the select_section target hook, and select_section calls get_named_section which calls get_section. So it is possible to have a constant not a decl in both of these functions. They already call DECL_P checks everywhere exce

Re: [PATCH] Add missing gnu-versioned-namespace symbols

2020-11-03 Thread Jonathan Wakely via Gcc-patches
On 02/11/20 21:52 +0100, François Dumont via Libstdc++ wrote: On 02/11/20 3:17 pm, Jonathan Wakely wrote: On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote: Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the ver

Re: [PATCH] Add missing gnu-versioned-namespace symbols

2020-11-02 Thread François Dumont via Gcc-patches
On 02/11/20 3:17 pm, Jonathan Wakely wrote: On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote: Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the versioned namespace but I don't understand why we need to do it for

Re: [PATCH] Add missing gnu-versioned-namespace symbols

2020-11-02 Thread Jonathan Wakely via Gcc-patches
On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote: Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the versioned namespace but I don't understand why we need to do it for _GLIBCXX_DEBUG symbols which are not version

[PATCH] Add missing gnu-versioned-namespace symbols

2020-11-01 Thread François Dumont via Gcc-patches
Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the versioned namespace but I don't understand why we need to do it for _GLIBCXX_DEBUG symbols which are not version namespace dependant. Do you want to backport the Debug symbol

Re: [PATCH] Add Missing FSF copyright notes for some x86 intrinsic headers

2020-09-29 Thread H.J. Lu via Gcc-patches
On Mon, Sep 28, 2020 at 9:06 AM H.J. Lu wrote: > > On Mon, Sep 28, 2020 at 9:04 AM Hongyu Wang via Gcc-patches > wrote: > > > > Hi, > > > > Some x86 intrinsic headers is missing FSF copyright notes. This patch add > > the missed notes for those headers. > > > > OK for master? > > > > gcc/ChangeLo

Re: [PATCH] Add Missing FSF copyright notes for some x86 intrinsic headers

2020-09-28 Thread H.J. Lu via Gcc-patches
On Mon, Sep 28, 2020 at 9:04 AM Hongyu Wang via Gcc-patches wrote: > > Hi, > > Some x86 intrinsic headers is missing FSF copyright notes. This patch add > the missed notes for those headers. > > OK for master? > > gcc/ChangeLog: > > * config/i386/amxbf16intrin.h: Add FSF copyright notes. > * confi

[PATCH] Add Missing FSF copyright notes for some x86 intrinsic headers

2020-09-28 Thread Hongyu Wang via Gcc-patches
From: Hongyu Wang Date: Mon, 28 Sep 2020 22:22:28 + Subject: [PATCH] Add missing FSF copyright notes for x86 intrinsic headers. gcc/ChangeLog: * config/i386/amxbf16intrin.h: Add FSF copyright notes. * config/i386/amxint8intrin.h: Ditto. * config/i386/amxtileintrin.h: Ditto. * config/i386

Re: [PATCH] Add missing vn_reference_t::punned initialization

2020-08-24 Thread Richard Biener via Gcc-patches
On Thu, Aug 13, 2020 at 2:49 PM Martin Liška wrote: > > As mentioned in the PR, we miss one initialization of ::punned > in vn_reference_lookup_call. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? OK. Thanks, Richard. > Thanks, > Martin > >

[PATCH] Add missing vn_reference_t::punned initialization

2020-08-13 Thread Martin Liška
As mentioned in the PR, we miss one initialization of ::punned in vn_reference_lookup_call. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: PR tree-optimization/96597 * tree-ssa-sccvn.c (vn_reference_lo

Re: [PATCH] Add missing check for gassign.

2020-06-18 Thread Richard Biener via Gcc-patches
On Thu, Jun 18, 2020 at 9:42 AM Martin Liška wrote: > > Hi. > > We should check for gassign before doing gimple_assign_rhs_code and friends. > > Ready to be installed after proper testing? OK. > Thanks, > Martin > > gcc/ChangeLog: > > * tree-vect-generic.c (expand_vector_condition): Chec

[PATCH] Add missing check for gassign.

2020-06-18 Thread Martin Liška
Hi. We should check for gassign before doing gimple_assign_rhs_code and friends. Ready to be installed after proper testing? Thanks, Martin gcc/ChangeLog: * tree-vect-generic.c (expand_vector_condition): Check for gassign before inspecting RHS. --- gcc/tree-vect-generic.c | 5

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-10 Thread Jakub Jelinek via Gcc-patches
On Wed, Jun 10, 2020 at 01:14:59PM +0200, Martin Liška wrote: > >From 4d2e0b1e87b08ec21fd82144f00d364687030706 Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Tue, 19 May 2020 16:57:56 +0200 > Subject: [PATCH] Add missing store in emission of asan_stack_free. > > gcc

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-10 Thread Martin Liška
4d2e0b1e87b08ec21fd82144f00d364687030706 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 19 May 2020 16:57:56 +0200 Subject: [PATCH] Add missing store in emission of asan_stack_free. gcc/ChangeLog: 2020-05-19 Martin Liska PR sanitizer/94910 * asan.c (asan_emit_stack_protection)

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-10 Thread Jakub Jelinek via Gcc-patches
On Wed, Jun 10, 2020 at 11:49:01AM +0200, Martin Liška wrote: > - store_by_pieces (shadow_mem, sz, builtin_memset_read_str, &c, > - BITS_PER_UNIT, true, RETURN_BEGIN); > + { > + /* Emit: > +memset(ShadowBase, kAsanStackAfterReturnMagic, ShadowSize); >

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-10 Thread Martin Liška
t the updated patch? I must confess that RTL instruction emission is not my strength. Martin >From 16e46a532c059930887bc30f82c3054a75a5a56d Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 19 May 2020 16:57:56 +0200 Subject: [PATCH] Add missing store in emission of asan_stack_free. gcc/ChangeLo

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-10 Thread Jakub Jelinek via Gcc-patches
On Wed, Jun 10, 2020 at 10:24:59AM +0200, Martin Liška wrote: > > > This doesn't look correct to me. > > > I'd think the first adjust_address should be > > >   mem = adjust_address (mem, ptr_mode, offset); > > > which will give you a MEM with ptr_mode which has SavedFlagPtr(FakeStack) > > > add

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-10 Thread Martin Liška
On 6/1/20 3:18 PM, Martin Liška wrote: On 6/1/20 2:52 PM, Jakub Jelinek wrote: On Mon, Jun 01, 2020 at 02:28:51PM +0200, Martin Liška wrote: --- a/gcc/asan.c +++ b/gcc/asan.c @@ -1598,8 +1598,24 @@ asan_emit_stack_protection (rtx base, rtx pbase, unsigned int alignb,     if (use_after_retu

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-01 Thread Martin Liška
On 6/1/20 2:52 PM, Jakub Jelinek wrote: On Mon, Jun 01, 2020 at 02:28:51PM +0200, Martin Liška wrote: --- a/gcc/asan.c +++ b/gcc/asan.c @@ -1598,8 +1598,24 @@ asan_emit_stack_protection (rtx base, rtx pbase, unsigned int alignb, if (use_after_return_class < 5 && can_store_by_p

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-01 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 01, 2020 at 02:28:51PM +0200, Martin Liška wrote: > --- a/gcc/asan.c > +++ b/gcc/asan.c > @@ -1598,8 +1598,24 @@ asan_emit_stack_protection (rtx base, rtx pbase, > unsigned int alignb, >if (use_after_return_class < 5 > && can_store_by_pieces (sz, builtin_memset_read_str

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-06-01 Thread Martin Liška
cc0c3378cca3de1 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 19 May 2020 16:57:56 +0200 Subject: [PATCH] Add missing store in emission of asan_stack_free. gcc/ChangeLog: 2020-05-19 Martin Liska PR sanitizer/94910 * asan.c (asan_emit_stack_protection): Emit also **SavedFlagPtr(F

Re: [PATCH] Add missing expander for vector float_extend and float_truncate [PR target/95125]

2020-05-24 Thread Uros Bizjak via Gcc-patches
On Sun, May 24, 2020 at 9:20 AM Hongtao Liu wrote: > > Bootstrap is ok, regression test on i386/x86-64 backend is ok. > > gcc/ChangeLog > PR target/95125 > * config/i386/sse.md (sf2dfmode_lower): New mode attribute. > (trunc2) New expander. > (extend2): Ditto. > >

[PATCH] Add missing expander for vector float_extend and float_truncate [PR target/95125]

2020-05-24 Thread Hongtao Liu via Gcc-patches
Bootstrap is ok, regression test on i386/x86-64 backend is ok. gcc/ChangeLog PR target/95125 * config/i386/sse.md (sf2dfmode_lower): New mode attribute. (trunc2) New expander. (extend2): Ditto. gcc/testsuite/ChangeLog * gcc.target/i386/pr95125-avx.c: New

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-05-20 Thread Franz Sirl
Am 2020-05-19 um 21:05 schrieb Martin Liška: Hi. We make direct emission for asan_emit_stack_protection for smaller stacks. That's fine but we're missing the piece that marks the stack as released and we run out of pre-allocated stacks. I also included some stack-related constants that were used

[PATCH] Add missing store in emission of asan_stack_free.

2020-05-19 Thread Martin Liška
Hi. We make direct emission for asan_emit_stack_protection for smaller stacks. That's fine but we're missing the piece that marks the stack as released and we run out of pre-allocated stacks. I also included some stack-related constants that were used in asan.c. Patch can bootstrap on x86_64-lin

Re: [PATCH] add missing -Wno-stack-usage etc. options [PR90983]

2020-04-22 Thread Jeff Law via Gcc-patches
On Tue, 2020-04-21 at 13:37 -0600, Martin Sebor via Gcc-patches wrote: > In addition to accepting argument values in excess of INT_MAX in > options like -Walloca-larger-than=byte-size, GCC 9 has changed > the behavior of such options with byte-size of zero. While in prior > versions zero disables

[PATCH] add missing -Wno-stack-usage etc. options [PR90983]

2020-04-21 Thread Martin Sebor via Gcc-patches
In addition to accepting argument values in excess of INT_MAX in options like -Walloca-larger-than=byte-size, GCC 9 has changed the behavior of such options with byte-size of zero. While in prior versions zero disables the warning for any size, in GCC 9 it enables it for all non-zero sizes. Sinc

[PATCH] Add missing space in various string literals

2019-10-24 Thread Jakub Jelinek
Hi! On Thu, Oct 24, 2019 at 01:20:26PM -0400, Marek Polacek wrote: > Since r269045 we're missing a space in a diagnostic. > > Bootstrapped/regtested on x86_64-linux, applying to trunk and 9. > > 2019-10-24 Marek Polacek > > * decl.c (reshape_init_r): Add missing space. This change rem

Re: [PATCH] Add missing gimple_call_set_fntype

2019-10-04 Thread Jeff Law
On 10/4/19 7:07 AM, Martin Jambor wrote: > Hi, > > when looking for detected call argument type incompatibilities I > stumbled over a call to builtin_memcpy which originally was a call to > builtin_memset but simplify_builtin_call changed it to the former > without setting the gimple statement fnt

[PATCH] Add missing gimple_call_set_fntype

2019-10-04 Thread Martin Jambor
Hi, when looking for detected call argument type incompatibilities I stumbled over a call to builtin_memcpy which originally was a call to builtin_memset but simplify_builtin_call changed it to the former without setting the gimple statement fntype. That's probably not a big deal but since I know

Re: [PATCH] Add missing popcount simplifications (PR90693)

2019-08-22 Thread Richard Biener
On Wed, Aug 21, 2019 at 5:53 PM Jeff Law wrote: > > On 8/21/19 7:57 AM, Wilco Dijkstra wrote: > > Hi Richard, > > > >>> > >>> I think this should be in expand stage where there could be comparison > >>> of the cost of the RTLs. > >> > >> I tend to agree here, if not then for the reason the "simpli

Re: [PATCH] Add missing popcount simplifications (PR90693)

2019-08-21 Thread Jeff Law
On 8/21/19 7:57 AM, Wilco Dijkstra wrote: > Hi Richard, > >>> >>> I think this should be in expand stage where there could be comparison >>> of the cost of the RTLs. >> >> I tend to agree here, if not then for the reason the "simplified" variants >> have more GIMPLE stmts which means they are not

Re: [PATCH] Add missing popcount simplifications (PR90693)

2019-08-21 Thread Wilco Dijkstra
Hi Richard, > > > > I think this should be in expand stage where there could be comparison > > of the cost of the RTLs. > > I tend to agree here, if not then for the reason the "simplified" variants > have more GIMPLE stmts which means they are not "simpler".  In > fact I'd argue for canonicaliza

Re: [PATCH] Add missing popcount simplifications (PR90693)

2019-08-14 Thread Richard Biener
On Tue, Aug 13, 2019 at 6:47 PM Andrew Pinski wrote: > > On Tue, Aug 13, 2019 at 8:50 AM Wilco Dijkstra wrote: > > > > Add simplifications for popcount (x) > 1 to (x & (x-1)) != 0 and > > popcount (x) == 1 into (x-1) > single-use cases and support an optional convert. A microbenchmark > > shows

Re: [PATCH] Add missing popcount simplifications (PR90693)

2019-08-13 Thread Andrew Pinski
On Tue, Aug 13, 2019 at 8:50 AM Wilco Dijkstra wrote: > > Add simplifications for popcount (x) > 1 to (x & (x-1)) != 0 and > popcount (x) == 1 into (x-1) single-use cases and support an optional convert. A microbenchmark > shows a speedup of 2-2.5x on both x64 and AArch64. > > Bootstrap OK, OK f

Re: [PATCH] Add missing popcount simplifications (PR90693)

2019-08-13 Thread Marc Glisse
On Tue, 13 Aug 2019, Wilco Dijkstra wrote: Add simplifications for popcount (x) > 1 to (x & (x-1)) != 0 and popcount (x) == 1 into (x-1) Is that true even on targets that have a popcount instruction? (-mpopcnt for x64) diff --git a/gcc/match.pd b/gcc/match.pd index 0317bc704f771f626ab7218

[PATCH] Add missing popcount simplifications (PR90693)

2019-08-13 Thread Wilco Dijkstra
Add simplifications for popcount (x) > 1 to (x & (x-1)) != 0 and popcount (x) == 1 into (x-1) gcc/ PR middle-end/90693 * match.pd: Add popcount simplifications. testsuite/ PR middle-end/90693 * gcc.dg/fold-popcount-5.c: Add new test. --- diff --git a/gcc/match.p

Re: [PATCH] Add missing _mm{256,512}_zext* intrinsics (PRs target/83250, target/91340)

2019-08-12 Thread Uros Bizjak
On Mon, Aug 12, 2019 at 4:57 PM Jakub Jelinek wrote: > > Hi! > > The following patch adds 9 missing intrinsics, which are like _mm*_cast*, > but don't leave the upper bits undefined - set them to zero instead. > The implementation uses code that combine manages to optimize well, > the only problem

[PATCH] Add missing _mm{256,512}_zext* intrinsics (PRs target/83250, target/91340)

2019-08-12 Thread Jakub Jelinek
Hi! The following patch adds 9 missing intrinsics, which are like _mm*_cast*, but don't leave the upper bits undefined - set them to zero instead. The implementation uses code that combine manages to optimize well, the only problem is that as the 512-bit intrinsics are supposed to be avx512f and s

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-07 Thread Jeff Law
On 6/3/19 5:06 AM, Jakub Jelinek wrote: > On Mon, Jun 03, 2019 at 06:01:40PM +0800, Hongtao Liu wrote: >> The following patch adds forgotten avx512f fpclass instrinsics for >> masked scalar operations. >> >> Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), >> ok for trun

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-04 Thread Hongtao Liu
On Tue, Jun 4, 2019 at 5:56 PM Hongtao Liu wrote: > > On Tue, Jun 4, 2019 at 5:21 PM Jakub Jelinek wrote: > > > > On Tue, Jun 04, 2019 at 05:00:05PM +0800, Hongtao Liu wrote: > > > Thanks for reminding, Here is updated: > > > > You've missed some notes. Ok for trunk with: > > 1) the following pa

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-04 Thread Hongtao Liu
On Tue, Jun 4, 2019 at 5:21 PM Jakub Jelinek wrote: > > On Tue, Jun 04, 2019 at 05:00:05PM +0800, Hongtao Liu wrote: > > Thanks for reminding, Here is updated: > > You've missed some notes. Ok for trunk with: > 1) the following patch applied on top of your patch > 2) the ChangeLog entries moved t

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-04 Thread Jakub Jelinek
On Tue, Jun 04, 2019 at 05:00:05PM +0800, Hongtao Liu wrote: > Thanks for reminding, Here is updated: You've missed some notes. Ok for trunk with: 1) the following patch applied on top of your patch 2) the ChangeLog entries moved to the start of the ChangeLog (normally, ChangeLog entries are n

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-04 Thread Hongtao Liu
On Tue, Jun 4, 2019 at 3:59 PM Jakub Jelinek wrote: > > On Tue, Jun 04, 2019 at 03:38:08PM +0800, Hongtao Liu wrote: > > --- gcc/ChangeLog (revision 271853) > > +++ gcc/ChangeLog (working copy) > > @@ -4706,6 +4706,26 @@ > > reprocessing. Always call df_analyze before fixing up debu

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-04 Thread Jakub Jelinek
On Tue, Jun 04, 2019 at 03:38:08PM +0800, Hongtao Liu wrote: > --- gcc/ChangeLog (revision 271853) > +++ gcc/ChangeLog (working copy) > @@ -4706,6 +4706,26 @@ > reprocessing. Always call df_analyze before fixing up debug bind > insns. > > +2019-03-24 Hongtao Liu name

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-04 Thread Hongtao Liu
On Mon, Jun 3, 2019 at 7:06 PM Jakub Jelinek wrote: > > On Mon, Jun 03, 2019 at 06:01:40PM +0800, Hongtao Liu wrote: > > The following patch adds forgotten avx512f fpclass instrinsics for > > masked scalar operations. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx5

Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-03 Thread Jakub Jelinek
On Mon, Jun 03, 2019 at 06:01:40PM +0800, Hongtao Liu wrote: > The following patch adds forgotten avx512f fpclass instrinsics for > masked scalar operations. > > Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), > ok for trunk? > > Changelog: > > gcc/ > +2019-03-24 Hon

[PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-06-03 Thread Hongtao Liu
Hi Jeff: The following patch adds forgotten avx512f fpclass instrinsics for masked scalar operations. Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), ok for trunk? Changelog: gcc/ +2019-03-24 Hongtao Liu + + PR target/89803 + * config/i386/avx512dqintrin.h + (_mm_ma

[PATCH] Add missing feature test macro to C++17 status table

2019-05-23 Thread Jonathan Wakely
* doc/xml/manual/status_cxx2017.xml: Add feature test macro for P0040R3. * doc/html/*: Regenerate. Committed to trunk. commit f58762124c374887a5785a6f4a812af64fe5b2f1 Author: Jonathan Wakely Date: Thu May 23 17:00:37 2019 +0100 Add missing feature test macro to C

[PATCH] Add missing piece of P0777R1 and update C++20 status docs

2019-05-17 Thread Jonathan Wakely
* doc/xml/manual/status_cxx2020.xml: Update P0608R3, P0777R1, and P1165R1 entries. * doc/html/*: Regenerate. * include/std/tuple (make_from_tuple): Use remove_reference_t instead of decay_t (P0777R1). Tested powerpc64le-linux, committed to trunk. commit 8

Re: [PATCH] Add missing target options (PR middle-end/90258).

2019-04-26 Thread Martin Liška
On 4/26/19 5:24 PM, Jeff Law wrote: On 4/26/19 5:02 AM, Martin Liška wrote: Hi. The fix is about forgotten target options for which get_valid_option_values returns empty list. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed to trunk and later than

Re: [PATCH] Add missing target options (PR middle-end/90258).

2019-04-26 Thread Jeff Law
On 4/26/19 5:02 AM, Martin Liška wrote: > Hi. > > The fix is about forgotten target options for which get_valid_option_values > returns empty list. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed to trunk and later than to gcc-9 branch? > Than

[PATCH] Add missing target options (PR middle-end/90258).

2019-04-26 Thread Martin Liška
Hi. The fix is about forgotten target options for which get_valid_option_values returns empty list. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed to trunk and later than to gcc-9 branch? Thanks, Martin gcc/ChangeLog: 2019-04-26 Martin Liska

Re: [PATCH] Add missing libsanitizer extra patch (r259664) (PR sanitizer/89941).

2019-04-08 Thread Jakub Jelinek
On Wed, Apr 03, 2019 at 10:09:19AM +0200, Martin Liška wrote: > Hi. > > The patch is about re-application of what we've already had > on top trunk libsanitizer. I'll then include the patch in > libsanitizer/LOCAL_PATCHES. > > Ready for trunk? > Thanks, > Martin > > libsanitizer/ChangeLog: > >

[PATCH] Add missing libsanitizer extra patch (r259664) (PR sanitizer/89941).

2019-04-03 Thread Martin Liška
Hi. The patch is about re-application of what we've already had on top trunk libsanitizer. I'll then include the patch in libsanitizer/LOCAL_PATCHES. Ready for trunk? Thanks, Martin libsanitizer/ChangeLog: 2019-04-03 Martin Liska PR sanitizer/89941 * sanitizer_common/saniti

Re: Ping Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

2019-03-29 Thread Hongtao Liu
On Sat, Mar 30, 2019 at 5:34 AM Jeff Law wrote: > > On 3/28/19 1:38 AM, Uros Bizjak wrote: > > On Thu, Mar 28, 2019 at 7:47 AM Hongtao Liu wrote: > >> > >> Hi Uros: > >> would you help to review this patch? > > > > This is AVX512F patch, you will need the approval from the maintainer > > first.

Re: Ping Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/897803)

2019-03-29 Thread Jeff Law
On 3/28/19 1:38 AM, Uros Bizjak wrote: > On Thu, Mar 28, 2019 at 7:47 AM Hongtao Liu wrote: >> >> Hi Uros: >> would you help to review this patch? > > This is AVX512F patch, you will need the approval from the maintainer > first. I have no plans to maintain AVX512 beyond rubber-stamping OK > de

Re: Ping Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/897803)

2019-03-28 Thread Uros Bizjak
On Thu, Mar 28, 2019 at 7:47 AM Hongtao Liu wrote: > > Hi Uros: > would you help to review this patch? This is AVX512F patch, you will need the approval from the maintainer first. I have no plans to maintain AVX512 beyond rubber-stamping OK dead obvious regression from a reputable contributors.

Ping Re: [PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/897803)

2019-03-27 Thread Hongtao Liu
Hi Uros: would you help to review this patch? Regards, Hongtao. On Sun, Mar 24, 2019 at 8:13 PM Hongtao Liu wrote: > > Hi: > The following patch adds forgotten avx512f fpclass instrinsics for > masked scalar operations. > > Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-av

[PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/897803)

2019-03-24 Thread Hongtao Liu
Hi: The following patch adds forgotten avx512f fpclass instrinsics for masked scalar operations. Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), ok for trunk? Index: ChangeLog === --- ChangeLog (revision

Re: [PATCH] Add missing avx512fintrin.h _mm_mask{,3,z}_f{,n}m{add,sub}_s{s,d} intrinsics (PR target/89784)

2019-03-22 Thread Uros Bizjak
On Fri, Mar 22, 2019 at 11:40 AM Jakub Jelinek wrote: > > On Fri, Mar 22, 2019 at 11:11:58AM +0100, Uros Bizjak wrote: > > > For FMA, naturally only the two operands that are multiplied should be > > > commutative, but in most patterns one of those two uses "0" or "0,0" > > > > This should be safe

Re: [PATCH] Add missing avx512fintrin.h _mm_mask{,3,z}_f{,n}m{add,sub}_s{s,d} intrinsics (PR target/89784)

2019-03-22 Thread Jakub Jelinek
On Fri, Mar 22, 2019 at 11:11:58AM +0100, Uros Bizjak wrote: > > For FMA, naturally only the two operands that are multiplied should be > > commutative, but in most patterns one of those two uses "0" or "0,0" > > This should be safe, we have had "*add_1" for decades that does > just the above. Su

Re: [PATCH] Add missing avx512fintrin.h _mm_mask{,3,z}_f{,n}m{add,sub}_s{s,d} intrinsics (PR target/89784)

2019-03-22 Thread Uros Bizjak
On Fri, Mar 22, 2019 at 11:02 AM Jakub Jelinek wrote: > > On Fri, Mar 22, 2019 at 10:35:45AM +0100, Uros Bizjak wrote: > > On Fri, Mar 22, 2019 at 9:41 AM Jakub Jelinek wrote: > > > The following patch adds forgotten avx512f fma instrinsics for masked > > > scalar > > > operations. > > > > > > B

Re: [PATCH] Add missing avx512fintrin.h _mm_mask{,3,z}_f{,n}m{add,sub}_s{s,d} intrinsics (PR target/89784)

2019-03-22 Thread Jakub Jelinek
On Fri, Mar 22, 2019 at 10:35:45AM +0100, Uros Bizjak wrote: > On Fri, Mar 22, 2019 at 9:41 AM Jakub Jelinek wrote: > > The following patch adds forgotten avx512f fma instrinsics for masked scalar > > operations. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), >

Re: [PATCH] Add missing avx512fintrin.h _mm_mask{,3,z}_f{,n}m{add,sub}_s{s,d} intrinsics (PR target/89784)

2019-03-22 Thread Uros Bizjak
On Fri, Mar 22, 2019 at 9:41 AM Jakub Jelinek wrote: > > Hi! > > The following patch adds forgotten avx512f fma instrinsics for masked scalar > operations. > > Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), > ok for trunk? There are several possibilities to mark the 1s

[PATCH] Add missing avx512fintrin.h _mm_mask{,3,z}_f{,n}m{add,sub}_s{s,d} intrinsics (PR target/89784)

2019-03-22 Thread Jakub Jelinek
Hi! The following patch adds forgotten avx512f fma instrinsics for masked scalar operations. Bootstrapped/regtested on x86_64-linux and i686-linux (on skylake-avx512), ok for trunk? 2019-03-22 Jakub Jelinek PR target/89784 * config/i386/i386.c (enum ix86_builtins): Remove

Re: [PATCH] Add missing avx512fintrin.h intrinsics (PR target/89602)

2019-03-08 Thread H.J. Lu
On Thu, Mar 7, 2019 at 4:09 PM Jakub Jelinek wrote: > > On Thu, Mar 07, 2019 at 08:11:53AM +0100, Uros Bizjak wrote: > > > +(define_insn "*avx512f_load_mask" > > > + [(set (match_operand: 0 "register_operand" "=v") > > > + (vec_merge: > > > + (vec_merge: > > > + (vec_dupli

Re: [PATCH] Add missing avx512fintrin.h intrinsics (PR target/89602)

2019-03-07 Thread H.J. Lu
Looks good to me. Thanks. On Thu, Mar 7, 2019, 4:15 PM Uros Bizjak wrote: > On Thu, Mar 7, 2019 at 9:09 AM Jakub Jelinek wrote: > > > > On Thu, Mar 07, 2019 at 08:11:53AM +0100, Uros Bizjak wrote: > > > > +(define_insn "*avx512f_load_mask" > > > > + [(set (match_operand: 0 "register_operand"

Re: [PATCH] Add missing avx512fintrin.h intrinsics (PR target/89602)

2019-03-07 Thread Uros Bizjak
On Thu, Mar 7, 2019 at 9:09 AM Jakub Jelinek wrote: > > On Thu, Mar 07, 2019 at 08:11:53AM +0100, Uros Bizjak wrote: > > > +(define_insn "*avx512f_load_mask" > > > + [(set (match_operand: 0 "register_operand" "=v") > > > + (vec_merge: > > > + (vec_merge: > > > + (vec_dupli

Re: [PATCH] Add missing avx512fintrin.h intrinsics (PR target/89602)

2019-03-07 Thread Jakub Jelinek
On Thu, Mar 07, 2019 at 08:11:53AM +0100, Uros Bizjak wrote: > > +(define_insn "*avx512f_load_mask" > > + [(set (match_operand: 0 "register_operand" "=v") > > + (vec_merge: > > + (vec_merge: > > + (vec_duplicate: > > + (match_operand:MODEF 1 "memory_operand" "m"

Re: [PATCH] Add missing avx512fintrin.h intrinsics (PR target/89602)

2019-03-06 Thread Uros Bizjak
On Thu, Mar 7, 2019 at 12:49 AM Jakub Jelinek wrote: > > Hi! > > The following patch adds vmovss/vmovsd masked intrinsics. > On > #include > __m128 f1 (__m128 w, __mmask8 u, const float *p) { return _mm_mask_load_ss > (w, u, p); } > __m128 f2 (__mmask8 u, const float *p) { return _mm_maskz_load_

[PATCH] Add missing avx512fintrin.h intrinsics (PR target/89602)

2019-03-06 Thread Jakub Jelinek
Hi! The following patch adds vmovss/vmovsd masked intrinsics. On #include __m128 f1 (__m128 w, __mmask8 u, const float *p) { return _mm_mask_load_ss (w, u, p); } __m128 f2 (__mmask8 u, const float *p) { return _mm_maskz_load_ss (u, p); } __m128d f3 (__m128d w, __mmask8 u, const double *p) { retu

[PATCH] Add missing exports for symbols used by directory iterators

2019-01-28 Thread Jonathan Wakely
* config/abi/pre/gnu.ver (GLIBCXX_3.4.26): Add missing exports for __shared_ptr instantiations used by gcc4-compatible ABI. Tested x86_64-linux, committed to trunk. commit b50b2bf26eef0e87014c19991bebfa9b75c2b754 Author: Jonathan Wakely Date: Tue Jan 29 00:19:59 2019 +

Re: [PATCH] Add missing noexpect causes in tuple for move functions

2018-11-30 Thread nick
On 2018-11-30 6:12 p.m., Ville Voutilainen wrote: > On Sat, 1 Dec 2018 at 01:05, Nicholas Krause wrote: >> >> This adds the remainging noexcept causes required for this cause >> to meet the spec as dicussed last year and documented here: >> http://cplusplus.github.io/LWG/lwg-active.html#2899. >

Re: [PATCH] Add missing noexpect causes in tuple for move functions

2018-11-30 Thread Ville Voutilainen
On Sat, 1 Dec 2018 at 01:05, Nicholas Krause wrote: > > This adds the remainging noexcept causes required for this cause > to meet the spec as dicussed last year and documented here: > http://cplusplus.github.io/LWG/lwg-active.html#2899. I don't see how this change is sufficient; the noexcept-spe

[PATCH] Add missing noexpect causes in tuple for move functions

2018-11-30 Thread Nicholas Krause
This adds the remainging noexcept causes required for this cause to meet the spec as dicussed last year and documented here: http://cplusplus.github.io/LWG/lwg-active.html#2899. Signed-off-by: Nicholas Krause --- libstdc++-v3/include/std/tuple | 4 1 file changed, 4 insertions(+) diff --gi

Re: [PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o

2018-11-14 Thread David Malcolm
On Wed, 2018-11-14 at 09:49 +, Kyrill Tkachov wrote: > On 13/11/18 18:45, David Malcolm wrote: > > On Tue, 2018-11-13 at 17:58 +, Kyrill Tkachov wrote: > > > Hi David, > > > > > > On 09/11/18 21:00, Jeff Law wrote: > > > > On 11/9/18 10:51 AM, David Malcolm wrote: > > > > > One of the conc

[PATCH] Add missing dir to create_testsuite_files script

2018-11-14 Thread Jonathan Wakely
* scripts/create_testsuite_files: Add special_functions to the list of directories to search. Add comment referring to conformance.exp. * testsuite/libstdc++-dg/conformance.exp: Add comment referring to create_testsuite_files. Committed to trunk. commit de90993957

Re: [PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o

2018-11-14 Thread Kyrill Tkachov
On 13/11/18 18:45, David Malcolm wrote: On Tue, 2018-11-13 at 17:58 +, Kyrill Tkachov wrote: Hi David, On 09/11/18 21:00, Jeff Law wrote: On 11/9/18 10:51 AM, David Malcolm wrote: One of the concerns noted at Cauldron about -fsave-optimization- record was the size of the output files.

[PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o

2018-11-13 Thread David Malcolm
On Tue, 2018-11-13 at 17:58 +, Kyrill Tkachov wrote: > Hi David, > > On 09/11/18 21:00, Jeff Law wrote: > > On 11/9/18 10:51 AM, David Malcolm wrote: > > > One of the concerns noted at Cauldron about -fsave-optimization- > > > record > > > was the size of the output files. > > > > > > This fi

[PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o

2018-11-13 Thread David Malcolm
On Tue, 2018-11-13 at 17:58 +, Kyrill Tkachov wrote: > Hi David, > > On 09/11/18 21:00, Jeff Law wrote: > > On 11/9/18 10:51 AM, David Malcolm wrote: > > > One of the concerns noted at Cauldron about -fsave-optimization- > > > record > > > was the size of the output files. > > > > > > This fi

Re: [PATCH] add missing @opindex to Warning Options

2018-06-11 Thread Martin Sebor
On 06/11/2018 01:20 PM, Jeff Law wrote: On 06/07/2018 09:21 PM, Eric Gallager wrote: On 6/7/18, Martin Sebor wrote: A bunch of warning options are missing an @opindex entry, usually for the negative form. I went through them all and added them where it made sense. Unless there are objections

Re: [PATCH] add missing @opindex to Warning Options

2018-06-11 Thread Jeff Law
On 06/07/2018 09:21 PM, Eric Gallager wrote: > On 6/7/18, Martin Sebor wrote: >> A bunch of warning options are missing an @opindex entry, >> usually for the negative form. I went through them all >> and added them where it made sense. >> >> Unless there are objections I will commit the patch to

  1   2   3   >