On 4/26/19 5:24 PM, Jeff Law wrote:
On 4/26/19 5:02 AM, Martin Liška wrote:
Hi.
The fix is about forgotten target options for which get_valid_option_values
returns empty list.
Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
Ready to be installed to trunk and later than to gcc-9 branch?
Thanks,
Martin
gcc/ChangeLog:
2019-04-26 Martin Liska <mli...@suse.cz>
PR middle-end/90258
* opt-suggestions.c (option_proposer::build_option_suggestions):
When get_valid_option_values returns empty values, add the
misspelling candidate.
gcc/testsuite/ChangeLog:
2019-04-26 Martin Liska <mli...@suse.cz>
PR middle-end/90258
* gcc.dg/completion-5.c: New test.
* gcc.target/i386/spellcheck-options-5.c: New test.
OK for the trunk. Your call on when to cherry-pick it onto the gcc-9
branch.
Jeff
Thank you for review, installed as r270622 to trunk.
I would like to see the patch in GCC 9.1. What's release managers opinion?
Thanks,
Martin
