Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi! On Wed, 29 Apr 2015 17:28:54 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 05:25:39PM +0200, Thomas Schwinge wrote: > > Done. (I also reverted the gcc/cp/pt.c:tsubst_expr change which > > motivated this patch; will include that with the patch adding support for > > C++ templates usag

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 16:36:24 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 04:31:32PM +0200, Thomas Schwinge wrote: > > > So yes, I really prefer OMP_STANDALONE_CLAUSES over OMP_CLAUSES for > > > everything. > > > > Like this (for trunk)? > > > > commit 300e28fce192cb56d73cb61

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 05:25:39PM +0200, Thomas Schwinge wrote: > Done. (I also reverted the gcc/cp/pt.c:tsubst_expr change which > motivated this patch; will include that with the patch adding support for > C++ templates usage with OpenACC directives.) OK for trunk? Ok, thanks. Jakub

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 04:31:32PM +0200, Thomas Schwinge wrote: > > So yes, I really prefer OMP_STANDALONE_CLAUSES over OMP_CLAUSES for > > everything. > > Like this (for trunk)? > > commit 300e28fce192cb56d73cb61f787872643030f0bf > Author: Thomas Schwinge > Date: Wed Apr 29 16:18:49 2015 +02

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 13:43:55 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 01:13:29PM +0200, Thomas Schwinge wrote: > > On Wed, 29 Apr 2015 11:32:31 +0200, Jakub Jelinek wrote: > > > Yeah, it is a non-starter, it has unnecessary runtime overhead everywhere > > > where it is use

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 01:13:29PM +0200, Thomas Schwinge wrote: > On Wed, 29 Apr 2015 11:32:31 +0200, Jakub Jelinek wrote: > > Yeah, it is a non-starter, it has unnecessary runtime overhead everywhere > > where it is used. > > Huh. OMP_CLAUSES is currently used in a dozen places in > cp/cp-gimp

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi! On Wed, 29 Apr 2015 11:32:31 +0200, Jakub Jelinek wrote: > Yeah, it is a non-starter, it has unnecessary runtime overhead everywhere > where it is used. Huh. OMP_CLAUSES is currently used in a dozen places in cp/cp-gimplify.c, cp/pt.c, and gimplify.c. I've been expecting my changed code to

Re: OMP_CLAUSES with clauses in operand 0 (was: Fix OpenMP's target update directive in templated code)

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 11:28:55AM +0200, Thomas Schwinge wrote: > Yet, if that's a non-starter, I'll pursue this one: Yeah, it is a non-starter, it has unnecessary runtime overhead everywhere where it is used. Jakub

OMP_CLAUSES with clauses in operand 0 (was: Fix OpenMP's target update directive in templated code)

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 10:53:32 +0200, Jakub Jelinek wrote: > On Tue, Apr 28, 2015 at 08:45:50PM +0200, Thomas Schwinge wrote: > > That said, what is the preferred approach to add support for > > OACC_ENTER_DATA, OACC_EXIT_DATA, OACC_UPDATE? I'm not sure hard-coding > > TREE_OPERAND (t, 0