Hi! On Wed, 29 Apr 2015 17:28:54 +0200, Jakub Jelinek <ja...@redhat.com> wrote: > On Wed, Apr 29, 2015 at 05:25:39PM +0200, Thomas Schwinge wrote: > > Done. (I also reverted the gcc/cp/pt.c:tsubst_expr change which > > motivated this patch; will include that with the patch adding support for > > C++ templates usage with OpenACC directives.) OK for trunk? > > Ok, thanks.
Committed in r222580: commit 95cfd3918aef02196f24de30a1e7cbd34e45e827 Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> Date: Wed Apr 29 15:44:41 2015 +0000 Add OMP_STANDALONE_CLAUSES. gcc/ * tree.h (OMP_STANDALONE_CLAUSES): New macro. * gimplify.c (gimplify_omp_workshare): Use it. gcc/c/ * c-parser.c (c_parser_oacc_enter_exit_data): Use OMP_STANDALONE_CLAUSES. gcc/cp/ * parser.c (cp_parser_oacc_enter_exit_data): Use OMP_STANDALONE_CLAUSES. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@222580 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 5 +++++ gcc/c/ChangeLog | 5 +++++ gcc/c/c-parser.c | 5 +---- gcc/cp/ChangeLog | 5 +++++ gcc/cp/parser.c | 5 +---- gcc/gimplify.c | 13 +++++-------- gcc/tree.h | 6 ++++++ 7 files changed, 28 insertions(+), 16 deletions(-) diff --git gcc/ChangeLog gcc/ChangeLog index 4fb5490..11cb62a 100644 --- gcc/ChangeLog +++ gcc/ChangeLog @@ -1,3 +1,8 @@ +2015-04-29 Thomas Schwinge <tho...@codesourcery.com> + + * tree.h (OMP_STANDALONE_CLAUSES): New macro. + * gimplify.c (gimplify_omp_workshare): Use it. + 2015-04-29 Richard Sandiford <richard.sandif...@arm.com> * Makefile.in (build/genrecog.o): Depend on inchash.h. diff --git gcc/c/ChangeLog gcc/c/ChangeLog index 9c769ca..6d8dbb1 100644 --- gcc/c/ChangeLog +++ gcc/c/ChangeLog @@ -1,3 +1,8 @@ +2015-04-29 Thomas Schwinge <tho...@codesourcery.com> + + * c-parser.c (c_parser_oacc_enter_exit_data): Use + OMP_STANDALONE_CLAUSES. + 2015-04-28 Marek Polacek <pola...@redhat.com> * c-parser.c (c_parser_binary_expression): Remove duplicate line. diff --git gcc/c/c-parser.c gcc/c/c-parser.c index cc8a4e3..bf0e4c57 100644 --- gcc/c/c-parser.c +++ gcc/c/c-parser.c @@ -12154,10 +12154,7 @@ c_parser_oacc_enter_exit_data (c_parser *parser, bool enter) stmt = enter ? make_node (OACC_ENTER_DATA) : make_node (OACC_EXIT_DATA); TREE_TYPE (stmt) = void_type_node; - if (enter) - OACC_ENTER_DATA_CLAUSES (stmt) = clauses; - else - OACC_EXIT_DATA_CLAUSES (stmt) = clauses; + OMP_STANDALONE_CLAUSES (stmt) = clauses; SET_EXPR_LOCATION (stmt, loc); add_stmt (stmt); } diff --git gcc/cp/ChangeLog gcc/cp/ChangeLog index 3ee050c..9442faa 100644 --- gcc/cp/ChangeLog +++ gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2015-04-29 Thomas Schwinge <tho...@codesourcery.com> + + * parser.c (cp_parser_oacc_enter_exit_data): Use + OMP_STANDALONE_CLAUSES. + 2015-04-29 Paolo Carlini <paolo.carl...@oracle.com> PR c++/64667 diff --git gcc/cp/parser.c gcc/cp/parser.c index 4ea2ca2..cfb512b 100644 --- gcc/cp/parser.c +++ gcc/cp/parser.c @@ -31606,10 +31606,7 @@ cp_parser_oacc_enter_exit_data (cp_parser *parser, cp_token *pragma_tok, stmt = enter ? make_node (OACC_ENTER_DATA) : make_node (OACC_EXIT_DATA); TREE_TYPE (stmt) = void_type_node; - if (enter) - OACC_ENTER_DATA_CLAUSES (stmt) = clauses; - else - OACC_EXIT_DATA_CLAUSES (stmt) = clauses; + OMP_STANDALONE_CLAUSES (stmt) = clauses; SET_EXPR_LOCATION (stmt, pragma_tok->location); add_stmt (stmt); return stmt; diff --git gcc/gimplify.c gcc/gimplify.c index 1d5341e..9ce3dd9 100644 --- gcc/gimplify.c +++ gcc/gimplify.c @@ -7411,34 +7411,31 @@ gimplify_omp_workshare (tree *expr_p, gimple_seq *pre_p) static void gimplify_omp_target_update (tree *expr_p, gimple_seq *pre_p) { - tree expr = *expr_p, clauses; + tree expr = *expr_p; int kind; gomp_target *stmt; switch (TREE_CODE (expr)) { case OACC_ENTER_DATA: - clauses = OACC_ENTER_DATA_CLAUSES (expr); kind = GF_OMP_TARGET_KIND_OACC_ENTER_EXIT_DATA; break; case OACC_EXIT_DATA: - clauses = OACC_EXIT_DATA_CLAUSES (expr); kind = GF_OMP_TARGET_KIND_OACC_ENTER_EXIT_DATA; break; case OACC_UPDATE: - clauses = OACC_UPDATE_CLAUSES (expr); kind = GF_OMP_TARGET_KIND_OACC_UPDATE; break; case OMP_TARGET_UPDATE: - clauses = OMP_TARGET_UPDATE_CLAUSES (expr); kind = GF_OMP_TARGET_KIND_UPDATE; break; default: gcc_unreachable (); } - gimplify_scan_omp_clauses (&clauses, pre_p, ORT_WORKSHARE); - gimplify_adjust_omp_clauses (pre_p, &clauses); - stmt = gimple_build_omp_target (NULL, kind, clauses); + gimplify_scan_omp_clauses (&OMP_STANDALONE_CLAUSES (expr), pre_p, + ORT_WORKSHARE); + gimplify_adjust_omp_clauses (pre_p, &OMP_STANDALONE_CLAUSES (expr)); + stmt = gimple_build_omp_target (NULL, kind, OMP_STANDALONE_CLAUSES (expr)); gimplify_seq_add_stmt (pre_p, stmt); *expr_p = NULL_TREE; diff --git gcc/tree.h gcc/tree.h index 2ec9708..e17bd9b 100644 --- gcc/tree.h +++ gcc/tree.h @@ -1197,11 +1197,17 @@ extern void protected_set_expr_location (tree, location_t); /* OpenMP and OpenACC directive and clause accessors. */ +/* Generic accessors for OMP nodes that keep the body as operand 0, and clauses + as operand 1. */ #define OMP_BODY(NODE) \ TREE_OPERAND (TREE_RANGE_CHECK (NODE, OACC_PARALLEL, OMP_CRITICAL), 0) #define OMP_CLAUSES(NODE) \ TREE_OPERAND (TREE_RANGE_CHECK (NODE, OACC_PARALLEL, OMP_SINGLE), 1) +/* Generic accessors for OMP nodes that keep clauses as operand 0. */ +#define OMP_STANDALONE_CLAUSES(NODE) \ + TREE_OPERAND (TREE_RANGE_CHECK (NODE, OACC_CACHE, OMP_TARGET_UPDATE), 0) + #define OACC_PARALLEL_BODY(NODE) \ TREE_OPERAND (OACC_PARALLEL_CHECK (NODE), 0) #define OACC_PARALLEL_CLAUSES(NODE) \ Grüße, Thomas
pgpyYy0qrJ8n4.pgp
Description: PGP signature