[COMMITTED 10/38] ada: Minor tweaks in comments

2024-11-04 Thread Marc Poulhiès
From: Eric Botcazou They are related to the special support for text encoding on Windows. gcc/ada/ChangeLog: * adaint.c: Replace initialize.c with rtinit.c in comment. * sysdep.c (__gnat_set_mode): Fix reference in comment. * libgnat/i-cstrea.ads (Content_Encoding): Adju

[COMMITTED 05/16] ada: Minor tweaks to processing of Aggregate aspect

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou The main one is to give the error for Aggregate applied to array types from Analyze_Aspects_At_Freeze_Point instead of Check_Aspect_At_Freeze_Point, as for the other aspects. The message is also changed to be more direct. gcc/ada/ * aspects.ads (Operational_Aspect):

Re: [PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Eric Botcazou
> OK. Consider waiting to commit though as we want to make it easy to > cherry pick patches over to the release branch if needed. Sure. There are a couple more changes on top of it, but all can wait a bit. -- Eric Botcazou

Re: [PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Jeff Law
On 4/29/24 1:14 AM, Eric Botcazou wrote: Hi, this removes the last parameter of choose_multiplier, which is unused, adds another assertion and more details to the description and various comments. Likewise to the closely related invert_mod2n, except for the last parameter. Tested on x86-64/L

[PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Eric Botcazou
Hi, this removes the last parameter of choose_multiplier, which is unused, adds another assertion and more details to the description and various comments. Likewise to the closely related invert_mod2n, except for the last parameter. Tested on x86-64/Linux, OK for the mainline? 2024-04-29 Eric

[COMMITTED] ada: Minor tweaks for comparison operators

2023-11-07 Thread Marc Poulhiès
From: Eric Botcazou No functional changes. gcc/ada/ * gen_il-gen-gen_nodes.adb (N_Op_Boolean): Fix description. * sem_ch4.adb (Analyze_Comparison_Equality_Op): Tidy up. * sem_ch12.adb (Copy_Generic_Node): Use N_Op_Compare subtype. Tested on x86_64-pc-linux-gnu, committe

[COMMITTED] ada: Minor tweaks

2023-06-20 Thread Marc Poulhiès via Gcc-patches
From: Eric Botcazou gcc/ada/ * gcc-interface/decl.cc (gnat_to_gnu_entity) : Pass the NULL_TREE explicitly and test imported_p in lieu of Is_Imported. : Remove public_flag local variable and make extern_flag local variable a constant. Tested on x86_64-pc-linux-gnu

Re: [x86_64 PATCH] Two minor tweaks to ix86_expand_move.

2023-06-17 Thread Uros Bizjak via Gcc-patches
On Fri, Jun 16, 2023 at 6:27 PM Roger Sayle wrote: > > > This patch splits out two (independent) minor changes to i386-expand.cc's > ix86_expand_move from a larger patch, given that it's better to review > and commit these independent pieces separately from a more complex patch. > > The first chan

[x86_64 PATCH] Two minor tweaks to ix86_expand_move.

2023-06-16 Thread Roger Sayle
This patch splits out two (independent) minor changes to i386-expand.cc's ix86_expand_move from a larger patch, given that it's better to review and commit these independent pieces separately from a more complex patch. The first change is to test for CONST_WIDE_INT_P before calling ix86_convert_c

[pushed] wwwdocs: gcc-10: Minor tweaks to the OpenACC/OpenMP section

2023-03-11 Thread Gerald Pfeifer
I looked at this older release notes "by chance" and notice some minor editorial changes. Pushed (but let me know if you disagree with any of these). Gerald --- htdocs/gcc-10/changes.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/htdocs/gcc-10/changes.html b/

[Ada] Minor tweaks to dispatching support code

2022-06-01 Thread Pierre-Marie de Rodat via Gcc-patches
No functional changes. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_disp.ads (Expand_Interface_Thunk): Change type of Prim. * exp_disp.adb (Expand_Interface_Thunk): Declare Is_Predef_Op earlier, do not initialize Iface_Formal, use No idiom and tweaks

[Ada] Couple of minor tweaks to Eval_Fat.Succ

2021-04-29 Thread Pierre-Marie de Rodat
This saves a few cycles by using Ureal_Half instead of Ureal_1. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * eval_fat.adb (Succ): Use Ureal_Half in a couple of places.diff --git a/gcc/ada/eval_fat.adb b/gcc/ada/eval_fat.adb --- a/gcc/ada/eval_fat.adb +++ b/gcc/ada/eval_fa

[Ada] Minor tweaks in gigi

2018-06-12 Thread Eric Botcazou
Tested on x86-64/Linux, applied on mainline, 8 and 7 branches. 2018-06-12 Eric Botcazou * gcc-interface/ada-tree.h (TYPE_RETURN_BY_DIRECT_REF_P): Change from using TYPE_LANG_FLAG_4 to using TYPE_LANG_FLAG_0. (TYPE_ALIGN_OK): Move around. (TYPE_PADDING_FOR_COMPO

[Ada] Minor tweaks to gnat.dg testsuite

2018-02-16 Thread Eric Botcazou
The gnat.dg testsuite contains a dozen of spurious failures on 64-bit Windows because of a couple of issues: the target is P64 and some patterns in filename give rise to warning at link time. Fixed thusly, applied to all active branches. 2018-02-16 Eric Botcazou PR ada/84277

Re: [patch,avr] minor tweaks for 8-bit operations

2016-07-29 Thread Georg-Johann Lay
performed with less instructions / register pressure. - comparing HI against -1 Ok for trunk? Johann gcc/ Minor tweaks for QImode. * config/avr/predicates.md (const_m255_to_m1_operand): New. * config/avr/constraints.md (Cn8, Ca1, Co1, Yx2): New constraints

Re: [patch,avr] minor tweaks for 8-bit operations

2016-07-14 Thread Georg-Johann Lay
, R10 ADD R20, -42 MOV R10, R20 I even came across situations where reload reloads the const_int to a "l" register which might cost up to 4 instructions for the constant alone! Johann - comparing HI against -1 Ok for trunk? Johann gcc/ Minor tweaks for QIm

Re: [patch,avr] minor tweaks for 8-bit operations

2016-07-13 Thread Denis Chertykov
; with less instructions / register pressure. > > - comparing HI against -1 > > Ok for trunk? > > Johann > > > gcc/ > Minor tweaks for QImode. > > * config/avr/predicates.md (const_m255_to_m1_operand): New. > * config/avr/constraints.m

Re: [patch,avr] minor tweaks for 8-bit operations

2016-07-13 Thread Senthil Kumar Selvaraj
provides? Regards Senthil > > - comparing HI against -1 > > Ok for trunk? > > Johann > > > gcc/ > Minor tweaks for QImode. > > * config/avr/predicates.md (const_m255_to_m1_operand): New. > * config/avr/constraints.md (Cn8, Ca1, Co1, Yx2): New c

[patch,avr] minor tweaks for 8-bit operations

2016-07-13 Thread Georg-Johann Lay
trunk? Johann gcc/ Minor tweaks for QImode. * config/avr/predicates.md (const_m255_to_m1_operand): New. * config/avr/constraints.md (Cn8, Ca1, Co1, Yx2): New constraints. * config/avr/avr.md (add3) : Make "r,0,r" more expensive. (*cmphi.zer

Minor tweaks to documentation of scalar_storage_order

2016-01-25 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline as obvious. 2016-01-25 Eric Botcazou * doc/extend.texi (scalar_storage_order type attribute): Fix typo and improve wording for mixed storage order support. -- Eric BotcazouIndex: doc/extend.texi ===

[testsuite] Minor tweaks for visium

2015-09-13 Thread Eric Botcazou
The FPU of the GR5 doesn't preserve NaNs so the new signbit test added to type-generic-1.c fails. Same as ARM for Wno-frame-address.c. The range of offset in addresses is quite limited so there is one more IV in loop-8.c. Tested on visium-elf, applied on the mainline. 2015-09-13 Eric Botcaz

Re: [PATCH 0/3] Minor tweaks to jit

2014-11-06 Thread David Malcolm
On Thu, 2014-11-06 at 16:51 -0700, Jeff Law wrote: > On 11/05/14 13:54, David Malcolm wrote: > > Here are some minor tweaks I've made on the JIT branch since v3 of > > the review began. > > > > Are the following OK for trunk, assuming the rest of the JIT work > &

Re: [PATCH 0/3] Minor tweaks to jit

2014-11-06 Thread Jeff Law
On 11/05/14 13:54, David Malcolm wrote: Here are some minor tweaks I've made on the JIT branch since v3 of the review began. Are the following OK for trunk, assuming the rest of the JIT work is approved? David Malcolm (3): New test cases Documentation tweak Add comments to va

[PATCH 0/3] Minor tweaks to jit

2014-11-05 Thread David Malcolm
Here are some minor tweaks I've made on the JIT branch since v3 of the review began. Are the following OK for trunk, assuming the rest of the JIT work is approved? David Malcolm (3): New test cases Documentation tweak Add comments to various functions in libgccjit.h gcc/jit/docs/t

Minor tweaks in ipa-inline.c

2014-10-31 Thread Eric Botcazou
The usual typo and formatting issues, although there was a novelty since want_inline_function_to_all_callers_p used a consistent 3-space indentation. The function also called twice node->ultimate_alias_target () for no valid reasons so the patch cleans that up too. No functional changes. Tested

[v3] Minor tweaks

2014-10-24 Thread Paolo Carlini
Hi, tested x86_64-linux. Thanks, Paolo. /// 2014-10-24 Paolo Carlini * include/bits/atomic_base.h: Avoid including . * include/std/atomic: When __cplusplus < 201103L skip the rest of the header. * testsuite/29_atomics/headers/atomic/std_c+

Minor tweaks

2014-05-14 Thread Eric Botcazou
This removes a useless local variable in emit_to_new_bb_before coming from a patch that was later reverted, thus restoring the original code, changes the type of locations in try_forward_edges to location_t and fixes inconsistent comments I added to rtl_merge_blocks and cfg_layout_merge_blocks.

Re: [wide-int] Various minor tweaks

2013-10-29 Thread Mike Stump
On Oct 29, 2013, at 2:21 PM, Richard Sandiford wrote: > I looked through the diff of wide-int with mainline and noticed a few > minor things to tweak. > It all seemed pretty obvious, and the patch is long and mechanical, > so I went ahead and installed it. I reviewed it, looks good.

[wide-int] Various minor tweaks

2013-10-29 Thread Richard Sandiford
I looked through the diff of wide-int with mainline and noticed a few minor things to tweak. This patch: - Fixes comment typos that I'd introducted. - Fixes spurious whitespace differences. - Uses const X & instead of X for *wide_int parameters. - Fuses declarations and initialisers. - Avoids unn

[SPARC] Minor tweaks

2013-03-23 Thread Eric Botcazou
The correct test for the pointer size in sparc_emit_probe_stack_range is TARGET_ARCH64 instead of TARGET_64BIT. The patch also adds predicates to the 3rd argument of ctrapsi4 and ctrapdi4. Tested on SPARC/Solaris, applied on the mainline. 2013-03-23 Eric Botcazou * config/sparc/sp

[Ada] Minor tweaks in gnat_to_gnu

2012-11-09 Thread Eric Botcazou
This fixes a couple of cases where gnat_to_gnu would recurse on an empty node and removes all traces of SCIL references from gigi. Tested on x86_64-suse-linux, applied on mainline. 2012-11-09 Eric Botcazou * gcc-interface/trans.c (gnat_to_gnu) : Deal with a missing library u

[Ada] Couple of minor tweaks

2012-10-02 Thread Eric Botcazou
This avoids applying the NRV optimization for small structures and creating useless elaboration variables for loops. Tested on x86_64-suse-linux, applied on the mainline and 4.7 branch. 2012-10-02 Eric Botcazou * gcc-interfaces/decl.c (elaborate_expression_1): Use the variable for

Minor tweaks in optimize_bitfield_assignment_op

2012-03-24 Thread Eric Botcazou
optimize_bitfield_assignment_op deals with PLUS_EXPR/MINUS_EXPR on the one hand and with BIT_IOR_EXPR/BIT_XOR_EXPR on the other hand. The code for the former pair uses str_mode/str_bitsize whereas the code for the latter pair uses the more convoluted GET_MODE (str_rtx) and GET_MODE_BITSIZE (GET

Re: [patch] Minor tweaks

2012-03-19 Thread Eric Botcazou
> Ok. I think volatilep should be always set as well. Thanks. No strong opinion, but at least one caller (fold_truthop through decode_field_reference) calls the function 4 times in a row and only checks volatilep at the end to disable the transformation. -- Eric Botcazou

Re: [patch] Minor tweaks

2012-03-19 Thread Richard Guenther
On Mon, Mar 19, 2012 at 1:21 PM, Eric Botcazou wrote: > Hi, > > around line 380, we have in tree.def: > > /* References to storage.  */ > > /* The ordering of the following codes is optimized for the classification >   in handled_component_p.  Keep them in a consecutive group.  */ > > The hitch is

[patch] Minor tweaks

2012-03-19 Thread Eric Botcazou
Hi, around line 380, we have in tree.def: /* References to storage. */ /* The ordering of the following codes is optimized for the classification in handled_component_p. Keep them in a consecutive group. */ The hitch is that VIEW_CONVERT_EXPR is far apart from the others, so the patch pu

[SPARC] Minor tweaks

2011-07-09 Thread Eric Botcazou
This removes a couple of unused macros and moves another around. Tested on SPARC/Solaris, applied on the mainline. 2011-07-09 Eric Botcazou * config/sparc/sparc.h (STACK_SAVEAREA_MODE): Move around. (FP_REG_P): Delete. (IN_OR_GLOBAL_P): Likewise. -- Eric Botcazou I

Re: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns

2011-06-13 Thread H.J. Lu
On Mon, Jun 13, 2011 at 2:40 AM, Kaushik Phatak wrote: > Hi Jeff, > Thanks for the quick review. > >>> the right test is rtx_equal_p(operands[0], operands[1]) > Committed with above changes to the bsetqi_msx, bclrqi_msx and bnotqi_msx > patterns. > Commit is incorrect. Testsuite ChangeLog entri

Re: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns

2011-06-13 Thread Eric Botcazou
> 2011-06-09 Kaushik Phatak > > * config/h8300/h8300.md (bsetqi_msx, bclrqi_msx, bnotqi_msx): Added > condition to disallow non-identical memory locations. > (*andqi3_2, andqi3_1, iorqi3_1, xorqi3_1): Reorder insn to give > preference to bit manipulation instructions. >

RE: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns

2011-06-13 Thread Kaushik Phatak
[mailto:l...@redhat.com] Sent: 11 June 2011 00:01 To: Kaushik Phatak Cc: gcc-patches@gcc.gnu.org; Prafulla Thakare Subject: Re: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/09/11 01:20, Kaushik Phatak wrote: > Hi, > The follo

Re: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns

2011-06-10 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/09/11 01:20, Kaushik Phatak wrote: > Hi, > The following patch fixes an ICE that is generated when the compiler tries > to perform bit manipulation for logical operations when the source and > destination address does not match. The testcase is

[Patch : H8300] Bug fix for bit insn and minor tweaks to insns

2011-06-09 Thread Kaushik Phatak
Hi, The following patch fixes an ICE that is generated when the compiler tries to perform bit manipulation for logical operations when the source and destination address does not match. The testcase is also included in the patch(gcc.dg). The additional condition in the insn takes care of the ICE

Minor tweaks

2011-05-13 Thread Eric Botcazou
The attached patch contains 3 minor tweaks: 1. Jeff moved a dump message in cfg_layout_redirect_edge_and_branch up to before the call to redirect_edge_succ_nodup. So the "redirected" is not fully true anymore and can be confusing since the call to redirect_edge_succ_nodup can dum