Re: Add the latest C++ SD-6 additions.

2014-11-12 Thread Markus Trippelsdorf
On 2014.11.11 at 19:15 +0100, Markus Trippelsdorf wrote: > On 2014.11.10 at 10:55 -0500, Ed Smith-Rowland wrote: > > On 11/09/2014 11:45 PM, Jason Merrill wrote: > > > On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: > > >> + //cpp_hashnode *node = 0; > > >> + //node = token->val.node.node; >

Re: Add the latest C++ SD-6 additions.

2014-11-11 Thread Markus Trippelsdorf
On 2014.11.10 at 10:55 -0500, Ed Smith-Rowland wrote: > On 11/09/2014 11:45 PM, Jason Merrill wrote: > > On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: > >> + //cpp_hashnode *node = 0; > >> + //node = token->val.node.node; > >> + //if (node) > >> + // pfile->mi_ind_cmacro = node; > > > >

Re: Add the latest C++ SD-6 additions.

2014-11-11 Thread Jason Merrill
On 11/11/2014 12:52 AM, Ed Smith-Rowland wrote: I'll might put this to the SD-6 list because it would be nice to have clarity - even if it's "implementation defined". Sounds good. I was thinking that defining to 0 tells the user "this isn't supported" which seems more useful than "this may or

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Ed Smith-Rowland
On 11/10/2014 12:10 PM, Jason Merrill wrote: On 11/10/2014 10:55 AM, Ed Smith-Rowland wrote: Would a 4.9 version be accepted? Sure. What do you think about defining the macros for unsupported features to 0 rather than leaving them undefined? The document doesn't seem to specify. Jason

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Jason Merrill
On 11/10/2014 10:55 AM, Ed Smith-Rowland wrote: Would a 4.9 version be accepted? Sure. What do you think about defining the macros for unsupported features to 0 rather than leaving them undefined? The document doesn't seem to specify. Jason

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Ed Smith-Rowland
On 11/09/2014 11:45 PM, Jason Merrill wrote: On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: + //cpp_hashnode *node = 0; + //node = token->val.node.node; + //if (node) + // pfile->mi_ind_cmacro = node; Remove this commented-out code? The patch is OK. Jason Here is the committed pa

Re: Add the latest C++ SD-6 additions.

2014-11-09 Thread Jason Merrill
On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: + //cpp_hashnode *node = 0; + //node = token->val.node.node; + //if (node) + // pfile->mi_ind_cmacro = node; Remove this commented-out code? The patch is OK. Jason

Add the latest C++ SD-6 additions.

2014-11-09 Thread Ed Smith-Rowland
I would like to put this patch out before Stage 1 ends even if there is bikeshed renaming of macros in the next couple weeks as the C++ committee wraps up after their meeting. The main part of this patch is a __has_cpp_attribute macro. #if __has_cpp_attribute(foobar) #else #endif In C++ we can