On 2014.11.10 at 10:55 -0500, Ed Smith-Rowland wrote: > On 11/09/2014 11:45 PM, Jason Merrill wrote: > > On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: > >> + //cpp_hashnode *node = 0; > >> + //node = token->val.node.node; > >> + //if (node) > >> + // pfile->mi_ind_cmacro = node; > > > > Remove this commented-out code? > > > > The patch is OK. > > > > Jason > > > > > Here is the committed patch. It has those comments removed and has some > test case cleanup.
This patch causes numerous segfaults when building Firefox, e.g.: (4.9 is fine:) trippels@gcc1-power7 gecko-dev % g++ -I /home/trippels/gecko-dev/intl/icu/source/common -MM test.cpp test.o: test.cpp \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/utf_old.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/utf.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/umachine.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/ptypes.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/platform.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/uconfig.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/uvernum.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/urename.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/utf8.h \ /home/trippels/gecko-dev/intl/icu/source/common/unicode/utf16.h (trunk crashes:) trippels@gcc1-power7 gecko-dev % /home/trippels/gcc_test/usr/local/bin/g++ -I /home/trippels/gecko-dev/intl/icu/source/common -MM test.cpp <built-in>: internal compiler error: Segmentation fault 0x109b64ab crash_signal ../../gcc/gcc/toplev.c:358 0x110b3d30 parse_has_attribute ../../gcc/libcpp/expr.c:2165 0x110b3d30 eval_token ../../gcc/libcpp/expr.c:1059 0x110b3d30 _cpp_parse_expr ../../gcc/libcpp/expr.c:1227 Please submit a full bug report, with preprocessed source if appropriate. Please include the complete backtrace with any bug report. See <http://gcc.gnu.org/bugs.html> for instructions. -- Markus