Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Alexandre Oliva
Hello, Martin, On Dec 16, 2020, Martin Liška wrote: > On 10/1/19 10:58 AM, Alexandre Oliva wrote: >> + if (opts->x_flag_asynchronous_unwind_tables == 2) >> +opts->x_flag_unwind_tables >> + = opts->x_flag_asynchronous_unwind_tables = 1; > Anyway the code seems fishy, shouldn't it b

Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Uros Bizjak via Gcc-patches
On Wed, Dec 16, 2020 at 2:18 PM Martin Liška wrote: > > On 10/1/19 10:58 AM, Alexandre Oliva wrote: > > + if (opts->x_flag_asynchronous_unwind_tables == 2) > > + opts->x_flag_unwind_tables > > + = opts->x_flag_asynchronous_unwind_tables = 1; > > Hello. > > Spotted that when I tried

Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Martin Liška
On 10/1/19 10:58 AM, Alexandre Oliva wrote: + if (opts->x_flag_asynchronous_unwind_tables == 2) + opts->x_flag_unwind_tables + = opts->x_flag_asynchronous_unwind_tables = 1; Hello. Spotted that when I tried to make x_flag_asynchronous_unwind_tables a boolean flag. Anyway t

Re: [x86] recompute opt flags after opt level change

2019-10-01 Thread Uros Bizjak
On Tue, Oct 1, 2019 at 10:59 AM Alexandre Oliva wrote: > > flag_omit_frame_pointer is set in machine-independent code depending > on the optimization level. It is then overridden in x86 > target-specific code depending on a macro defined by > --enable-frame-pointer. > > Uses of attribute optimize

[x86] recompute opt flags after opt level change

2019-10-01 Thread Alexandre Oliva
flag_omit_frame_pointer is set in machine-independent code depending on the optimization level. It is then overridden in x86 target-specific code depending on a macro defined by --enable-frame-pointer. Uses of attribute optimize go through machine-independent overriding of flag_omit_frame_pointer