On Wed, Dec 16, 2020 at 2:18 PM Martin Liška <mli...@suse.cz> wrote:
>
> On 10/1/19 10:58 AM, Alexandre Oliva wrote:
> > +      if (opts->x_flag_asynchronous_unwind_tables == 2)
> > +     opts->x_flag_unwind_tables
> > +       = opts->x_flag_asynchronous_unwind_tables = 1;
>
> Hello.
>
> Spotted that when I tried to make x_flag_asynchronous_unwind_tables a boolean 
> flag.
>
> Anyway the code seems fishy, shouldn't it be:
>
>        if (opts->x_flag_asynchronous_unwind_tables == 2)
>         opts->x_flag_unwind_tables
>           = opts->x_flag_asynchronous_unwind_tables == 1; <---- '==' instead 
> of '='

It should be OK. Please note that

opts->x_flag_asynchronous_unwind_tables == 1

will never be true due to preceding condition.

Uros.
>
> Thanks,
> Martin

Reply via email to