Re: [v3] define string::pop_back()

2011-11-07 Thread Jonathan Wakely
On 7 November 2011 10:57, Eric Botcazou wrote: >> Won't that fail to match string::max_size? > > No, if it doesn't appear in the list, then it isn't matched by the regexp. > >> For GNU I added a regex for that explicitly: >> >> +    _ZNKSs8max_size*; >> +    _ZNKSbIwSt11char_traitsIwESaIwEE8max_siz

Re: [v3] define string::pop_back()

2011-11-07 Thread Eric Botcazou
> Won't that fail to match string::max_size? No, if it doesn't appear in the list, then it isn't matched by the regexp. > For GNU I added a regex for that explicitly: > > +_ZNKSs8max_size*; > +_ZNKSbIwSt11char_traitsIwESaIwEE8max_size*; What is GNU here? The Solaris version file is a ma

Re: [v3] define string::pop_back()

2011-11-07 Thread Jonathan Wakely
On 7 November 2011 09:40, Eric Botcazou wrote: >> Thanks, I'll try to work out the right adjustment for the solaris >> symbols file but can't test it. > > The 2 new symbols are duplicated, because they are matched by a regexp: > >    ##_ZNSs[0-58-9][g-z]* (glob) >    _ZNSs4nposE; >    _ZNSs4rendEv;

Re: [v3] define string::pop_back()

2011-11-07 Thread Eric Botcazou
> Thanks, I'll try to work out the right adjustment for the solaris > symbols file but can't test it. The 2 new symbols are duplicated, because they are matched by a regexp: ##_ZNSs[0-58-9][g-z]* (glob) _ZNSs4nposE; _ZNSs4rendEv; _ZNSs4swapERSs; _ZNSs8pop_backEv; _ZNSs9pus

Re: [v3] define string::pop_back()

2011-11-07 Thread Jonathan Wakely
On 7 November 2011 09:17, Eric Botcazou wrote: >>         * include/bits/basic_string.h (basic_string::at): Move adjacent to >> other overload. >>         (basic_string::pop_back): Define. >>         * include/debug/string (__gnu_debug::basic_string::pop_back): >> Likewise. * include/ext/vstring.h

Re: [v3] define string::pop_back()

2011-11-07 Thread Eric Botcazou
> * include/bits/basic_string.h (basic_string::at): Move adjacent to > other overload. > (basic_string::pop_back): Define. > * include/debug/string (__gnu_debug::basic_string::pop_back): > Likewise. * include/ext/vstring.h (__versa_string::pop_back): Likewise. * > config/abi

Re: [v3] define string::pop_back()

2011-11-06 Thread Jonathan Wakely
I first posted this a month ago, this adjusts the exports and moves the tests under separate char and wchar_t directories as requested by Paolo. * include/bits/basic_string.h (basic_string::at): Move adjacent to other overload. (basic_string::pop_back): Define. * in

Re: [v3] define string::pop_back()

2011-10-04 Thread Jonathan Wakely
On 4 October 2011 23:41, Paolo Carlini wrote: > .. another nit: normally basic_string testcases are added in pairs, for char > and wchar_t, in the appropriate subdirs... I see range_access.cc should be > adjusted... Good points, I'll deal with that and the exports before checking in, thanks.

Re: [v3] define string::pop_back()

2011-10-04 Thread Paolo Carlini
.. another nit: normally basic_string testcases are added in pairs, for char and wchar_t, in the appropriate subdirs... I see range_access.cc should be adjusted... Paolo.

Re: [v3] define string::pop_back()

2011-10-04 Thread Paolo Carlini
On 10/04/2011 11:35 PM, Jonathan Wakely wrote: Tested x86_64-linux, any objections to committing? No objections, but I think the basic_string exports have to be adjusted, to export the new member functions at the current minor version. Paolo.

[v3] define string::pop_back()

2011-10-04 Thread Jonathan Wakely
This adds the new C++11 pop_back() member to , and , as added by LWG 534. * include/bits/basic_string.h (basic_string::pop_back): Define. * include/ext/vstring.h (versa_string::pop_back): Define. * include/debug/string (basic_string::pop_back): Define. * testsuite/