Re: [patch] remove gate for ipa_inline pass

2013-12-16 Thread Trevor Saunders
On Mon, Dec 16, 2013 at 09:13:41AM -0700, Jeff Law wrote: > On 12/13/13 12:42, Aldy Hernandez wrote: > >I'm fixing something completely unrelated, and noticed this... > > > >Perhaps I'm missing something, but why do we need a gate when it always > >returns true? Now that we have this `pass_data' b

Re: [patch] remove gate for ipa_inline pass

2013-12-16 Thread Jeff Law
On 12/16/13 11:13, Aldy Hernandez wrote: On 12/16/13 10:07, Jan Hubicka wrote: On 12/13/13 12:42, Aldy Hernandez wrote: I'm fixing something completely unrelated, and noticed this... Perhaps I'm missing something, but why do we need a gate when it always returns true? Now that we have this `p

Re: [patch] remove gate for ipa_inline pass

2013-12-16 Thread Aldy Hernandez
On 12/16/13 10:07, Jan Hubicka wrote: On 12/13/13 12:42, Aldy Hernandez wrote: I'm fixing something completely unrelated, and noticed this... Perhaps I'm missing something, but why do we need a gate when it always returns true? Now that we have this `pass_data' business, we can set has_gate to

Re: [patch] remove gate for ipa_inline pass

2013-12-16 Thread Jan Hubicka
> On 12/13/13 12:42, Aldy Hernandez wrote: > >I'm fixing something completely unrelated, and noticed this... > > > >Perhaps I'm missing something, but why do we need a gate when it always > >returns true? Now that we have this `pass_data' business, we can set > >has_gate to false. > > > >I also fi

Re: [patch] remove gate for ipa_inline pass

2013-12-16 Thread Aldy Hernandez
On 12/16/13 08:13, Jeff Law wrote: On 12/13/13 12:42, Aldy Hernandez wrote: I'm fixing something completely unrelated, and noticed this... Perhaps I'm missing something, but why do we need a gate when it always returns true? Now that we have this `pass_data' business, we can set has_gate to fa

Re: [patch] remove gate for ipa_inline pass

2013-12-16 Thread Jeff Law
On 12/13/13 12:42, Aldy Hernandez wrote: I'm fixing something completely unrelated, and noticed this... Perhaps I'm missing something, but why do we need a gate when it always returns true? Now that we have this `pass_data' business, we can set has_gate to false. I also fixed a minor typo in a

[patch] remove gate for ipa_inline pass

2013-12-13 Thread Aldy Hernandez
I'm fixing something completely unrelated, and noticed this... Perhaps I'm missing something, but why do we need a gate when it always returns true? Now that we have this `pass_data' business, we can set has_gate to false. I also fixed a minor typo in a comment. Tested on x86-64 Linux. OK?