On 12/16/13 11:13, Aldy Hernandez wrote:
On 12/16/13 10:07, Jan Hubicka wrote:
On 12/13/13 12:42, Aldy Hernandez wrote:
I'm fixing something completely unrelated, and noticed this...

Perhaps I'm missing something, but why do we need a gate when it always
returns true?  Now that we have this `pass_data' business, we can set
has_gate to false.

I also fixed a minor typo in a comment.
Note that the way we handle pass properties differs when we have a
gate vs no gate.  See register_dump_files_1.

Removing the gate is OK.  It used to be enabled only
with -finline-functions until we started to rely on inliner to handle
other things - always_inline and CFG fixups.

Honza


Alright.  Are you OK Jeff with me removing it then?
Yes -- Jan knows the IPA code better than I and thus is in a better position to know if the differences in how properties are handled for gate/no-gate are an issue or not for the IPA passes.

Jeff

Reply via email to