Re: [patch] Fix timevar internal consistency failure

2016-02-10 Thread Michael Matz
Hi, On Wed, 10 Feb 2016, David Malcolm wrote: > > +static timevar_id_t global_phase; > > FWIW I like the idea, but could this be a private field within class > timer, rather than a global? Sure, consider the patch amended accordingly. Ciao, Michael.

Re: [patch] Fix timevar internal consistency failure

2016-02-10 Thread David Malcolm
On Wed, 2016-02-10 at 15:15 +0100, Michael Matz wrote: > Hi, > > On Wed, 10 Feb 2016, Richard Biener wrote: > > > > The problem is that TV_PHASE_DBGINFO is now nested within > > > TV_PHASE_OPT_GEN, which violates the above mutual exclusivity > > > requirement. Therefore the attached patch simp

Re: [patch] Fix timevar internal consistency failure

2016-02-10 Thread Michael Matz
Hi, On Wed, 10 Feb 2016, Richard Biener wrote: > > The problem is that TV_PHASE_DBGINFO is now nested within > > TV_PHASE_OPT_GEN, which violates the above mutual exclusivity > > requirement. Therefore the attached patch simply gets rid of > > TV_PHASE_DBGINFO (as well as of the sibling TV_PH

Re: [patch] Fix timevar internal consistency failure

2016-02-10 Thread Richard Biener
On Wed, Feb 10, 2016 at 10:55 AM, Eric Botcazou wrote: > Hi, > > I just ran into a timevar internal consistency failure with -ftime-report: > > Execution times (seconds) > phase setup : 0.00 ( 0%) usr 0.00 ( 0%) sys 0.01 ( 0%) wall > 114 kB ( 0%) ggc > phase parsing :

[patch] Fix timevar internal consistency failure

2016-02-10 Thread Eric Botcazou
Hi, I just ran into a timevar internal consistency failure with -ftime-report: Execution times (seconds) phase setup : 0.00 ( 0%) usr 0.00 ( 0%) sys 0.01 ( 0%) wall 114 kB ( 0%) ggc phase parsing : 0.29 ( 7%) usr 0.01 ( 9%) sys 0.30 ( 7%) wall [...] rep