Re: [patch] Do not include output.h everywhere

2012-06-04 Thread Steven Bosscher
On Mon, Jun 4, 2012 at 11:42 AM, Richard Guenther wrote: > There is already statistics.h and tree-dump.h, why is dump_file not in > tree-dump.h for example?  I admit it's all some of a mess ;) Because tree-dump.h is about tree dumps (and gimple dumps). Yes, it is a mess. > But system.h > doesn't

Re: [patch] Do not include output.h everywhere

2012-06-04 Thread Richard Guenther
On Mon, Jun 4, 2012 at 9:00 AM, Steven Bosscher wrote: > On Fri, Jun 1, 2012 at 11:19 AM, Richard Guenther > wrote: >>> What about toplev.h?  dump_file is defined there, after all.  I don't mind >>> it in system.h, if that's not a good place for it now.  The patch is OK >>> either way. >> >> I'd

Re: [patch] Do not include output.h everywhere

2012-06-04 Thread Steven Bosscher
On Fri, Jun 1, 2012 at 11:19 AM, Richard Guenther wrote: >> What about toplev.h?  dump_file is defined there, after all.  I don't mind >> it in system.h, if that's not a good place for it now.  The patch is OK >> either way. > > I'd prefer toplev.h, too.  system.h is supposed to be for system head

Re: [patch] Do not include output.h everywhere

2012-06-01 Thread Richard Guenther
On Thu, May 31, 2012 at 9:21 PM, Diego Novillo wrote: > On 12-05-31 14:57 , Steven Bosscher wrote: >> >> Hello, >> >> Almost all files include output.h because it defines dump_file. IMHO >> output.h should only be included in files that actually output >> something to asm_out_file. Therefore wante

Re: [patch] Do not include output.h everywhere

2012-05-31 Thread Diego Novillo
On 12-05-31 14:57 , Steven Bosscher wrote: Hello, Almost all files include output.h because it defines dump_file. IMHO output.h should only be included in files that actually output something to asm_out_file. Therefore wanted to I move dump_file to some other include file. I ended up with system