On Mon, Jun 4, 2012 at 9:00 AM, Steven Bosscher <stevenb....@gmail.com> wrote: > On Fri, Jun 1, 2012 at 11:19 AM, Richard Guenther > <richard.guent...@gmail.com> wrote: >>> What about toplev.h? dump_file is defined there, after all. I don't mind >>> it in system.h, if that's not a good place for it now. The patch is OK >>> either way. >> >> I'd prefer toplev.h, too. system.h is supposed to be for system header >> inclusion (and related workarounds). > (..) >> Thus, ok with moving to toplev.h instead. > > I had already committed this on Friday. > > The problem with toplev.h is that it isn't included in any tree-*.c > file (except tree-dump.c and tree-optimize.c). Also, there is nothing > "top-level" about an RTL or GIMPLE pass. Perhaps I should create a new > header with all the dump and statistics stuff?
There is already statistics.h and tree-dump.h, why is dump_file not in tree-dump.h for example? I admit it's all some of a mess ;) But system.h doesn't look right to me. Richard. > Ciao! > Steven
