Re: [patch] 16/n: trans-mem: compiler parser/front-end

2011-11-04 Thread Richard Henderson
On 11/03/2011 01:44 PM, Richard Henderson wrote: > On 11/03/2011 01:34 PM, Joseph S. Myers wrote: >> On Thu, 3 Nov 2011, Aldy Hernandez wrote: >> >>> +/* Parse a transaction attribute (GCC Extension). >>> + >>> + transaction-attribute: >>> + attributes >>> + [ [ any-word ] ] >> >> I don't

Re: [patch] 16/n: trans-mem: compiler parser/front-end

2011-11-03 Thread Richard Henderson
On 11/03/2011 01:34 PM, Joseph S. Myers wrote: > On Thu, 3 Nov 2011, Aldy Hernandez wrote: > >> +/* Parse a transaction attribute (GCC Extension). >> + >> + transaction-attribute: >> + attributes >> + [ [ any-word ] ] > > I don't see any syntax production comments including > transacti

Re: [patch] 16/n: trans-mem: compiler parser/front-end

2011-11-03 Thread Joseph S. Myers
On Thu, 3 Nov 2011, Aldy Hernandez wrote: > +/* Parse a transaction attribute (GCC Extension). > + > + transaction-attribute: > + attributes > + [ [ any-word ] ] I don't see any syntax production comments including transaction-attribute. Please update the comments to include this in

[patch] 16/n: trans-mem: compiler parser/front-end

2011-11-03 Thread Aldy Hernandez
Parser and some front-end stuff, like tree definitions, etc. Index: gcc/c-parser.c === --- gcc/c-parser.c (.../trunk) (revision 180744) +++ gcc/c-parser.c (.../branches/transactional-memory) (revision 180773) @@ -1