On 11/03/2011 01:44 PM, Richard Henderson wrote:
> On 11/03/2011 01:34 PM, Joseph S. Myers wrote:
>> On Thu, 3 Nov 2011, Aldy Hernandez wrote:
>>
>>> +/* Parse a transaction attribute (GCC Extension).
>>> +
>>> + transaction-attribute:
>>> + attributes
>>> + [ [ any-word ] ]
>>
>> I don't see any syntax production comments including
>> transaction-attribute. Please update the comments to include this in
>> every case where it is permitted.
>
> Ah, the comment in question is currently
>
> __transaction_atomic attributes[opt] compound-statement
>
> where that should be transaction-attributes[opt] instead.
>
> Will fix.
Like so.
r~
* c-parser.c: Fix production comments using transaction-attribute.
diff --git a/gcc/c-parser.c b/gcc/c-parser.c
index 88bf08b..a44923d 100644
--- a/gcc/c-parser.c
+++ b/gcc/c-parser.c
@@ -10555,7 +10555,7 @@ c_parser_transaction_attributes (c_parser *parser)
(GCC Extension).
transaction-statement:
- __transaction_atomic attributes[opt] compound-statement
+ __transaction_atomic transaction-attribute[opt] compound-statement
__transaction_relaxed compound-statement
Note that the only valid attribute is: "outer".
@@ -10664,7 +10664,7 @@ c_parser_transaction_expression (c_parser *parser, enum
rid keyword)
/* Parse a __transaction_cancel statement (GCC Extension).
transaction-cancel-statement:
- __transaction_cancel attributes[opt] ;
+ __transaction_cancel transaction-attribute[opt] ;
Note that the only valid attribute is "outer".
*/
